From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb0-f179.google.com (mail-yb0-f179.google.com [209.85.213.179]) by dpdk.org (Postfix) with ESMTP id 3C4C74CE4 for ; Mon, 5 Sep 2016 11:18:16 +0200 (CEST) Received: by mail-yb0-f179.google.com with SMTP id x93so58538362ybh.1 for ; Mon, 05 Sep 2016 02:18:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outscale-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=EGpi6f5WT1pI06XIPAyEpTvWFlePaylJc/UVkV+ONgc=; b=WmstkHiQMgnDMX2LsIH4YazeULbzJE+HSrcaAO6af+W2SKpDXQKNZgmy3v3G3p2HW1 dDmWuVSDEoAwF3CSEDmw/WKersw/H/EtgGEaB7ZebanMOAcCb+OK71ItjzSePf8ebl6s R+/Qn4K0eKKAzM27Lal3BfWo6K+noWmciVDg8syBC71vSWWHlcSPVJ4yCVPaS5KPFabs rur+JnaKWagEeBlPrlbJoBEoZeN3DXDC3jav40KPevu3kmsnI39hQS4y9JH/fJAHevls CSiQgvMyG28bzB/oqR9eyDE7pGoOkRZFujZCDkukUaqU0eyWm7rO1aYoUR/VBZDqf/v0 hKlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=EGpi6f5WT1pI06XIPAyEpTvWFlePaylJc/UVkV+ONgc=; b=I8U/SBYxPxI9x4QF9iaTec0RLiLuyexSxpXGC6QLn4M90dHcRVRJ+1Vbhu7BxWZn38 QkPeqyamtiQ6JeQvX9C54VnNutsRNMR2cSkfeIZgRmLIGyPdhwoa0mji6DkRHgLI3zLB 0RSi9cuU8fOmh6RJwv95AZSbvbufPGDGns8hETskv49gsGsGjK3O5blChF4HnvVziM/t 5EwZXNBU7LypCKHSrnc34bR6WbAtd+5dabH+ARk8egzVHV8CKrDB55Udlo4S7qlwgFBJ O3OMPcKwwe+ITNhrBCBQ/C85uJ5QHUO/yMh5DA4G/x41q3wr4LNraWRWsODLNXcu9deu fh5A== X-Gm-Message-State: AE9vXwMglvZMT0SI9c0ehfVlQRWakEqulXji0GtJhbLbfwpeoU600QauSGJeAxv1ZOMeYUBge+5PMMYgXhVaQr6I X-Received: by 10.37.19.132 with SMTP id 126mr25821878ybt.113.1473067095649; Mon, 05 Sep 2016 02:18:15 -0700 (PDT) MIME-Version: 1.0 Received: by 10.37.211.74 with HTTP; Mon, 5 Sep 2016 02:18:15 -0700 (PDT) In-Reply-To: <20160905022525.GG30752@yliu-dev.sh.intel.com> References: <20160902150521.680-1-matthias.gatto@outscale.com> <20160905022525.GG30752@yliu-dev.sh.intel.com> From: Matthias Gatto Date: Mon, 5 Sep 2016 11:18:15 +0200 Message-ID: To: Yuanhan Liu Cc: dev@dpdk.org, huawei.xie@intel.com Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH] virtio: remove obsolete comment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Sep 2016 09:18:16 -0000 On Mon, Sep 5, 2016 at 4:25 AM, Yuanhan Liu wrote: > On Fri, Sep 02, 2016 at 05:05:21PM +0200, Matthias Gatto wrote: >> As new_device and destroy_device use an int instead of a "struct virtio_net *", >> The comment about setting VIRTIO_DEV_RUNNING doesn't make sense anymore, plus >> If I've correctly understand the code, the drivers take care of >> setting the flag before calling the callbacks, so I guess that this comment >> is obsolet and I've remove it. > > Yes, it is. The flag had been moved for internal use since commit > 550c9d27d143 ("vhost: set/reset device flags internally"). > > So, thanks and applied to dpdk-next-virtio. > > --yliu thanks for the review and for applied the patch. Matthias