From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com [209.85.220.42]) by dpdk.org (Postfix) with ESMTP id EC5495686 for ; Tue, 12 Jan 2016 05:23:33 +0100 (CET) Received: by mail-pa0-f42.google.com with SMTP id cy9so332712220pac.0 for ; Mon, 11 Jan 2016 20:23:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mvista-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=f9ZbFcyXQ2PAidQKw90VSW24a3S0MXbJowPsBUsgN1c=; b=Yyt1qp/XN2PmNd22PU8V4eDC0uXRnEnVTPz7XbBlyCWg8X0SssNiVVHXaZjzKTwuXx lpuNoBaixz78lvTkRaXCWsz2v6wwyfS0XOjrDPqgjo76JjHhxtMHph0lKiYS4U6/sL5Q l7XZStAoKxrdirM4jrpJeDM3BmxjTBavUI2HwKkFp3Yohsq32RLSXqtwRgR2UXKIKtIe iaGOX0hPMhxVeh6T9jKxmC3tkd8WoLKMa5Vor+YvknrRob/qauPLTpBwzC6zZDLv8xdW /Otoe8ay4yKeJYDVuOQoNVPm/oiBP/QfmMUzxbMUwNfDGlBS7moL2DtY7ZFhYzs/rWcZ nHqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=f9ZbFcyXQ2PAidQKw90VSW24a3S0MXbJowPsBUsgN1c=; b=D0lvT6z4uC+kF8zZXNP6MQNnH05zn44upqvaLuZ3TXvn42uhHoYeMTowK+uWUVosob gwsYQoKYUvtA5HSR48kMZ+4qoOvd1LLvRe+3kSTAMN0VmcOmXrqiXhz5e3rXyQ/7XhAn m/qQf0lg6rCBVSK+7mg7k5xRKpp17ER1mfKNOSoaH6jveG8N6TBWgnvu4r900AMcw0hb z0XyBXVKdVku/YNwTF/Pe7qg800cxCk+KyJq89SZ+ZgmaKd3nsdk648Z5C2S/7yp1KHL fyL4T/QfVQbzdKC6VBb/h211LFARLmE4SxA/2vSPgXiAXgGqS7Pt+cSSwqx/LAW5jmLi QbSQ== X-Gm-Message-State: ALoCoQlzcRJax+CKs0BnTXkSUrKov5PVrG/HVa62gezFOsXwVjZ0sSZed7wLTk5tGef3J4959upYKASbWQz80I5hvHjSW5hJ2Adt28Hbd+IWNw+VgjnhaT8= MIME-Version: 1.0 X-Received: by 10.66.253.97 with SMTP id zz1mr143448088pac.106.1452572613328; Mon, 11 Jan 2016 20:23:33 -0800 (PST) Received: by 10.66.196.81 with HTTP; Mon, 11 Jan 2016 20:23:33 -0800 (PST) In-Reply-To: References: <20151222035041.GA7532@pxdev.xzpeter.org> <1451843773-103006-1-git-send-email-huawei.xie@intel.com> <20160104092507.297de1df@xeon-e3> Date: Tue, 12 Jan 2016 09:53:33 +0530 Message-ID: From: Santosh Shukla To: "Xie, Huawei" Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 0/4] fix the issue that DPDK takes over virtio device blindly X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jan 2016 04:23:34 -0000 On Tue, Jan 12, 2016 at 8:32 AM, Xie, Huawei wrote: > > On 1/5/2016 1:25 AM, Stephen Hemminger wrote: > > On Mon, 4 Jan 2016 01:56:09 +0800 > > Huawei Xie wrote: > > > >> v2 changes: > >> Remove unnecessary assignment of NULL to dev->data->mac_addrs > >> Ajust one comment's position > >> change LOG level from ERR to INFO > >> > >> virtio PMD doesn't set RTE_PCI_DRV_NEED_MAPPING in drv_flags of its > >> eth_driver. It will try igb_uio and PORT IO in turn to configure > >> virtio device. Even user in guest VM doesn't want to use virtio for > >> DPDK, virtio PMD will take over the device blindly. > >> > >> The more serious problem is kernel driver is still manipulating the > >> device, which causes driver conflict. > >> > >> This patch checks if there is any kernel driver manipulating the > >> virtio device before virtio PMD uses port IO to configure the device. > >> > >> Huawei Xie (4): > >> eal: make the comment more accurate > >> eal: set kdrv to RTE_KDRV_NONE if kernel driver isn't manipulating the device. > >> virtio: return 1 to tell the kernel we don't take over this device > >> virtio: check if any kernel driver is manipulating the virtio device > >> > >> drivers/net/virtio/virtio_ethdev.c | 16 ++++++++++++++-- > >> lib/librte_eal/common/eal_common_pci.c | 8 ++++---- > >> lib/librte_eal/linuxapp/eal/eal_pci.c | 2 +- > >> 3 files changed, 19 insertions(+), 7 deletions(-) > >> > > Overall looks good, thanks for addressing this. > > > > It would be good to note that VFIO no-IOMMU mode should work for this > > as well. > > It isn't implemented yet in virtio PMD. I could add a note in the commit > message. Do you plan to implement this? > I can send vfio-noiommu patches for this one, as I am looking at vfio-noiommu for virtio for my arm v4 patch series. Stephen, let me know if you already started working on this? Also for some reason I can't find [3/4] patch, could you point me to patch link? Thanks. > > > >