From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f169.google.com (mail-pf0-f169.google.com [209.85.192.169]) by dpdk.org (Postfix) with ESMTP id EB18D95C7 for ; Wed, 27 Jan 2016 16:56:36 +0100 (CET) Received: by mail-pf0-f169.google.com with SMTP id 65so6733708pfd.2 for ; Wed, 27 Jan 2016 07:56:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mvista-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=dzLkfm1JP8aXW5cHBPeq3PF6KBTT2MoBqNNklD1dEqY=; b=qlQMu/JAI4FGFRshGPr/MJibh6egRFaotLfdeINU8Zja2WT33ZNcdvmJNHTIGQfJKX Z1EXbIeR3W14BtV7XHAXGGe3q5Jt1Bj8gxWfdyvFS50XAvHU7edG1FXOquUpHr+2eZeW vGY0dV0Yxy2tQOQGT8/Fk5DnKsza7XCJ29fJo1PEZlwOWd4noxXv7oLBCyU585FK4jEN /zY9t92XwOsR80Dg8I8o+bmECLqy3t5VUMz7e+Aa09I2nyct6qlgrIzloB2DA0PLyvNW 1DkLjanMgBY7AyZqT2D4RlXYufIMFj01UrVBdBM5kCKBJJ8gc4vLXFvRUBtQHPYTbQw+ b7IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=dzLkfm1JP8aXW5cHBPeq3PF6KBTT2MoBqNNklD1dEqY=; b=EBZymJGWag32Oaq9fDoySXbjGFiB7wcck285E7Vn2Fslog4gzb+SIN63v5RztooFFy EmENkHcj1ALQgMGvC/A/5vAvjLzrdXuEmcXVCdyzbhhARmunNglBi6cXCYnDm66xCA6M LTiKbIq+W4ELU4XbXnfbg+SffdDtRQ6j261URddxwx5zcukoCboB4CxhQNMRYlhgM0r3 hQJZxKp+y4Oi2IOwKV4Plpq1H2DztC626TRu94pqp3+7ZvAqXB744zwOyWbfaI4FscBi 67TMMTzWFtOxIGg3Xz6sIl3OaiOoQ20f3F6Vl10xb+slBkHquWu8HMNEiujarBf9S860 pBjg== X-Gm-Message-State: AG10YOQylyilwuvei/5GBZ6xMaEu6pamfeAko4ciKzGSyYurYkIDWbjzHXo5WIahPleQlx5ncOwFVQ8JFzNWYv+q MIME-Version: 1.0 X-Received: by 10.98.12.131 with SMTP id 3mr44190278pfm.155.1453910196293; Wed, 27 Jan 2016 07:56:36 -0800 (PST) Received: by 10.66.196.81 with HTTP; Wed, 27 Jan 2016 07:56:36 -0800 (PST) In-Reply-To: <25509182.RtDY3IvNbk@xps13> References: <1453229842-15310-1-git-send-email-sshukla@mvista.com> <25509182.RtDY3IvNbk@xps13> Date: Wed, 27 Jan 2016 21:26:36 +0530 Message-ID: From: Santosh Shukla To: Thomas Monjalon Content-Type: text/plain; charset=UTF-8 Cc: "Michael S. Tsirkin" , dev@dpdk.org, Alex Williamson Subject: Re: [dpdk-dev] [PATCH v6 08/11] eal: pci: introduce RTE_KDRV_VFIO_NOIOMMUi driver mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jan 2016 15:56:37 -0000 On Wed, Jan 27, 2016 at 9:09 PM, Thomas Monjalon wrote: > 2016-01-27 21:02, Santosh Shukla: >> 1. virtio currently works for vfio+noiommu and likely will work for >> vfio+iommu in near future. >> 2. So remove __noiommu suffix and always use default. >> 3. Introduce vfio resource parsing global function, That function >> suppose to do parsing for default vfio case and for vfio-noiommu case. >> This function will be used by pmd drivers for resource parsing purpose >> example virtio. >> >> Yuan won't be happy with 3) I guess, because he wanted to get rid of >> interface parsing from pmd driver. >> >> Thomas, if 1/2/3/ addresses your concern then I'll spin the series, > > I agree with 1/ and 2/. > Please, could you explain why 3/ is needed? Because someone should do resource parsing / validation before driver does resource mapping/initialization. That someone could be either EAL layer or driver itself. In my case; - driver is virtio - resource is vfio interface