From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f175.google.com (mail-pf0-f175.google.com [209.85.192.175]) by dpdk.org (Postfix) with ESMTP id 90A3DC55C for ; Fri, 29 Jan 2016 08:16:32 +0100 (CET) Received: by mail-pf0-f175.google.com with SMTP id n128so37344233pfn.3 for ; Thu, 28 Jan 2016 23:16:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mvista-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=j0AhVInRPhAm0gemS5NuXMzTs2XSbQx5L0kg3RQWG/c=; b=vxevFjvRW//E4r58lPhQsDtZEbRThZX0/cr8apghIELMTPp1/+szUR1U/m2A0iWOIU OrreO4X7X098Ha8sKicXsdEDLpupuqDlSXdq26le+xZ+nOVcrmwHGd3A0FFNja4QJV/A pObvZnb4tUA3ufoN3S08EiY0p4pGoO2+gK1RZrXlRjs6Vs3LD9W1WVMx9OITHJbLW5W3 K2LQlRXr2IAiK6siuhPosG2BIWy4d8BlAqtgVK+Zynhg8gdgeWC+33by3hUZmIfE1UX0 GwNaM6464HJqS7WCuCzII349P8le4r8ET94DD2D+oCiacP/5YQN+CNuG9zjy5nftlZpZ mNLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=j0AhVInRPhAm0gemS5NuXMzTs2XSbQx5L0kg3RQWG/c=; b=Sh9gTXccJdP1VbSyNjTc/EgUxGr9rMMTHeOqR3wZMXForScACYAietlZ6HUoY0JKuj qnWY0iPi0TSlQcaTLlpxLrgotmJm59WTmKkH2cGaGOa2vX1h8y0yUSgy8WSqy+6GdsNm db3ezLbSWowUSEGNqNT0WQQkRzwPvREEt1hlQoT9Pa2IcvAKerl07Wmzj3sCMA3/o0PG QZjklMXJm4bANPhVtpJTpLKRD5HX5quGWDe2b4HTgdDbM7UWMFtqWgLbNeNMwgw368Zk Ji5ysZF4jdil7cVYCOoi8R4uv/tjFRgVX8zBllwV4FTrj4IM3iAey7gsR6TssVkgcpR5 wrwg== X-Gm-Message-State: AG10YOT0NhAYGu+KH1XL9ajYd9BhdJatt8LYxZ/ApPvw0jKZTr/uuoUoTb0biu0AAd0TR04UtxHl561K0ZWoP/vP MIME-Version: 1.0 X-Received: by 10.98.14.69 with SMTP id w66mr11320737pfi.144.1454051792020; Thu, 28 Jan 2016 23:16:32 -0800 (PST) Received: by 10.66.196.81 with HTTP; Thu, 28 Jan 2016 23:16:31 -0800 (PST) In-Reply-To: <20160129070746.GP4257@yliu-dev.sh.intel.com> References: <1453203972-24855-1-git-send-email-sshukla@mvista.com> <1453203972-24855-7-git-send-email-sshukla@mvista.com> <20160129070746.GP4257@yliu-dev.sh.intel.com> Date: Fri, 29 Jan 2016 12:46:31 +0530 Message-ID: From: Santosh Shukla To: Yuanhan Liu Content-Type: text/plain; charset=UTF-8 Cc: dev@dpdk.org, Rakesh Krishnamurthy , Rizwan Ansari Subject: Re: [dpdk-dev] [PATCH v5 06/11] virtio: vfio: add api support to rd/wr ioport bar X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jan 2016 07:16:33 -0000 On Fri, Jan 29, 2016 at 12:37 PM, Yuanhan Liu wrote: > On Tue, Jan 19, 2016 at 05:16:07PM +0530, Santosh Shukla wrote: >> For vfio case - Use pread/pwrite api to access virtio >> ioport space. >> >> Applicable for virtio 0.95 spec. >> >> Signed-off-by: Santosh Shukla >> Signed-off-by: Rizwan Ansari >> Signed-off-by: Rakesh Krishnamurthy >> --- >> v4 --> v5: >> - Removed unnecessary type casting. >> >> drivers/net/virtio/virtio_vfio_rw.h | 104 +++++++++++++++++++++++++++++++++++ >> 1 file changed, 104 insertions(+) >> create mode 100644 drivers/net/virtio/virtio_vfio_rw.h >> >> diff --git a/drivers/net/virtio/virtio_vfio_rw.h b/drivers/net/virtio/virtio_vfio_rw.h >> new file mode 100644 >> index 0000000..a9ab04d >> --- /dev/null >> +++ b/drivers/net/virtio/virtio_vfio_rw.h > > Maybe virtio_vfio.h is enough, or if you have to put a sufix there, _io > (instead of _rw) is a better option to me. > Ok. >> + >> +/* vfio rd/rw virtio apis */ >> +static inline void >> +ioport_inb(const struct rte_pci_device *pci_dev, uint8_t reg, uint8_t *val) > > vfio_inb is a better name; ioport_inb is too generic. > Ok. > --yliu