From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f182.google.com (mail-pf0-f182.google.com [209.85.192.182]) by dpdk.org (Postfix) with ESMTP id 09E97ADA2 for ; Wed, 27 Jan 2016 18:18:50 +0100 (CET) Received: by mail-pf0-f182.google.com with SMTP id n128so7794193pfn.3 for ; Wed, 27 Jan 2016 09:18:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mvista-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=saQ3O059j4WtRY4poeJw57BOxv4fE7itY1K4gdww40M=; b=qAghdowf6zIlevggk/OlrQdwTSpFwpuLC2o6EQGYYmDPJaI63VXn7TSeNFI/LBhexc gS4Syljqcym6z7XkAmaE37fGnSQpYw9hH5IztPSAbCRBBUESsZfEopkurJAx1wiwnI/J QBT0LuL8lzlYjvqjPMJBqKLYSPBVMpi7FzM6bNcP24spcmHI/Uc5L0fqet6wHfHh6K9r Fx6oLIMQZud+UZ4FnjAeyL+VYPul1tW3jF5Il28vC1JyHEGEUHIdBZZQ3CG6PcgYm1+c yFY+rG7R7A1i2daMX/IueSQr505S5xEDzYfGwWIiAHkGNLot2K7IKfzBft1NYvPSNjSU I9zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=saQ3O059j4WtRY4poeJw57BOxv4fE7itY1K4gdww40M=; b=fSNZ4FxvdlEbj4gm60fuz22+gHurFL5Etja+HKn+98yE1qm2bDDxYoTkJgYRGNohRN XnL0tsLZ0FW8MqUthCtB654csdmCk/AA18ibb56lC89dm3HBsfch4HOJLjsIyqlUPwQE xQDWX+hVYyS6/s2UbxXvT5WEfZdLunHqVmhA/06oUTFWa/nso8PSz5KfxJY+jaxarjfN MZRidCaaYb704b+R4t4FlI8H1jgGeAon5mXDMZ6nMw5HsLKqvrSX/SufhBRUkq61K9gx RX85cAq823cGao/+OYJOybNX3L2jlalTIECyPPaucYgeR4chgj5laruK+1Ptcjh+KRbf on9g== X-Gm-Message-State: AG10YOTLfbpBWzmR1XjMYeXqFnMEBOZ3bclGaI5CNlmmn8KnjF6mVW4GF12QsUu76CSma2gJM5ZjbNWtn5moZV2p MIME-Version: 1.0 X-Received: by 10.98.14.69 with SMTP id w66mr44123859pfi.144.1453915129310; Wed, 27 Jan 2016 09:18:49 -0800 (PST) Received: by 10.66.196.81 with HTTP; Wed, 27 Jan 2016 09:18:49 -0800 (PST) In-Reply-To: References: <1453229842-15310-1-git-send-email-sshukla@mvista.com> <25509182.RtDY3IvNbk@xps13> Date: Wed, 27 Jan 2016 22:48:49 +0530 Message-ID: From: Santosh Shukla To: Thomas Monjalon Content-Type: text/plain; charset=UTF-8 Cc: "Michael S. Tsirkin" , dev@dpdk.org, Alex Williamson Subject: Re: [dpdk-dev] [PATCH v6 08/11] eal: pci: introduce RTE_KDRV_VFIO_NOIOMMUi driver mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jan 2016 17:18:50 -0000 On Wed, Jan 27, 2016 at 9:26 PM, Santosh Shukla wrote: > On Wed, Jan 27, 2016 at 9:09 PM, Thomas Monjalon > wrote: >> 2016-01-27 21:02, Santosh Shukla: >>> 1. virtio currently works for vfio+noiommu and likely will work for >>> vfio+iommu in near future. >>> 2. So remove __noiommu suffix and always use default. >>> 3. Introduce vfio resource parsing global function, That function >>> suppose to do parsing for default vfio case and for vfio-noiommu case. >>> This function will be used by pmd drivers for resource parsing purpose >>> example virtio. >>> >>> Yuan won't be happy with 3) I guess, because he wanted to get rid of >>> interface parsing from pmd driver. >>> >>> Thomas, if 1/2/3/ addresses your concern then I'll spin the series, >> >> I agree with 1/ and 2/. >> Please, could you explain why 3/ is needed? > > Because someone should do resource parsing / validation before driver > does resource mapping/initialization. That someone could be either EAL > layer or driver itself. > > In my case; > - driver is virtio > - resource is vfio interface FWIW, removed 3) / Removed this patch entirely from this series, Sending v6 version for effected patch [09/11]..