From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f172.google.com (mail-pf0-f172.google.com [209.85.192.172]) by dpdk.org (Postfix) with ESMTP id D9E1C5A86 for ; Thu, 17 Dec 2015 13:02:38 +0100 (CET) Received: by mail-pf0-f172.google.com with SMTP id v86so29995916pfa.2 for ; Thu, 17 Dec 2015 04:02:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mvista-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=0stqKxhTyDNCcCPiT4uyQw6x6ppZrP4O4DXPA4i96oM=; b=njygM2hiZ8LnuGKEdFA+huWMrGdNIHfd0Y066623CFnauIhEK+IZbGaFsmR8fgu3JE l0m//cQx7Ina3HJ9ldeOW0D/0vjrObCKjAxgKrFBqXLGhJWXpl0FrQ4t/NVYTJzykne0 k73lDV9espNuH3yqHj61RbtPmYsxtla4L/7I5KWKueqLMsVAGEo/gmifkpKwpvOrzCdS AbeIUzTmoAMguyjsXZvmKBk1T+LnkLaxCMSbjenUX6f4uihvlgqwNVGlSTnSuIiRb+z3 GTw9TLW49a43TY/vhUrvCw2rSe5/J7/DRup9gAoTu8HWMlNMLuxHDSv2kXfKD4ZlKb6D HU2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=0stqKxhTyDNCcCPiT4uyQw6x6ppZrP4O4DXPA4i96oM=; b=gybBb0/Jw37DAEmeBvCfsc/UiniF26Cst0xoUBwD5v26Wmp3DIT2Ij0yYlIlfNSJlS 8qNs7ZP+kpMcWDBk+QukZxS1Y9s53PbocBn2zY4MqG8tzh6x/O0yu8LlrpsBYxwU3nW6 Lgy6ZTbGLBnN95ZFl6/oUUJM3EAbYOhppem3Dzn3ph4F4bBBuq8zGnReZPDWvqE1U7n1 LWZfuP5JizdNvtsLG2I8ltDJlTrDrpwW+q6kYBJgYuRUT+q5U0Z8KWz+1qCJYxwarmfh oUrgbS9MtD263EEGctOe1U3xxob5cuOGNciGH80OPiXfG1Bjp+PxfjfFCnFvFTgPPYPk EXXw== X-Gm-Message-State: ALoCoQnMnUeTMtPfAjAT85sMGIFb1VQCC7GxSh8K7Nn8tZViRMc1HenfG+vCycJj8GJ6sgRI6LFI4UfWK197qrRnU64SH6jHFMWvHabmNcDh+bAJSMAaFm8= MIME-Version: 1.0 X-Received: by 10.98.71.193 with SMTP id p62mr13373772pfi.142.1450353758234; Thu, 17 Dec 2015 04:02:38 -0800 (PST) Received: by 10.66.13.233 with HTTP; Thu, 17 Dec 2015 04:02:38 -0800 (PST) In-Reply-To: <1450098032-21198-2-git-send-email-sshukla@mvista.com> References: <1450098032-21198-1-git-send-email-sshukla@mvista.com> <1450098032-21198-2-git-send-email-sshukla@mvista.com> Date: Thu, 17 Dec 2015 17:32:38 +0530 Message-ID: From: Santosh Shukla To: dev@dpdk.org Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [ [PATCH v2] 01/13] virtio: Introduce config RTE_VIRTIO_INC_VECTOR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Dec 2015 12:02:39 -0000 On Mon, Dec 14, 2015 at 6:30 PM, Santosh Shukla wrote: > virtio_recv_pkts_vec and other virtio vector friend apis are written for sse/avx > instructions. For arm64 in particular, virtio vector implementation does not > exist(todo). > > So virtio pmd driver wont build for targets like i686, arm64. By making > RTE_VIRTIO_INC_VECTOR=n, Driver can build for non-sse/avx targets and will work > in non-vectored virtio mode. > > Signed-off-by: Santosh Shukla > --- Ping? any review / comment on this patch much appreciated. Thanks > config/common_linuxapp | 1 + > drivers/net/virtio/Makefile | 2 +- > drivers/net/virtio/virtio_rxtx.c | 7 +++++++ > 3 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/config/common_linuxapp b/config/common_linuxapp > index ba9e55d..275fb40 100644 > --- a/config/common_linuxapp > +++ b/config/common_linuxapp > @@ -273,6 +273,7 @@ CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_RX=n > CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_TX=n > CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DRIVER=n > CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DUMP=n > +CONFIG_RTE_VIRTIO_INC_VECTOR=y > > # > # Compile burst-oriented VMXNET3 PMD driver > diff --git a/drivers/net/virtio/Makefile b/drivers/net/virtio/Makefile > index 43835ba..25a842d 100644 > --- a/drivers/net/virtio/Makefile > +++ b/drivers/net/virtio/Makefile > @@ -50,7 +50,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_VIRTIO_PMD) += virtqueue.c > SRCS-$(CONFIG_RTE_LIBRTE_VIRTIO_PMD) += virtio_pci.c > SRCS-$(CONFIG_RTE_LIBRTE_VIRTIO_PMD) += virtio_rxtx.c > SRCS-$(CONFIG_RTE_LIBRTE_VIRTIO_PMD) += virtio_ethdev.c > -SRCS-$(CONFIG_RTE_LIBRTE_VIRTIO_PMD) += virtio_rxtx_simple.c > +SRCS-$(CONFIG_RTE_VIRTIO_INC_VECTOR) += virtio_rxtx_simple.c > > # this lib depends upon: > DEPDIRS-$(CONFIG_RTE_LIBRTE_VIRTIO_PMD) += lib/librte_eal lib/librte_ether > diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c > index 74b39ef..23be1ff 100644 > --- a/drivers/net/virtio/virtio_rxtx.c > +++ b/drivers/net/virtio/virtio_rxtx.c > @@ -438,7 +438,9 @@ virtio_dev_rx_queue_setup(struct rte_eth_dev *dev, > > dev->data->rx_queues[queue_idx] = vq; > > +#ifdef RTE_VIRTIO_INC_VECTOR > virtio_rxq_vec_setup(vq); > +#endif > > return 0; > } > @@ -464,7 +466,10 @@ virtio_dev_tx_queue_setup(struct rte_eth_dev *dev, > const struct rte_eth_txconf *tx_conf) > { > uint8_t vtpci_queue_idx = 2 * queue_idx + VTNET_SQ_TQ_QUEUE_IDX; > + > +#ifdef RTE_VIRTIO_INC_VECTOR > struct virtio_hw *hw = dev->data->dev_private; > +#endif > struct virtqueue *vq; > uint16_t tx_free_thresh; > int ret; > @@ -477,6 +482,7 @@ virtio_dev_tx_queue_setup(struct rte_eth_dev *dev, > return -EINVAL; > } > > +#ifdef RTE_VIRTIO_INC_VECTOR > /* Use simple rx/tx func if single segment and no offloads */ > if ((tx_conf->txq_flags & VIRTIO_SIMPLE_FLAGS) == VIRTIO_SIMPLE_FLAGS && > !vtpci_with_feature(hw, VIRTIO_NET_F_MRG_RXBUF)) { > @@ -485,6 +491,7 @@ virtio_dev_tx_queue_setup(struct rte_eth_dev *dev, > dev->rx_pkt_burst = virtio_recv_pkts_vec; > use_simple_rxtx = 1; > } > +#endif > > ret = virtio_dev_queue_setup(dev, VTNET_TQ, queue_idx, vtpci_queue_idx, > nb_desc, socket_id, &vq); > -- > 1.7.9.5 >