From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f47.google.com (mail-pa0-f47.google.com [209.85.220.47]) by dpdk.org (Postfix) with ESMTP id C3F968E96 for ; Mon, 14 Dec 2015 16:24:08 +0100 (CET) Received: by pacdm15 with SMTP id dm15so105093166pac.3 for ; Mon, 14 Dec 2015 07:24:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mvista-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=HX1aTzD434+BTP+nhTUCDuPRizMkXFjDB/qepEotc+o=; b=a8gym28awbWh9dAGoUj4+AKPVmigoCx1uQD1ziWyd9sZdjRpmu9Z7J6wLRk9uFzKLV 4F1L9hf6pgoni1DC4mj4V9fvH6f6RwKGlLqty/mbleeLOWdnFSEPy5hOHQ7A1pXZU5bZ uzsz3qC3garm9/ooXVMu8FmP6J7x8BM4xV/WFk9bxDQE1y83jUndn9dqwv+W0UKiIiHK jq/1Pm58Lbakkhqpw3eVw3HJ9BAR37mLss9F90TKtyNHjcmUHTrSgcpkfME0rlPsyURN x6d5OuYMHEL/LTGZ+nJZWdyv5mZ8TE8itimEbSS0q5HM47wG+ML2ZBJ5HOwDG/Ohz2Yj Jjtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=HX1aTzD434+BTP+nhTUCDuPRizMkXFjDB/qepEotc+o=; b=Pfk904Z2q6HSuFSxlJ+jt/9v2dIzhbbtXS8dTlFLgpaU8y/3OPYb/czxiyakQt3Q9C nuidRQFVOVSGcg5ztVhfE8ELSqzm0Xt7nlYgktg2y6le0iKoeCw8PHWPyUR8N1T798Z5 9MM7cfjbrp30Y4r0PKq7hCe4cxo/LFkiRj5K+BH3lEHYYqQBztmVeYNrwNX7oLGltny5 Jg+R8LY4N7vwrZTUvCfr5Va+xsefZENl8B8sbnKXU044Toqr4vKoA4PSOTIUSX+U7tK1 s7PuO3YNPNx9JYrK3a9dBt4hHOj0jdUvcZh8pHDi8OpDMYfyolbpi2fxvm7TGQGO5hoA p1vA== X-Gm-Message-State: ALoCoQkNJFOL7hUR9wKhiDEBEAdPZIw0LPY4NDnLjNgqBNDRXaF9jlDYBjT6Gi4vJdh0M5wjYItmB4V/InRmNxig1hkwbQN8PLmWXRgwwMOqwUHxesFA1b0= MIME-Version: 1.0 X-Received: by 10.66.193.73 with SMTP id hm9mr46721620pac.117.1450106648162; Mon, 14 Dec 2015 07:24:08 -0800 (PST) Received: by 10.66.13.233 with HTTP; Mon, 14 Dec 2015 07:24:08 -0800 (PST) In-Reply-To: <20151214143717.GD30309@localhost.localdomain> References: <1450098032-21198-1-git-send-email-sshukla@mvista.com> <1450098032-21198-8-git-send-email-sshukla@mvista.com> <20151214143717.GD30309@localhost.localdomain> Date: Mon, 14 Dec 2015 20:54:08 +0530 Message-ID: From: Santosh Shukla To: Jerin Jacob Content-Type: text/plain; charset=UTF-8 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [ [PATCH v2] 07/13] linuxapp: eal: arm: Always return 0 for rte_eal_iopl_init() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Dec 2015 15:24:09 -0000 On Mon, Dec 14, 2015 at 8:07 PM, Jerin Jacob wrote: > On Mon, Dec 14, 2015 at 06:30:26PM +0530, Santosh Shukla wrote: >> iopl() syscall not supported in linux-arm/arm64 so always return 0 value. >> >> Signed-off-by: Santosh Shukla >> --- >> lib/librte_eal/linuxapp/eal/eal.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c >> index 635ec36..2617037 100644 >> --- a/lib/librte_eal/linuxapp/eal/eal.c >> +++ b/lib/librte_eal/linuxapp/eal/eal.c >> @@ -716,6 +716,9 @@ rte_eal_iopl_init(void) >> return -1; >> return 0; >> #else >> +#if defined(RTE_ARCH_ARM) || defined(RTE_ARCH_ARM64) >> + return 0; /* iopl syscall not supported for ARM/ARM64 */ > > I guess for other architectures also iopl not supported.I think better > to move this function to eal. Else this function will return 'true' for > ppc64 > didn't understood. This func is in eal right? and for ppc64, function will return -1 (false). Although i could include ppc64 / tile or invert the logic such a way that non-x86 arch to return default true value. However iopl() used for virtio and only two arch using x86/ now arm. I am not sure ppc64/tile or other arch has any plan to use virtio pmd thus care for iopl(). > or have at least postive logic, > #if defined(RTE_ARCH_X86_64) || defined(RTE_ARCH_I686) || > defined(RTE_ARCH_X86_X32) > > >> +#endif >> return -1; >> #endif >> } >> -- >> 1.7.9.5 >>