From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f47.google.com (mail-pa0-f47.google.com [209.85.220.47]) by dpdk.org (Postfix) with ESMTP id 4C4965A71 for ; Wed, 16 Dec 2015 15:40:57 +0100 (CET) Received: by mail-pa0-f47.google.com with SMTP id q3so4658788pav.3 for ; Wed, 16 Dec 2015 06:40:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mvista-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=opi9VO6/ZguI8r3ASYqvRLUC+3ETLNJsud0j0+x9dAk=; b=X438gG3/Ua5cFiASV1zUTbUeWPxhkZM70LenP7wyGUoyfJ6aarF6W1nTZoA+0SkJLL T0rZv646x4XPOC1ecZ1XdrRh5IRy/a/WzLipue/VmDR44edc6/H9OvuV/qbfebAg2yZl G+ZUki6dBwijrH/CGHYmIF42ySKylPtm30JwkhQTfmuPBODyh0n0t1CqeZ8Ehl6mKDn+ jQfasZ2rff/HFWn+2ovuln1t0/wxnDFAAlT7eIGK9ngj4ZwdldCCosarrHhlJdLzTXYJ t1vdOHkNPGpun/KhjW4HI+B9u+vMSw3rdfZoEVQUoyMTTCkGBRr78Nin4DFUlUEbdWKo kQyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=opi9VO6/ZguI8r3ASYqvRLUC+3ETLNJsud0j0+x9dAk=; b=EvTya2fqMUCqp/AN48e9J5aIShA8A7+jdlvSyMxd2mywqJ5jSkekycYyTC2+3u6uDo UYkb/LSROhynXZRnFERkBQY/W3CKsBaGUHCi6ORmZFX2GmqREwg1i52Oqv0bhYptHnlv 0VDtTTaWpHwt2Av6hjn+ehA2nXVb86aRRTYgwgJasg4rLfV+dzHr+NrNfRumkhwu8kYP 2o6ck4FSKUO9DOIn53aONRUWX3FBWAolyrXdeJy2/hmJpa0LDGahiFP9R53N/ifKEAbv rjtlRWWuVlOCzAZJ19TIw/dwAWC8BHAQzt9j0msuu3if6Z84uUwx6vWV9c04e9y0FD9o Qtag== X-Gm-Message-State: ALoCoQnYT4sk0UhYv7tiJLG7b1iu9sqe10wRgoiSJ1eFgsF3GVwucExMVT3j1Yd3VSUVnK9tKVX5RkCAwM/umtSHY5zHn80SSZTN1Ec4yhazrswTU14dZm4= MIME-Version: 1.0 X-Received: by 10.66.240.97 with SMTP id vz1mr63520765pac.29.1450276856681; Wed, 16 Dec 2015 06:40:56 -0800 (PST) Received: by 10.66.13.233 with HTTP; Wed, 16 Dec 2015 06:40:56 -0800 (PST) In-Reply-To: <20151216143716.GW29571@yliu-dev.sh.intel.com> References: <1450098032-21198-1-git-send-email-sshukla@mvista.com> <1450098032-21198-12-git-send-email-sshukla@mvista.com> <20151216132940.GT29571@yliu-dev.sh.intel.com> <20151216143716.GW29571@yliu-dev.sh.intel.com> Date: Wed, 16 Dec 2015 20:10:56 +0530 Message-ID: From: Santosh Shukla To: Yuanhan Liu Content-Type: text/plain; charset=UTF-8 Cc: dev@dpdk.org, Rakesh Krishnamurthy , Rizwan Ansari Subject: Re: [dpdk-dev] [ [PATCH v2] 11/13] virtio_ioport: armv7/v8: mmap virtio iopci bar region X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Dec 2015 14:40:57 -0000 On Wed, Dec 16, 2015 at 8:07 PM, Yuanhan Liu wrote: > On Wed, Dec 16, 2015 at 07:50:51PM +0530, Santosh Shukla wrote: > ... >> >> + *resource_addr = (void *)((char *)ioport_map + (ioport_map_cnt)*offset); >> > >> > Redundant (), and the void * cast seems to be unnecessary. >> > >> >> (void *) is unnecessary, but couldn't get the redundant() part? > > I meant the () of "(ioport_map_cnt)*offset". > ok. >> >> >> + ioport_map_cnt++; >> >> + >> >> + PMD_INIT_LOG(DEBUG, "pci.resource_addr %p ioport_map_cnt %d\n", >> >> + *resource_addr, ioport_map_cnt); >> >> + return ret; >> >> +} >> >> + >> > >> Is it redundant comment or your suggesting to use : r / (void) / __rte_unused? > > You should always use __rte_unused instead of (void) cast. Note that you > may need check your other patches, to make sure you not miss other such > usage. > yup, noted down. Thanks > --yliu