From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11BB0458F9; Tue, 3 Sep 2024 20:02:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 963F840279; Tue, 3 Sep 2024 20:02:33 +0200 (CEST) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id 3EABC4026A for ; Tue, 3 Sep 2024 20:02:32 +0200 (CEST) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2054e22ce3fso24399965ad.2 for ; Tue, 03 Sep 2024 11:02:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1725386551; x=1725991351; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=1Q/9VF9m0qeCMuSokllMDUEUh8nrRkb6h/gjBy84E/4=; b=A8v0nPPU9lEt8BO0DJwZz6wFKXjVrV3LxGPDtFfGKPGaO3jwOA0grqRL/zWkc+h6+G zfQpVHMSAP4Vflkml+LWTqwkVvbsatX6tMgQAoblXOUS1Xr7cGRRAXOH6oo9MmYkz+1+ tTvbWVtolaWMOYfpwWuIJ0GapqRHqqFQhPafI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725386551; x=1725991351; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1Q/9VF9m0qeCMuSokllMDUEUh8nrRkb6h/gjBy84E/4=; b=ce47h8/2sPOAAw/RnJBJjIGpYrfD2Rjjfoh3ydox2kot55SZMyatQrPqJYdKp5QZrj HN6L9nVNqzFTKii9Nx2QQ9iNZSNiidUubvCrPuqyHC+RHz2awdC8v7Jm2kiB00R0/64c DaFy0PnS6XC3oVY4r+7OhtHkalIOLmZWDEajzDpxUKymOpKAIpVbz8dJP62YUxnuDPeR WMouoceNpbhoFYQY6mULp0rHG6lbjd7i8KHWki90GExIJ3Dk1fBvQ/kDC08JkCNGb2il lKsRrTWJF4JBzUJkGWqML8xJzvIKf95kQryon8FxJf95o6BocRv5AFewOxv06y1LP5MJ TIAA== X-Forwarded-Encrypted: i=1; AJvYcCW/eA7TjSt3GoVYQl2BVYZv2rO148kZSy9r9mt036MwG9F5n6fnRJJ4DVaTR/Albu01XTQ=@dpdk.org X-Gm-Message-State: AOJu0Yz89LuwmMvWFk3f2bguYEZXPMgs0ivqNGof7TUyfeRrHg6OGFVs 5+aWdW+IZD/+Qwlw0kLwGnepKJyKEOUDgqMT5GSqFZy7OfAK8LXT7zh0jg/wqczEi99Qu+8xrQA 6OR6wzLa+tl7QzYU47ZADNWV3pbWiOIr0WODpNA== X-Google-Smtp-Source: AGHT+IG9Gy8/4qAksYKRWPTsaHd4/DFTuI3qhtU90EXO2G0TLA2ig+0HxoQuVdhBDqzu4UawzrOCKvlSwUKPTX3EssQ= X-Received: by 2002:a17:902:d4cd:b0:205:3e6d:9949 with SMTP id d9443c01a7336-20699b36168mr35373975ad.52.1725386550905; Tue, 03 Sep 2024 11:02:30 -0700 (PDT) MIME-Version: 1.0 References: <20240301155416.96960-1-juraj.linkes@pantheon.tech> <20240821145315.97974-1-juraj.linkes@pantheon.tech> <20240821145315.97974-13-juraj.linkes@pantheon.tech> In-Reply-To: <20240821145315.97974-13-juraj.linkes@pantheon.tech> From: Dean Marx Date: Tue, 3 Sep 2024 14:02:41 -0400 Message-ID: Subject: Re: [PATCH v3 12/12] dts: add NIC capabilities from show port info To: =?UTF-8?Q?Juraj_Linke=C5=A1?= Cc: thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, jspewock@iol.unh.edu, probb@iol.unh.edu, paul.szczepanek@arm.com, Luca.Vizzarro@arm.com, npratte@iol.unh.edu, alex.chapman@arm.com, dev@dpdk.org Content-Type: multipart/alternative; boundary="00000000000077a62406213adc63" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --00000000000077a62406213adc63 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Aug 21, 2024 at 10:53=E2=80=AFAM Juraj Linke=C5=A1 wrote: > Add the capabilities advertised by the testpmd command "show port info" > so that test cases may be marked as requiring those capabilities: > RUNTIME_RX_QUEUE_SETUP > RUNTIME_TX_QUEUE_SETUP > RXQ_SHARE > FLOW_RULE_KEEP > FLOW_SHARED_OBJECT_KEEP > > These names are copy pasted from the existing DeviceCapabilitiesFlag > class. Dynamic addition of Enum members runs into problems with typing > (mypy doesn't know about the members) and documentation generation > (Sphinx doesn't know about the members). > > Signed-off-by: Juraj Linke=C5=A1 > Reviewed-by: Dean Marx --00000000000077a62406213adc63 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Aug 21, 2024 at 10:53=E2=80=AFAM = Juraj Linke=C5=A1 <juraj.linkes@pantheon.tech> wrote:
Add = the capabilities advertised by the testpmd command "show port info&quo= t;
so that test cases may be marked as requiring those capabilities:
RUNTIME_RX_QUEUE_SETUP
RUNTIME_TX_QUEUE_SETUP
RXQ_SHARE
FLOW_RULE_KEEP
FLOW_SHARED_OBJECT_KEEP

These names are copy pasted from the existing DeviceCapabilitiesFlag
class. Dynamic addition of Enum members runs into problems with typing
(mypy doesn't know about the members) and documentation generation
(Sphinx doesn't know about the members).

Signed-off-by: Juraj Linke=C5=A1 <juraj.linkes@pantheon.tech>

Reviewed-by: Dean Marx <dmarx@iol.unh.edu>=C2=A0
--00000000000077a62406213adc63--