From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F06D645BFF; Mon, 28 Oct 2024 19:56:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DAC71427AC; Mon, 28 Oct 2024 19:56:23 +0100 (CET) Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) by mails.dpdk.org (Postfix) with ESMTP id 2078B427A1 for ; Mon, 28 Oct 2024 19:56:22 +0100 (CET) Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-6e3a97a6010so51820947b3.1 for ; Mon, 28 Oct 2024 11:56:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1730141781; x=1730746581; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=pLvj8S2LdoRj9f77gJNz3wDigzCh23eznuQmJjh7DBA=; b=Mv0cM3ihBZAw3nA42Uu99sDAZzKoxPlA705FWeDxZISciycY06ftFqyA+8aCmMFYfV cPZYoy1w86hiv8U2zdknUqFgD+uuv6faMPD9ux+wje5iHsvzQaNjGUairDs/K0Id4dKG 7tQinzA5L4zL3lBNDhGPWGiax5GOzo7hUOGYE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730141781; x=1730746581; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pLvj8S2LdoRj9f77gJNz3wDigzCh23eznuQmJjh7DBA=; b=l8nxmj8vmDcbHVcH8SLaRxHNbW1LxwwTmZfTIdtaeG6k8uOQF1zCJ8zg2TIts2sPPg 5N/Br1r1hDPeP+mZrrIAt49+3TkG1uzV5Nypynf/SDex2qs95PPr3ZWLgMruZNv2Y5HK OvRb1Q3B64/ybrZpycIdTCLjzuZ+Bx6Y0N4VtB31WkOzMjb5WJaOEbMY5NIHjkoKUfgr CjTtdmBihJbdxbz5LNSfkx4wsDAbBQLTTeCmS5R6E70ZaMcDsWjTYxgF8osF1Yq26rFU rdTIUm/3kT6aHmhZ7IAUM8Kttw8byYfeFND2IdJvHYVRYQqfH3htCFbvitoOZ7nz5g9Z EaLg== X-Gm-Message-State: AOJu0YxW/OwvUd+X/69pjniqCrpkY+eM+xFFuh/omoFATIeSDRUo2/UL +BhoiJ7+OjHPElC7Qjz49NIChvc+GFbBw8oF3/g4Nml7V0DS/P3H9bDjQbXd/6noaJkEx2mPeJn WfNour+Ubn0xliEgA3Epo/pBMMsqkgvzGVNOTwE6iHQAB7vUD X-Google-Smtp-Source: AGHT+IFCilJ9qANWXawQgC2nwvd+Fjw3Ue+RxN2APEERJoE9zLIoikc5aPniaZFWqYhvk6KRJCyMVVw7NRd5mXiRT/M= X-Received: by 2002:a05:690c:3690:b0:6e3:e1f:2434 with SMTP id 00721157ae682-6e9d8939dd3mr102221647b3.12.1730141779918; Mon, 28 Oct 2024 11:56:19 -0700 (PDT) MIME-Version: 1.0 References: <20241023145732.286071-1-paul.szczepanek@arm.com> <20241025103520.394951-1-paul.szczepanek@arm.com> In-Reply-To: <20241025103520.394951-1-paul.szczepanek@arm.com> From: Dean Marx Date: Mon, 28 Oct 2024 14:56:34 -0400 Message-ID: Subject: Re: [PATCH v2] dts: fix doxygen API link and DTS docs placement To: Paul Szczepanek Cc: dev@dpdk.org, probb@iol.unh.edu Content-Type: multipart/alternative; boundary="00000000000034211306258e061a" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --00000000000034211306258e061a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Oct 25, 2024 at 6:35=E2=80=AFAM Paul Szczepanek wrote: > Alias used to produce the link to the DTS API docs uses config data. > The required value in config data was being added in the wrong scope. > This moves the key addition to where the config data object is created. > > DTS docs need to be placed in the same dir as main API docs. > Made DTS docs dependent on main docs and stopped separate install step > relying instead on the parent docs to install them. > This means they can no longer be build without main docs. > > Added a line to sphinx python wrapper to create the destination path > if not already present. > > Fixes: 7f9326423a04 ("dts: add API doc generation") > > Signed-off-by: Paul Szczepanek > Acked-by: Patrick Robb > Reviewed-by: Dean Marx --00000000000034211306258e061a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, Oct 25, 2024 at 6:35=E2=80=AFAM P= aul Szczepanek <paul.szczepan= ek@arm.com> wrote:
Alias used to produce the link to the = DTS API docs uses config data.
The required value in config data was being added in the wrong scope.
This moves the key addition to where the config data object is created.

DTS docs need to be placed in the same dir as main API docs.
Made DTS docs dependent on main docs and stopped separate install step
relying instead on the parent docs to install them.
This means they can no longer be build without main docs.

Added a line to sphinx python wrapper to create the destination path
if not already present.

Fixes: 7f9326423a04 ("dts: add API doc generation")

Signed-off-by: Paul Szczepanek <paul.szczepanek@arm.com>
Acked-by: Patrick Robb <probb@iol.unh.edu>

Review= ed-by: Dean Marx <dmarx@iol.unh.edu= >=C2=A0
--00000000000034211306258e061a--