From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB36145D44; Tue, 19 Nov 2024 17:31:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DDE9E4029B; Tue, 19 Nov 2024 17:31:09 +0100 (CET) Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) by mails.dpdk.org (Postfix) with ESMTP id 959E74028A for ; Tue, 19 Nov 2024 17:31:08 +0100 (CET) Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-6eb0c2dda3cso12395747b3.1 for ; Tue, 19 Nov 2024 08:31:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1732033868; x=1732638668; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=7eDt/SQvC02Y9n8HwWTobAxg2rwgWJQiiAHBYR3Lmew=; b=EOitgG7kNiS/uf+WhC+Qt9xog/dSqu/GHEYtNeGjX4lW20MH8Y9yJ/MEPFYWC9pK9k LG3ZK+RO2n1GMe3qShdiGiHcrQQWdUJcjLvkLr0SZ4ARKVbq2SOaxmLodMav11k9Ie68 K/MOBi3rqFcaaynXNLpjvuQQZbuIRJlr+7CaY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732033868; x=1732638668; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7eDt/SQvC02Y9n8HwWTobAxg2rwgWJQiiAHBYR3Lmew=; b=emtzTYDiPHB67wQ9KYxzyMrQogFP9JX+yO5N3K2X+0p2vrQfNa0fNbUr0y3Zyw1AsS ESDnXtndEJGdIZamFVgjZ/1+nNlRnuFQzP4C6kVzf6LMl51U1OpZ+j/lUa0JuTUu5i3Q 8z+qrkD4lI76hXipRPBB5KuFawx2RokoxobkX93ZDnskvRERR3T2tIGFNDXO4ns1X/w4 ogtdxIkVtu9kG7ImYLw0WBdLnFPbv5uEZJShXqkYrH+61ANRM2HHMH3HTfIHTCslVURR QLKTq3NPd5jsjijFauL5Gbcbdsk0b59XHO6H7xsVgqZ1uQcz2X3fOuK3rf5JzfWypfdE poaw== X-Gm-Message-State: AOJu0YyPY8LWgaczk0kCn6j+b2qoCbWR6Yz9Oc44dAZF6AzbtQSRRpJj E9NI20ShoumgpPrS0l8i7SJZ0Gdi8umnJdNkBtGFzhizCKzwXjC6qDJlTbONzNZ5FgqKEMpmzPz Z1CfByEWNix9DtAwFGmBua+5IUIXVPuZ76k/8ng== X-Google-Smtp-Source: AGHT+IH2A2ruGGY2u+42HIhDSh1RXI5Kt4JGEmg4WiyumWY17ORrlDCaPwzZhrtSMWKdfqCVW/N9INHadmdh3iPgp8M= X-Received: by 2002:a05:690c:6e88:b0:6ea:87dc:49b1 with SMTP id 00721157ae682-6ee55bee4cfmr168746617b3.10.1732033868001; Tue, 19 Nov 2024 08:31:08 -0800 (PST) MIME-Version: 1.0 References: <20240906161355.701688-1-luca.vizzarro@arm.com> <20241108134532.130681-1-luca.vizzarro@arm.com> <20241108134532.130681-4-luca.vizzarro@arm.com> <48bf44a8-d483-4022-bebf-b90d50c7c5a3@arm.com> In-Reply-To: <48bf44a8-d483-4022-bebf-b90d50c7c5a3@arm.com> From: Dean Marx Date: Tue, 19 Nov 2024 11:31:19 -0500 Message-ID: Subject: Re: [PATCH v3 3/4] dts: add per-test-suite configuration To: Luca Vizzarro Cc: dev@dpdk.org, Paul Szczepanek , Patrick Robb Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > So... this is a weird one. I've integrated the code generation under > dts-check-format.sh, so nobody should really worry about it, as that > should be run before submitting. If it's not, then the CI will > eventually pick it up when dts-check-format will be in place. Right, and that definitely makes sense logically but I think maybe even just throwing in a comment in conf.yaml similar to the one you used below (timeout: 20 # optional field from HelloWorldConfig) would be beneficial, even if just to show where the customized fields should go. If you'd rather leave it as is though that's totally fine with me, this is kind of a nitpick suggestion anyways > The hello_world suite doesn't really need this, I've just added it as an > example. But yes test suites are affected. If you see the hello_world > suite, it calls `self.config.timeout` which is a reference to this > field. This class specifically is now wholly integrated in the > configuration: Okay that makes sense, thanks Luca!