DPDK patches and discussions
 help / color / mirror / Atom feed
From: Dean Marx <dmarx@iol.unh.edu>
To: Luca Vizzarro <luca.vizzarro@arm.com>
Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>,
	 Thomas Wilks <thomas.wilks@arm.com>,
	Paul Szczepanek <paul.szczepanek@arm.com>,
	Patrick Robb <probb@iol.unh.edu>
Subject: Re: [PATCH v2 3/3] dts: add packet capture test suite
Date: Tue, 3 Jun 2025 10:33:31 -0400	[thread overview]
Message-ID: <CABD7UXNmEBKiZuf=ddg6avfxeSSxh56Sbm6eK9Jho1rrLwYfpw@mail.gmail.com> (raw)
In-Reply-To: <20250506132933.1580584-4-luca.vizzarro@arm.com>

On Tue, May 6, 2025 at 9:31 AM Luca Vizzarro <luca.vizzarro@arm.com> wrote:
>
> From: Thomas Wilks <thomas.wilks@arm.com>
>
> Add a test suite that tests the packet capture framework
> through the use of dpdk-dumpcap.
>
> Signed-off-by: Thomas Wilks <thomas.wilks@arm.com>
> Signed-off-by: Luca Vizzarro <luca.vizzarro@arm.com>
> Reviewed-by: Paul Szczepanek <paul.szczepanek@arm.com>

<snip>
> +
> +    def close(self) -> None:
> +        """Close the application.
> +
> +        Sends a SIGINT to close the application.
> +        """
> +        self.send_command("\x03")
> +        super().close()

I believe code x03 is for SIGQUIT, not SIGINT:
https://www.chromium.org/chromium-os/developer-library/reference/linux-constants/signals/

Otherwise:
Reviewed-by: Dean Marx <dmarx@iol.unh.edu>

      reply	other threads:[~2025-06-03 14:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-31 15:57 [PATCH 0/2] " Thomas Wilks
2025-03-31 15:57 ` [PATCH 1/2] " Thomas Wilks
2025-04-10 17:04   ` Dean Marx
2025-04-10 22:46   ` Stephen Hemminger
2025-03-31 15:58 ` [PATCH 2/2] dts: import lldp package in scapy Thomas Wilks
2025-04-10 17:06   ` Dean Marx
2025-05-06 13:29 ` [PATCH v2 0/3] dts: add packet capture test suite Luca Vizzarro
2025-05-06 13:29   ` [PATCH v2 1/3] dts: import lldp package in scapy Luca Vizzarro
2025-05-06 13:29   ` [PATCH v2 2/3] dts: add facility to change file permissions Luca Vizzarro
2025-06-03 14:18     ` Dean Marx
2025-05-06 13:29   ` [PATCH v2 3/3] dts: add packet capture test suite Luca Vizzarro
2025-06-03 14:33     ` Dean Marx [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABD7UXNmEBKiZuf=ddg6avfxeSSxh56Sbm6eK9Jho1rrLwYfpw@mail.gmail.com' \
    --to=dmarx@iol.unh.edu \
    --cc=dev@dpdk.org \
    --cc=luca.vizzarro@arm.com \
    --cc=paul.szczepanek@arm.com \
    --cc=probb@iol.unh.edu \
    --cc=stephen@networkplumber.org \
    --cc=thomas.wilks@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).