From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 887DE45C9E;
	Wed,  6 Nov 2024 21:52:19 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 18E3742EA7;
	Wed,  6 Nov 2024 21:52:19 +0100 (CET)
Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com
 [209.85.219.180])
 by mails.dpdk.org (Postfix) with ESMTP id 7A76542E7E
 for <dev@dpdk.org>; Wed,  6 Nov 2024 21:52:17 +0100 (CET)
Received: by mail-yb1-f180.google.com with SMTP id
 3f1490d57ef6-e28fa2807eeso222573276.1
 for <dev@dpdk.org>; Wed, 06 Nov 2024 12:52:17 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=iol.unh.edu; s=unh-iol; t=1730926337; x=1731531137; darn=dpdk.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=iL/jRRKwTVBYyfHYGsuRD2bZtFUnGry8zPlDaW1sWPQ=;
 b=FDe3xjD+VRVpJCXCPwaByFTnmwi30X9Aey8BgDC7GGQYZC2F6Ge1q5bM4Umpitvqxn
 cB/P2/XKKzIFoez6BOG8IV+7nAwcyQgpY0VEzFvvH5S0aDY9uJt/5F7DJingaR4AJPXV
 i++32pRvcvZJcT0Y2q+ei5gmLXwrBhsSPA+iQ=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1730926337; x=1731531137;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=iL/jRRKwTVBYyfHYGsuRD2bZtFUnGry8zPlDaW1sWPQ=;
 b=HCAowTp90Kq4Y4PeGbwWZQsyXV/I/6pWR/lbu+StSuHAdlfqmr49lrgOwEQ5S9ymM5
 FVZC1psf5+A7tiim7/KquZPjWHH/RfMneT5aRAlUiiTeD9q9UctfIwQijih2Z4pAS4R0
 DTWF3FgKlmWNHTPkJ+X3X6sn8j5KUaiRI55nQZUS0cSocsnDr7k858dERJMV4U9Gbg/1
 2pNbmW4SVO18BpuTanwto3ganj/7xVVsfE2BQavEfyxrlyAynLWpBUPrfqUzOxP6tzD5
 wp8DajNwRzkU7qi1D6DmTc/KlwCgk+PVirxKpNPJH2tWkc55SS0rpSd4vkhcObYWiQTx
 iysw==
X-Forwarded-Encrypted: i=1;
 AJvYcCXKkgyrpellZMGhO3H7vO0O9Fdq0Qd3aFhkI0o5Q7PQRzRo+EAnFkY6xHFOxtlHzWmPXbw=@dpdk.org
X-Gm-Message-State: AOJu0YwBr6aB8UDRQiX7iezPreEmGwXgyrNW8JaZCVjlElDaMTj7cLfm
 ihZb++v8gW10dq1ckrSilvHG9JKlPrPYni9jex6RbAo4LNftElmS7A8vvE2EmVEvjSrrJZaK9nj
 nLBfi+ODwQ117pz44KQ870MC1NU7I4ByY5OwNVg==
X-Google-Smtp-Source: AGHT+IHhqy3dyiBtA00EtY174NWqcrJo/dQMUzVQkZ8jMAOaav/vfHFpJpVA37iY2//NJyu/kfAMqwomkU7SvtS0ZrQ=
X-Received: by 2002:a05:690c:4444:b0:6ea:34b1:62e3 with SMTP id
 00721157ae682-6ea523295bemr274713017b3.7.1730926336844; Wed, 06 Nov 2024
 12:52:16 -0800 (PST)
MIME-Version: 1.0
References: <20240613201831.9748-3-npratte@iol.unh.edu>
 <20240705171341.23894-12-npratte@iol.unh.edu>
In-Reply-To: <20240705171341.23894-12-npratte@iol.unh.edu>
From: Dean Marx <dmarx@iol.unh.edu>
Date: Wed, 6 Nov 2024 15:52:30 -0500
Message-ID: <CABD7UXNyhhTH1GWv=dTUxS7vL9DR2LanBs5R30jc3c4Z76DTfQ@mail.gmail.com>
Subject: Re: [PATCH v2 5/6] dts: add conditional behavior for test suite
To: Nicholas Pratte <npratte@iol.unh.edu>
Cc: probb@iol.unh.edu, jspewock@iol.unh.edu, luca.vizzarro@arm.com, 
 yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, 
 paul.szczepanek@arm.com, juraj.linkes@pantheon.tech, dev@dpdk.org
Content-Type: multipart/alternative; boundary="00000000000070bf6b062644b1b2"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

--00000000000070bf6b062644b1b2
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Jul 5, 2024 at 1:20=E2=80=AFPM Nicholas Pratte <npratte@iol.unh.edu=
> wrote:

> There is some odd functionality/behavior in how the --test-suite
> parameters interacts in conjunction with the 'test_suites' attribute in
> the config file. If a user leaves an empty list underneath
> 'test_suites,' or if they negate the attribute entirely, even if said
> user adds test suites via the --test-suite parameter, a schema violation
> is thrown.
>
> This patch mitigates this, by removing the schema requirement if the
> user has indicated test suites within main.py parameters, allowing for
> the 'test_suites' attribute to be optional.
>
> Bugzilla ID: 1360
> Signed-off-by: Nicholas Pratte <npratte@iol.unh.edu>
>

Reviewed-by: Dean Marx <dmarx@iol.unh.edu>

--00000000000070bf6b062644b1b2
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Fri, Jul 5, 2024 at 1:20=E2=80=AFPM Ni=
cholas Pratte &lt;<a href=3D"mailto:npratte@iol.unh.edu">npratte@iol.unh.ed=
u</a>&gt; wrote:<br></div><div class=3D"gmail_quote"><blockquote class=3D"g=
mail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204=
,204,204);padding-left:1ex">There is some odd functionality/behavior in how=
 the --test-suite<br>
parameters interacts in conjunction with the &#39;test_suites&#39; attribut=
e in<br>
the config file. If a user leaves an empty list underneath<br>
&#39;test_suites,&#39; or if they negate the attribute entirely, even if sa=
id<br>
user adds test suites via the --test-suite parameter, a schema violation<br=
>
is thrown.<br>
<br>
This patch mitigates this, by removing the schema requirement if the<br>
user has indicated test suites within main.py parameters, allowing for<br>
the &#39;test_suites&#39; attribute to be optional.<br>
<br>
Bugzilla ID: 1360<br>
Signed-off-by: Nicholas Pratte &lt;<a href=3D"mailto:npratte@iol.unh.edu" t=
arget=3D"_blank">npratte@iol.unh.edu</a>&gt;<br></blockquote><div><br></div=
><div>Reviewed-by: Dean Marx &lt;<a href=3D"mailto:dmarx@iol.unh.edu">dmarx=
@iol.unh.edu</a>&gt;=C2=A0</div></div></div>

--00000000000070bf6b062644b1b2--