From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26DBA457A4; Mon, 12 Aug 2024 20:47:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 13CE840664; Mon, 12 Aug 2024 20:47:50 +0200 (CEST) Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by mails.dpdk.org (Postfix) with ESMTP id BE73C40657 for ; Mon, 12 Aug 2024 20:47:48 +0200 (CEST) Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-2d394313aceso143127a91.3 for ; Mon, 12 Aug 2024 11:47:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1723488468; x=1724093268; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=DRrWp/xnPehCLpDXN0z2LFxFs7g5xFcJpPYa+Vv81Aw=; b=ckSARWK9QA1viPfwxWcUlP5bcV4qxLUBvhqjWNbwHYmRUYaDgw8OgiJ5RAN8aEJOCM twKy86XZHu03j5yCvW5wb6iC5MXefCYpKo+CZL167o9iOPX1zu+7eyUbCo8zB5fBG8LT +uc3NRRg0OxTZxVM7GoXNPKUKvSF1h0LGKjGY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723488468; x=1724093268; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DRrWp/xnPehCLpDXN0z2LFxFs7g5xFcJpPYa+Vv81Aw=; b=Cp2fhdBghWo8rni7Me7hz1Fpq4YU3dcmSde1YoJXWW/I/KKu76XCW3tm+WADZwQY8C 9tKf2DMve5EpudvUogDF2c9AH0cLR4yPcnOrR0imi+wmEVE4LBrxZ6kjXfX69lGlPSyg DS8PsJt6fh56UKfoQg1uVJ4+8rJ/03yZRgqwAbefB1cWOHdcDYHur7ogGdHXdkD5JVz5 4+KrGVNedEb/CgBxeR7l6vy5DB5u8R/bF+723LVQ1IyVaNT4cUjrt7lwLQE4IeVWM538 U3lwTLag22l9YJ8C263nMpCqWMoDvVkXbkw8gK1dpH5WZPYUlf5fgK8uVsnWBYuZFzLm FtZw== X-Forwarded-Encrypted: i=1; AJvYcCX4yE21eBHS41uPi+BOl+wji/KHrtFs0V3VQJlnTnJ6GUvl+2RFbL5G3tO/iRPUqIqTVe+ZFmsJuaeWbtk= X-Gm-Message-State: AOJu0YzO0cdHB5pw5cufZnzPRFMZ7iX58Tk/QtJQ1dpwkNYbwRRxDRI5 7btaSzAiBfKawv137J83Ww84ULYCAgc8Hw/gnDRsOw5aElgXFsqNr/xBQQJ5+U905CJaohRgCfn zOiLtMPJk2MLrmShaTNTBUG807dYIAjPq3VG0xg== X-Google-Smtp-Source: AGHT+IHtisB3WBofAvqjhwBOT1NzgR4noHyRpmlEpcA8gXt/hZRB5dMKkJT3LgSp8pdJpIREcF+Bk4QWwKoMEZ1c6TQ= X-Received: by 2002:a17:90a:4701:b0:2c1:a9a2:fcea with SMTP id 98e67ed59e1d1-2d392546c7emr1444685a91.24.1723488467856; Mon, 12 Aug 2024 11:47:47 -0700 (PDT) MIME-Version: 1.0 References: <20240726163915.19277-2-npratte@iol.unh.edu> <20240726164602.25519-1-npratte@iol.unh.edu> In-Reply-To: <20240726164602.25519-1-npratte@iol.unh.edu> From: Dean Marx Date: Mon, 12 Aug 2024 14:47:56 -0400 Message-ID: Subject: Re: [PATCH v4 2/2] dts: mac filter test suite refactored for new dts To: Nicholas Pratte Cc: probb@iol.unh.edu, jspewock@iol.unh.edu, luca.vizzarro@arm.com, yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com, juraj.linkes@pantheon.tech, dev@dpdk.org Content-Type: multipart/alternative; boundary="000000000000e6cc00061f80ed9b" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000e6cc00061f80ed9b Content-Type: text/plain; charset="UTF-8" > > +"""Mac address filtering test suite. > + > +This test suite ensures proper and expected behavior of Allowlist > filtering via mac > +addresses on devices bound to the Poll Mode Driver. If a packet received > on a device > +contains a mac address not contained with its mac address pool, the > packet should > +be dropped. Alternatively, if a packet is received that contains a > destination mac > +within the devices address pool, the packet should be accepted and > forwarded. This > +behavior should remain consistent across all packets, namely those > containing dot1q > +tags or otherwise. > This should probably say "not contained within its mac address pool" instead of "with", since that's how you're wording the rest of the docstrings > + Test cases within this suite utilize this method to create, send, > and verify > + packets based on criteria relating to the packet's destination > mac address, > + vlan tag, and whether or not the packet should be received or > not. Packets > + are verified using an inserted payload. Assuming the test case > expects to > + receive a specified packet, if the list of received packets > contains this > + payload within any of its packets, the test case passes. > Alternatively, if > + the designed packet should not be received, and the packet > payload is not, > + received, then the test case fails. Each call with this method > sends exactly > + one packet. > "and whether or not the packet should be received or not" is redundant Reviewed-by: Dean Marx --000000000000e6cc00061f80ed9b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
+"""Mac address filtering test suite.
+
+This test suite ensures proper and expected behavior of Allowlist filterin= g via mac
+addresses on devices bound to the Poll Mode Driver. If a packet received o= n a device
+contains a mac address not contained with its mac address pool, the packet= should
+be dropped. Alternatively, if a packet is received that contains a destina= tion mac
+within the devices address pool, the packet should be accepted and forward= ed. This
+behavior should remain consistent across all packets, namely those contain= ing dot1q
+tags or otherwise.
<snip>

<= div>This should probably say "not contained within its mac address poo= l" instead of "with", since that's how you're wordin= g the=C2=A0rest of the docstrings
=C2=A0
<snip>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 Test cases within this suite utilize this meth= od to create, send, and verify
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 packets based on criteria relating to the pack= et's destination mac address,
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 vlan tag, and whether or not the packet should= be received or not. Packets
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 are verified using an inserted payload. Assumi= ng the test case expects to
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 receive a specified packet, if the list of rec= eived packets contains this
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 payload within any of its packets, the test ca= se passes. Alternatively, if
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 the designed packet should not be received, an= d the packet payload is not,
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 received, then the test case fails. Each call = with this method sends exactly
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 one packet.
<snip><= /div>

"and whether or not the packet should be rece= ived or not" is redundant
=C2=A0
Reviewed-by: Dean= Marx <dmarx@iol.unh.edu>
--000000000000e6cc00061f80ed9b--