From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3142545683; Mon, 22 Jul 2024 19:39:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 165C94067C; Mon, 22 Jul 2024 19:39:00 +0200 (CEST) Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by mails.dpdk.org (Postfix) with ESMTP id DA7A44028B for ; Mon, 22 Jul 2024 19:38:58 +0200 (CEST) Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-7a2123e9ad5so845025a12.1 for ; Mon, 22 Jul 2024 10:38:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1721669938; x=1722274738; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=/jdFV51vDm0Ssm7bvt2OEOILTbs1a33o1lqyu/rb2t0=; b=DDFaqZRQpkp9bZIVt36umA0IE3sghIFNOzQxxlEjZeokiyRX9sNyrhBrm0xE4JkcEh GdOrIvrD/1CnOjEETxiRswtcAWzDhUwzAKbedRyjfQ9i7QQZq5L4BT/2V/X7Mwjcz0wn JNHc6z31K3vWpDY4XeYTNWqlWHOCEiHG3nW4M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721669938; x=1722274738; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/jdFV51vDm0Ssm7bvt2OEOILTbs1a33o1lqyu/rb2t0=; b=QnZZYLOZUhUD48HUAWSGbTqDZQYPYAOHU40owKN+07N1IMFcQCfV6e2stCjgJb/8wb yWDW56JNjes06XTDlLrcLf7ovKlf6kG38vEtSg4da02g0rskUdvjZTHalI7AX3AU/lfB uywmZGr4vcUmPLwSkZ8yaacSdsjPxrHQKoiXA2Z59ss2Fim36Yb5qmzE6ls0oZy6DVqe Vep2sjj0PhD41y7dYXVUr45zrVKkE5oWrlg7AnI2sos5OrFyGWlMUKoM3KbOrgsU1VVQ eWeExzrngWOuB6bl8Xty/6T86v79qy31681dm4clu37InPAU9J6Al8lQUTewJ6HE137r ZWZA== X-Forwarded-Encrypted: i=1; AJvYcCW862K62QKY9hI9ZF4ltiQCharPtkPkaXScm2FfDJMmYNokOMoahT+7vWRSxtrvj0+tA7C1m3Vqy14TXdQ= X-Gm-Message-State: AOJu0YwieK4KR2Io+jhtworbNLz/IbUmPokkUsHbBxma95vPcX5KUDMd pV7xjYCRN/AubgfsunRZu2TlMY2SYMbzoaBtApYfgZjwP03g4eL3uFTEJnH/KMcBE5YrTg43K+z v1uIQDM256YcqcTUx9a3BBwDsYrXZ4wGqXsdmIEZvlOG75dPu X-Google-Smtp-Source: AGHT+IGz+4GfVhgA7y+46h26b28VYL49gZof2S/QiQc4gbIsMhcoN5wRrOZ82n+jZzOfrA0BkJkNo369KyfQeiiItW8= X-Received: by 2002:a17:90b:2303:b0:2ab:8324:1b47 with SMTP id 98e67ed59e1d1-2cd170c92f3mr14075385a91.15.1721669937888; Mon, 22 Jul 2024 10:38:57 -0700 (PDT) MIME-Version: 1.0 References: <20240715195852.254033-1-jspewock@iol.unh.edu> <20240715195852.254033-3-jspewock@iol.unh.edu> In-Reply-To: <20240715195852.254033-3-jspewock@iol.unh.edu> From: Dean Marx Date: Mon, 22 Jul 2024 13:38:40 -0400 Message-ID: Subject: Re: [PATCH v1 2/3] dts: add dual_vlan testing suite To: jspewock@iol.unh.edu Cc: probb@iol.unh.edu, juraj.linkes@pantheon.tech, thomas@monjalon.net, wathsala.vithanage@arm.com, paul.szczepanek@arm.com, npratte@iol.unh.edu, yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, Luca.Vizzarro@arm.com, dev@dpdk.org Content-Type: multipart/alternative; boundary="00000000000011a50a061dd985a3" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --00000000000011a50a061dd985a3 Content-Type: text/plain; charset="UTF-8" > > > + recv = self.send_packet_and_capture(pakt) > + self.verify(len(recv) > 0, "Did not receive and packets when > testing VLAN priority.") > I'm assuming this should say "any" instead of "and." Other than that, everything looks good to me. Reviewed-by: Dean Marx --00000000000011a50a061dd985a3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
<snip>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 recv =3D self.send_packet_and_capture(pakt) +=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.verify(len(recv) > 0, "Did not re= ceive and packets when testing VLAN priority.")
<= br>
I'm assuming this should say "any" instead of &= quot;and." Other than that, everything looks good to me.
Reviewed-by: Dean Marx <dmarx@iol.unh.edu>=C2=A0
--00000000000011a50a061dd985a3--