From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CAA5F458F8; Tue, 3 Sep 2024 19:50:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8C5C54042C; Tue, 3 Sep 2024 19:50:11 +0200 (CEST) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mails.dpdk.org (Postfix) with ESMTP id 778CF402D0 for ; Tue, 3 Sep 2024 19:50:10 +0200 (CEST) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2054e22ce3fso24294225ad.2 for ; Tue, 03 Sep 2024 10:50:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1725385809; x=1725990609; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=PLN1vFTK0hNJOjVJulEu9WP072ssVRxMQb4/6lUsCIU=; b=F5HRcFxmofYIZ0yOG6tGgedOlsio8tARZtAJFpsNaD+qY1RHG+5sRVJu+Dm65fMaWM 0qgj3jRhtzOSYuBxksHPZWlcKL+nrxu06jTLZXWVoNd/til0QEPPDNQJycgzpd+UC0AL mGVVUMcjRDNNN1fyPtmHT+jiVh46psn5EOxNs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725385809; x=1725990609; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PLN1vFTK0hNJOjVJulEu9WP072ssVRxMQb4/6lUsCIU=; b=ayYFKi7rBEF7leABQUj7PDFP2kQbnwCKIsMDbG8UpNj83KYZ7eROh0Y0bimcv7K6ak ONOC2KsWL0y/MkRfsPTK1suZOlDIhtHjE0MKQQPuEltEitONyWXA9qu+b6fcFRAw3/eM PDYXYvFNQQwwPzZP46uBAA7GOh2W3SOnXhJ4YMaOE9WpQLBBeQ+JNDGaCF0k9tST2ffG VXuKeFtPRVfCjO7j7OEs8bjgY/skurlE087n/3dtegmI1edPEaMn9//Skkmb5U38Sofh t15j/28RUQgxqCvsby7j55YRkkG0z5cTm5vJ8sm6+IwmWWdFS60aT139//D8ofe3WndG 12Cw== X-Forwarded-Encrypted: i=1; AJvYcCXRKhFr8P39aFaAHy0g22idfVMywYtG00ZKKU5ApX8iMlXTzy4s64Rlv/lF392FD37sPHg=@dpdk.org X-Gm-Message-State: AOJu0YwVh7LD1Wjua9RPTVKR/FkaYoO3QtFKdhE4gLLjyhq7rxdS2rep g7Cp0aNbcq+SGIQrRN/Y4NLwkIXIMYsCb+z2ZoThccFjvrmBVpTUxSLVrRvkxKn86mSE4JHlX4A VcZ/KJOZ3VMzAgRegNyvzWZjV7f14gqzGPu7R3A== X-Google-Smtp-Source: AGHT+IHCP9Hwmf5Z+6OVpX60fOA41M0D1cw4Q9LcmqNaePOk8lRF8ioOWR/Bz9DkKtD30dZopWV4Q7Ang0m1iW4CkJo= X-Received: by 2002:a17:903:186:b0:202:c33:b7a5 with SMTP id d9443c01a7336-20699ae5694mr33244535ad.14.1725385809327; Tue, 03 Sep 2024 10:50:09 -0700 (PDT) MIME-Version: 1.0 References: <20240301155416.96960-1-juraj.linkes@pantheon.tech> <20240821145315.97974-1-juraj.linkes@pantheon.tech> <20240821145315.97974-10-juraj.linkes@pantheon.tech> In-Reply-To: <20240821145315.97974-10-juraj.linkes@pantheon.tech> From: Dean Marx Date: Tue, 3 Sep 2024 13:50:19 -0400 Message-ID: Subject: Re: [PATCH v3 09/12] dts: add topology capability To: =?UTF-8?Q?Juraj_Linke=C5=A1?= Cc: thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, jspewock@iol.unh.edu, probb@iol.unh.edu, paul.szczepanek@arm.com, Luca.Vizzarro@arm.com, npratte@iol.unh.edu, alex.chapman@arm.com, dev@dpdk.org Content-Type: multipart/alternative; boundary="00000000000044170506213ab06e" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --00000000000044170506213ab06e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Aug 21, 2024 at 10:53=E2=80=AFAM Juraj Linke=C5=A1 wrote: > Add support for marking test cases as requiring a certain topology. The > default topology is a two link topology and the other supported > topologies are one link and no link topologies. > > The TestProtocol of test suites and cases is extended with the topology > type each test suite or case requires. Each test case starts out as > requiring a two link topology and can be marked as requiring as > topology directly (by decorating the test case) or through its test > suite. If a test suite is decorated as requiring a certain topology, all > its test cases are marked as such. If both test suite and a test case > are decorated as requiring a topology, the test case cannot require a > more complex topology than the whole suite (but it can require a less > complex one). If a test suite is not decorated, this has no effect on > required test case topology. > > Since the default topology is defined as a reference to one of the > actual topologies, the NoAliasEnum from the aenum package is utilized, > which removes the aliasing of Enums so that TopologyType.two_links and > TopologyType.default are distinct. This is needed to distinguish between > a user passed value and the default value being used (which is used when > a test suite is or isn't decorated). > > Signed-off-by: Juraj Linke=C5=A1 > Reviewed-by: Dean Marx --00000000000044170506213ab06e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Aug 21, 2024 at 10:53=E2=80=AFAM = Juraj Linke=C5=A1 <juraj.linkes@pantheon.tech> wrote:
Add = support for marking test cases as requiring a certain topology. The
default topology is a two link topology and the other supported
topologies are one link and no link topologies.

The TestProtocol of test suites and cases is extended with the topology
type each test suite or case requires. Each test case starts out as
requiring a two link topology and can be marked as requiring as
topology directly (by decorating the test case) or through its test
suite. If a test suite is decorated as requiring a certain topology, all its test cases are marked as such. If both test suite and a test case
are decorated as requiring a topology, the test case cannot require a
more complex topology than the whole suite (but it can require a less
complex one). If a test suite is not decorated, this has no effect on
required test case topology.

Since the default topology is defined as a reference to one of the
actual topologies, the NoAliasEnum from the aenum package is utilized,
which removes the aliasing of Enums so that TopologyType.two_links and
TopologyType.default are distinct. This is needed to distinguish between a user passed value and the default value being used (which is used when a test suite is or isn't decorated).

Signed-off-by: Juraj Linke=C5=A1 <juraj.linkes@pantheon.tech>

Reviewed-by: Dean Marx <dmarx@iol.unh.edu>=C2=A0
--00000000000044170506213ab06e--