From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13EC445C9E; Wed, 6 Nov 2024 21:32:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A14B842EA7; Wed, 6 Nov 2024 21:32:13 +0100 (CET) Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) by mails.dpdk.org (Postfix) with ESMTP id 2401442E54 for ; Wed, 6 Nov 2024 21:32:12 +0100 (CET) Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-6ea053b5929so1606197b3.0 for ; Wed, 06 Nov 2024 12:32:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1730925131; x=1731529931; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=P6HGRxBitdB9iRRiFd1r0FG74xrZMaJKW93TNPei1Sw=; b=ed0/cJice55EStUbIyDgJimtP9b3MC+EechwjadY0Tv3B6pISXf6A+9VMd5I8n81cL 85e6HE71fD+KMBljlZUvcDtDSPm5o3kfzcPzeDuLkzDTSUPsqE+GOrkvarZfwGjS8I/o P/WzRFUO9a3mQZoc1B8v9ciC5sNYwUux1NNQI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730925131; x=1731529931; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=P6HGRxBitdB9iRRiFd1r0FG74xrZMaJKW93TNPei1Sw=; b=PWFwPuOwdujLJdXU8NxolEWcGW3INbwhCn46BArwHnGRcn/eK78ep/P6Z934N5VVmD sMgdfic5FAQwVKTNA7XNdvNqKuMAnPvd0u4lXHAW73mEu8mscNMXFouzMN5YdR/0iGXw 85c1akE34Mxb5nkIrwY804V5L0FfpYwbkFo3J2YDZNWaW3FZPtFAFeV0g/8Y6lSXpmIK LblkMRJJqwp1QKFrcamf0qkLzpStMdUJU+nKe3Qimc51sinNwYhYe3bfuquaj/Qokrk1 SdAE2KlRHVornfXH7gHCXBeV5xx7KwaIZjHLhkDZK76Mzkv0adpmsIrf5/IlAnTI+F0S 6Dcg== X-Forwarded-Encrypted: i=1; AJvYcCWnqDn0cewh/gNOLXEtL8VqCX/RtRHejctDwgO//v9SSEhKjvLZhOIP6VBeeCTyYB8/HuQ=@dpdk.org X-Gm-Message-State: AOJu0YydC44NdUle82GIVcscm2z0mMqKvmudJmbPmO78ziIbszZvpe4K 8xKIxRtJgl8Mh58Jhody5gtlGY28qVqgGyTQnutV3P0XTuTc+B9H+3qJ6SzQ15aYwwsyrzI+a6/ XPUlS6fHIM7nJ6X77x5LM1lq4G5jRXC9fSGGZ1Q== X-Google-Smtp-Source: AGHT+IHp1br1NPBaH3/38f78y5WCl8WF2usmV0Ckh7EWW7uV+cVtWzp2tFtOkB//z2pZ1glvNQBVV7FkDnVVK/EioAc= X-Received: by 2002:a05:690c:d8d:b0:6ea:813a:a00a with SMTP id 00721157ae682-6ea813aa2e3mr144772647b3.31.1730925131515; Wed, 06 Nov 2024 12:32:11 -0800 (PST) MIME-Version: 1.0 References: <20240705171341.23894-2-npratte@iol.unh.edu> <20240705183234.31333-2-npratte@iol.unh.edu> In-Reply-To: <20240705183234.31333-2-npratte@iol.unh.edu> From: Dean Marx Date: Wed, 6 Nov 2024 15:32:25 -0500 Message-ID: Subject: Re: [PATCH v2 4/6] dts: Rework DPDK Attributes In SUT Node Config To: Nicholas Pratte Cc: paul.szczepanek@arm.com, juraj.linkes@pantheon.tech, yoan.picchi@foss.arm.com, jspewock@iol.unh.edu, luca.vizzarro@arm.com, probb@iol.unh.edu, Honnappa.Nagarahalli@arm.com, dev@dpdk.org Content-Type: multipart/alternative; boundary="00000000000098e24d06264469b9" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --00000000000098e24d06264469b9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Jul 5, 2024 at 2:32=E2=80=AFPM Nicholas Pratte wrote: > Rework 'lcores' and 'memory_channels' into a new 'dpdk_config' > subsection in an effort to make these attributes SUT specific; the > traffic generator, more often than not, does not need this information. > Ideally, if such information is needed, then it will be listed in the > 'traffic_generator' component in TG Node configuration. Such logic is > not introduced in this patch, but the framework can be rewritten to do > so without any implications of extreme effort. > > To make this work, use_first_core has been removed from the framework > entirely in favor of doing this within the LogicalCoreListFilter object. > Since use_first_core was only ever activated when logical core 0 was > explicitly defined, core 0 can be removed from the list of total logical > cores assuming that it was not listed within filter_specifier. > > This patch also removes 'vdevs' from 'system_under_test_node' and moves > it into 'executions.' > > Bugzilla ID: 1360 > Signed-off-by: Nicholas Pratte > > - memory_channels: 4 # tells DPDK to use 4 memory channels > - hugepages_2mb: # optional; if removed, will use system hugepage > configuration > - number_of: 256 > - force_first_numa: false > Just curious, is there a reason 256 is the default value? Reviewed-by: Dean Marx --00000000000098e24d06264469b9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, Jul 5, 2024 at 2:32=E2=80=AFPM Ni= cholas Pratte <npratte@iol.unh.ed= u> wrote:
Rework 'lcores' and 'memory_channel= s' into a new 'dpdk_config'
subsection in an effort to make these attributes SUT specific; the
traffic generator, more often than not, does not need this information.
Ideally, if such information is needed, then it will be listed in the
'traffic_generator' component in TG Node configuration. Such logic = is
not introduced in this patch, but the framework can be rewritten to do
so without any implications of extreme effort.

To make this work, use_first_core has been removed from the framework
entirely in favor of doing this within the LogicalCoreListFilter object. Since use_first_core was only ever activated when logical core 0 was
explicitly defined, core 0 can be removed from the list of total logical cores assuming that it was not listed within filter_specifier.

This patch also removes 'vdevs' from 'system_under_test_node= 9; and moves
it into 'executions.'

Bugzilla ID: 1360
Signed-off-by: Nicholas Pratte <npratte@iol.unh.edu>
<snip&= gt;=C2=A0
-=C2=A0 =C2=A0 memory_channels: 4 # tells DPDK to use 4 memory channels
-=C2=A0 =C2=A0 hugepages_2mb: # optional; if removed, will use system hugep= age configuration
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 number_of: 256
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 force_first_numa: false
<= br>
Just curious, is there a reason 256 is the default value?
=
Reviewed-by: Dean Marx <dmarx@i= ol.unh.edu>=C2=A0
--00000000000098e24d06264469b9--