DPDK patches and discussions
 help / color / mirror / Atom feed
From: Dean Marx <dmarx@iol.unh.edu>
To: Patrick Robb <probb@iol.unh.edu>
Cc: Luca.Vizzarro@arm.com, dev@dpdk.org, Paul.Szczepanek@arm.com,
	 abailey@iol.unh.edu
Subject: Re: [PATCH v2] dts: testpmd link check on port start
Date: Thu, 6 Nov 2025 12:14:59 -0500	[thread overview]
Message-ID: <CABD7UXOSvFY65O7djZCH7K1C9jwxNNwAq6QJktS1FJDGS2yuaQ@mail.gmail.com> (raw)
In-Reply-To: <20251105194925.1507334-1-probb@iol.unh.edu>

On Wed, Nov 5, 2025 at 2:50 PM Patrick Robb <probb@iol.unh.edu> wrote:
>
> When running our existing DTS testsuites on a new
> NIC we observed packets would not transmit from
> the traffic generator to the system under test
> even after DPDK testpmd and the NIC under test
> had indicated readiness. After investigation, we
> determined that the existing readiness check in DTS
> for testpmd start (checking that port is started)
> is insufficient, because on some systems the link
> will remain down for some measurable time, creating
> a race condition between the testpmd port's link
> coming up and the DTS execution reaching the packet
> transmission step. This change will ensure that
> testpmd start will block until the port is reporting
> that its link is up. In addition, the interval in
> between checking the link state has been reduced in
> order to speed up the execution.
>
> Signed-off-by: Patrick Robb <probb@iol.unh.edu>
> Tested-by: Patrick Robb <probb@iol.unh.edu>

<snip>
>              if "Link status: up" in port_info:
>                  break
> -            time.sleep(0.5)
> +            time.sleep(0.25)

What's the rationale for changing this, just wondering?

Reviewed-by: Dean Marx <dmarx@iol.unh.edu>

  parent reply	other threads:[~2025-11-06 17:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-08  1:41 [PATCH] dts: add dpdk shell warm up period Patrick Robb
2025-09-08  1:57 ` Patrick Robb
2025-09-08 10:03 ` Luca Vizzarro
2025-09-08 13:21   ` Patrick Robb
2025-11-05 19:49 ` [PATCH v2] dts: testpmd link check on port start Patrick Robb
2025-11-06 15:05   ` Andrew Bailey
2025-11-06 17:14   ` Dean Marx [this message]
2025-11-06 18:00     ` Patrick Robb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABD7UXOSvFY65O7djZCH7K1C9jwxNNwAq6QJktS1FJDGS2yuaQ@mail.gmail.com \
    --to=dmarx@iol.unh.edu \
    --cc=Luca.Vizzarro@arm.com \
    --cc=Paul.Szczepanek@arm.com \
    --cc=abailey@iol.unh.edu \
    --cc=dev@dpdk.org \
    --cc=probb@iol.unh.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).