From: Dean Marx <dmarx@iol.unh.edu>
To: Patrick Robb <probb@iol.unh.edu>
Cc: npratte@iol.unh.edu, luca.vizzarro@arm.com,
yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com,
paul.szczepanek@arm.com, dev@dpdk.org
Subject: Re: [RFC PATCH 1/1] dts: add SUT cleanup to framework
Date: Thu, 30 Jan 2025 16:32:26 -0500 [thread overview]
Message-ID: <CABD7UXOrEfY=3m7aUgucHq5P-M45USOWXfjbMdEXXobEJrzZpw@mail.gmail.com> (raw)
In-Reply-To: <CAJvnSUA8w0-JyPnUuX8DwAXi0wYjFkhO7h+2M2CvnmzbMzBhUQ@mail.gmail.com>
> My first question was why is there a need to pass all of dpdk_config through from here all the way to cleanup_sut()? Is it sufficient to extract dpdk_location from dpdk_config at the beginning here, and pass along just dpdk_location?
I can do that too if it's preferred, wasn't sure what the best way to
handle that was my apologies
> I understand the need for str or PurePath, but can you explain why None is included in the union?
I believe it was just so the linter wouldn't throw errors in the check
format script, but I can double check that.
> There was also discussion at the previous DTS meeting about appending the datetime to the dpdk artifacts when they're copied over to the SUT (a way to create artifact uniqueness). It's not really within the scope of this patchseries, but it wouldn't hurt for us to touch base - maybe you can do this next.
Yes, that's in progress currently but I've put it on the backburner
for now. Will send out a separate RFC for that sometime soon.
> Looks good to me overall. Once you submit the v2 I will leave a little time for other comments, otherwise I will merge.
>
> Thanks Dean.
Sounds good, I'll get that out asap
next prev parent reply other threads:[~2025-01-30 21:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 20:59 [RFC PATCH 0/1] " Dean Marx
2024-12-09 20:59 ` [RFC PATCH 1/1] " Dean Marx
2025-01-30 5:31 ` Patrick Robb
2025-01-30 6:30 ` Patrick Robb
2025-01-30 21:32 ` Dean Marx [this message]
2025-01-30 22:13 ` [PATCH v2] " Dean Marx
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABD7UXOrEfY=3m7aUgucHq5P-M45USOWXfjbMdEXXobEJrzZpw@mail.gmail.com' \
--to=dmarx@iol.unh.edu \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=luca.vizzarro@arm.com \
--cc=npratte@iol.unh.edu \
--cc=paul.szczepanek@arm.com \
--cc=probb@iol.unh.edu \
--cc=yoan.picchi@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).