From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C6514614D; Thu, 30 Jan 2025 22:32:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2098340275; Thu, 30 Jan 2025 22:32:40 +0100 (CET) Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com [209.85.219.177]) by mails.dpdk.org (Postfix) with ESMTP id 6D0564025A for <dev@dpdk.org>; Thu, 30 Jan 2025 22:32:38 +0100 (CET) Received: by mail-yb1-f177.google.com with SMTP id 3f1490d57ef6-e455bf1f4d3so1765230276.2 for <dev@dpdk.org>; Thu, 30 Jan 2025 13:32:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1738272757; x=1738877557; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=U73YE3Zl/PCcTNZ6Db34Qcwe7KaldQgZ7/NewUbZTPE=; b=MCU8cIj9ajVCz67T/VsF9ExVc5pE0DsMaV3KOxDZLx/JAV3Zkqf2z/S4VzygcJYZRd UV1XL1rDW2Dj5syJzD1HiBceuFDLnAa5KBmF+Gn2tUOQu1Kr22b3Oo+WrSRnge0rGe9o UtrmpPd2x7uF6jXIpFtFxG//BZR9aykiKuJfc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738272757; x=1738877557; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U73YE3Zl/PCcTNZ6Db34Qcwe7KaldQgZ7/NewUbZTPE=; b=ANltah6iQc1k83AixnxqO8R+ywq6qMBD97ESbRBbAQcLDMDHMjSAR2qdLqN5ry7PuZ zq8MfuGPKFVUYVPbrOkb2jfZO9qbeRard1cNQLW+s5TyWFLRRoa1oOEzHPogwyz1PJtf ko1v8re1Wcbs52FAPNldHCpu6nkRb+6lk1zEu51yCpp5sB0nnB2aX55fO9ydxvygkMVi LCGDa2dHKw/bYJtvhT6MDTmENSNxUJ2bG7m/GwYW9Zc2AesIPIsQ8slqpoV4Oondfw4y UriJou1qwlGA6FSY0WgBtvaQZeqIQRZTw+2GAXPy5vHxwo/NmJKYDLp+LShZcQRIucbi 4owA== X-Forwarded-Encrypted: i=1; AJvYcCXY7+AFh+IVohMwiCuIjyZmdjhaurKLu5BtaacCMJHuJgM8GPBn3rTYsxEm3EdYlmSvWlM=@dpdk.org X-Gm-Message-State: AOJu0Yw1hiGfpruaepIDpK8qb+W+MNMbP00gehGBV7uu7e+F65UpTScO //Uem9ooVMSQx2EKNw6blbrHxR88q2XfXoXAyZwzQsCrLvhl+eOAgaUmdbB7ikJHNTED2TVeMAK TJ08krUvH46WbUtzNNrHOgb/IprXkSePWFBdPAw== X-Gm-Gg: ASbGnctI3JWnS/EIWXg5QO2i+DSBKlYF0E+O/Q456T6+m6OoMFEip2hd7yuFAs3Hgrb nfLJw4wSZ0h7hdsXjHyowEO//IfTAvSEAIE6DqkO+4FX9aZqS2loshDlAxYjxd023fpoSfwTPIb XX4R5lvbS7N1giGCEJ8w8Cn4KxLC4yN/8= X-Google-Smtp-Source: AGHT+IF1qqEPsmx/B0BGN46v++/vELouI2nav9o249myfomkQoSF7SjASVtCM0RqpCglItcLwQWHgNKUU1qyBTh0TNI= X-Received: by 2002:a05:6902:2583:b0:e58:8e82:5345 with SMTP id 3f1490d57ef6-e58a4a9b3ccmr6557838276.4.1738272757686; Thu, 30 Jan 2025 13:32:37 -0800 (PST) MIME-Version: 1.0 References: <20241209205902.18321-1-dmarx@iol.unh.edu> <20241209205902.18321-2-dmarx@iol.unh.edu> <CAJvnSUA8w0-JyPnUuX8DwAXi0wYjFkhO7h+2M2CvnmzbMzBhUQ@mail.gmail.com> In-Reply-To: <CAJvnSUA8w0-JyPnUuX8DwAXi0wYjFkhO7h+2M2CvnmzbMzBhUQ@mail.gmail.com> From: Dean Marx <dmarx@iol.unh.edu> Date: Thu, 30 Jan 2025 16:32:26 -0500 X-Gm-Features: AWEUYZmPwuBaEErdfnVAY-uliT4Ta6BE6ko2lmdolJz5u3vbLCCheOj7l2rJrT4 Message-ID: <CABD7UXOrEfY=3m7aUgucHq5P-M45USOWXfjbMdEXXobEJrzZpw@mail.gmail.com> Subject: Re: [RFC PATCH 1/1] dts: add SUT cleanup to framework To: Patrick Robb <probb@iol.unh.edu> Cc: npratte@iol.unh.edu, luca.vizzarro@arm.com, yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org > My first question was why is there a need to pass all of dpdk_config thro= ugh from here all the way to cleanup_sut()? Is it sufficient to extract dpd= k_location from dpdk_config at the beginning here, and pass along just dpdk= _location? I can do that too if it's preferred, wasn't sure what the best way to handle that was my apologies > I understand the need for str or PurePath, but can you explain why None i= s included in the union? I believe it was just so the linter wouldn't throw errors in the check format script, but I can double check that. > There was also discussion at the previous DTS meeting about appending the= datetime to the dpdk artifacts when they're copied over to the SUT (a way = to create artifact uniqueness). It's not really within the scope of this pa= tchseries, but it wouldn't hurt for us to touch base - maybe you can do thi= s next. Yes, that's in progress currently but I've put it on the backburner for now. Will send out a separate RFC for that sometime soon. > Looks good to me overall. Once you submit the v2 I will leave a little ti= me for other comments, otherwise I will merge. > > Thanks Dean. Sounds good, I'll get that out asap