From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2B5045818; Mon, 19 Aug 2024 19:01:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4B3FE4026C; Mon, 19 Aug 2024 19:01:07 +0200 (CEST) Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by mails.dpdk.org (Postfix) with ESMTP id 4ABBA400D6 for ; Mon, 19 Aug 2024 19:01:06 +0200 (CEST) Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-7afd1aeac83so3657827a12.0 for ; Mon, 19 Aug 2024 10:01:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1724086865; x=1724691665; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4+VCvdX780hY3jy+2DJ9Er9j0pXaHYZ5CLhV79sYVX4=; b=PUw4MM61Yi0q8YPUBrmv99oLoff9MKBh0CFR2guORm2kzZFlbTbBJibz2kJZF1H3gb ogHTBUZtr5qegTkM0dbfqSRX1J4CnH5Fje8oDguya5rfJPjI4gTTYJMP8SgqCvKxFcER etdTlZHQY/+ZI8Vv5+qeRzb8xWBDZyWS7K0hc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724086865; x=1724691665; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4+VCvdX780hY3jy+2DJ9Er9j0pXaHYZ5CLhV79sYVX4=; b=KBMWZ9tkJ8HATFYPc1E9iVVmdG5m8019JQsA/SFK54K9J8Zdum0Tp0xW49JA/125us bCZkPVBmeisHs9VmpBTr+/YkwUMCkKNXhMQ/HJmDeKbI9+y/fnf+SuYzygHC8s80YG6d kXCNc5FgW5qmyuORR8PEqbaAn9KkNGcVW4OpNRemDmeFYNsC3gt7jelLWyDMJCbu1wFf BExF9J1lVZF/ibN1D/KYq5O736VJhTEVMTGn1LaXsuC4W+0hduKer9Y/J6aXINgKP4hn BK1AMaXbL+9pFp+nJlzCo7mVGdz7SaZjuXdEUX4N4Dc0ZicPVKC5okQ5x5TIs4zxTt+1 YIfw== X-Forwarded-Encrypted: i=1; AJvYcCVX93LAwauD+SnqoaILGD/IE79ucYFBFkl66lIDP6SPwzZQJbxetvSR2XZox4GELKIZZx1W4st8Kc4PaVI= X-Gm-Message-State: AOJu0YwfThGDdk2oMTimAI6ra2phX1cG042lyJiZlHeAZOaAevYo+BQs QRIysyNLjBXQ+IsoduiyYIo5GDvbqJTQzMU9V0f50GEZQBZOr3fskNuRU7F7Tu2QW/TTle+Z3ef YcyugE/vHIJD5YGvUjnA1hUfmPl5/w2X3FICbiA== X-Google-Smtp-Source: AGHT+IF9feNmPR8Mqii+N4Tl8vSmhTVt0jacbcwWwizZgYw5f7uPa3hHkdP+oSPxwhWbdfpuz4fd2smBledVBIzWNoQ= X-Received: by 2002:a17:90a:b308:b0:2d4:27de:dc39 with SMTP id 98e67ed59e1d1-2d473218371mr410070a91.6.1724086864949; Mon, 19 Aug 2024 10:01:04 -0700 (PDT) MIME-Version: 1.0 References: <20240816142031.15150-1-dmarx@iol.unh.edu> <20240816142031.15150-3-dmarx@iol.unh.edu> <61704ce2-7e06-4845-8cf2-8f1d26ed2005@arm.com> In-Reply-To: <61704ce2-7e06-4845-8cf2-8f1d26ed2005@arm.com> From: Dean Marx Date: Mon, 19 Aug 2024 13:01:16 -0400 Message-ID: Subject: Re: [PATCH v1 2/2] dts: checksum offload test suite To: Alex Chapman Cc: probb@iol.unh.edu, npratte@iol.unh.edu, jspewock@iol.unh.edu, luca.vizzarro@arm.com, yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com, juraj.linkes@pantheon.tech, dev@dpdk.org Content-Type: multipart/alternative; boundary="00000000000025ce4006200c41d5" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --00000000000025ce4006200c41d5 Content-Type: text/plain; charset="UTF-8" > > > > + def send_packet_and_verify( > > Should this not be `send_packets_and_verify(` as the argument is > `packet_list`. > Yeah that would definitely make more sense, I'll change that in the next version. > > > + isL4 = any( > > + VerboseOLFlag.RTE_MBUF_F_RX_L4_CKSUM_GOOD in packet.ol_flags > > + for index in verbose_output > > + for packet in index.packets > > + ) > > How does this filter out noise packets with valid checksums? > It really doesn't right now, I was considering using another verbose output parameter to verify the packet matches the one that is sent, but I hadn't included it yet since I wasn't sure which would be best. I feel as though either length or src_mac would be the easiest to use, but if you or anyone else has a better idea let me know and I'll incorporate it. > > > + isIP = any( > > + VerboseOLFlag.RTE_MBUF_F_RX_IP_CKSUM_GOOD in packet.ol_flags > > + for index in verbose_output > > + for packet in index.packets > > + ) > > > I also noticed there was no implementation of IPv6/SCTP. Although the > old test suite did not include IPv6/SCTP, would it be worth adding it to > the new test suite? > It was included in the test plan, but never implemented for some reason. > > I'm assuming you mean SCTP/IPv6 checksums, which I didn't see in any verbose output on any NIC I had access to so I just left it out. I was assuming that was the same reason they left it out of the old suite, as this included the i40e driver, and testpmd only ever displayed IP, L4, and outer checksums. --00000000000025ce4006200c41d5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
<snip>
> +=C2=A0 =C2=A0 def send_packet_and_verify(

Should this not be `send_packets_and_verify(` as the argument is
`packet_list`.

Yeah that would definite= ly make more sense, I'll change that in the next version.
=C2= =A0
<snip>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 isL4 =3D any(
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 VerboseOLFlag.RTE_MBUF_F_RX= _L4_CKSUM_GOOD in packet.ol_flags
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 for index in verbose_output=
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 for packet in index.packets=
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 )

How does this filter out noise packets with valid checksums?

It really doesn't right now, I was considering us= ing another verbose output parameter to verify the packet matches the one t= hat is sent, but I hadn't included it yet since I wasn't sure which= would be best. I feel as though either length or src_mac would be the easi= est to use, but if you or anyone else has a better idea let me know and I&#= 39;ll incorporate it.
=C2=A0

> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 isIP =3D any(
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 VerboseOLFlag.RTE_MBUF_F_RX= _IP_CKSUM_GOOD in packet.ol_flags
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 for index in verbose_output=
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 for packet in index.packets=
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 )


I also noticed there was no implementation of IPv6/SCTP. Although the
old test suite did not include IPv6/SCTP, would it be worth adding it to the new test suite?
It was included in the test plan, but never implemented for some reason.

I'm assuming you mean SCTP/IPv6 c= hecksums, which I didn't see in any verbose output on any NIC I had acc= ess to so I just left it out. I was assuming that was the same reason they = left it out of the old suite, as this included the i40e driver, and testpmd= only ever displayed IP, L4, and outer checksums.
--00000000000025ce4006200c41d5--