From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (unknown [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87DEE460A7; Thu, 16 Jan 2025 21:54:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9267F40E8A; Thu, 16 Jan 2025 21:54:05 +0100 (CET) Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) by mails.dpdk.org (Postfix) with ESMTP id 3FF5940E96 for ; Thu, 16 Jan 2025 21:54:04 +0100 (CET) Received: by mail-yb1-f173.google.com with SMTP id 3f1490d57ef6-e3c8ae3a3b2so2067007276.0 for ; Thu, 16 Jan 2025 12:54:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1737060843; x=1737665643; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=kK1Ug4x3oJ24gBmja/8z1Yw3/7vmq5VDq+k3dAXdqx0=; b=ASgAtGcDDCBHuEVq6PPuZozJrvqtE58uS32cjLkY1V9ABy8OWUYnRfjtFgLEyG+41z MsUaLLJga36CO19nv9qKVIfiwFu6OKo9tiZIwEI8SFCV1KrlQG6+NR+G1bq7zg4g/fGk 2SSGMOQTbMW783rei59gWB2567BW5JtuNW69c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737060843; x=1737665643; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kK1Ug4x3oJ24gBmja/8z1Yw3/7vmq5VDq+k3dAXdqx0=; b=V+bb5SoEseiEj7XTEGYnqHJuyX/N8eDbvzLOV4sSvIWAPwaar3nJ21UXWUKNrrA+7R 5IPUlHnMdHRHaDyap2BWT69Api+BbRBnFcI4KOeSAL2RZkITCRWeqPa964Yihck8OEVJ Wq28PfouC2ZPNEyn++cf5HHTQdOQJd0ZSbgT7E9ssXwIqpxERJVMLy6c4DKtEJ+fn92T 3QNTIEujh7ngh+Hq1Vt5N9WHrR1NH+8u9l5umfQKfGt2sUannNMfqGZXD5A1OowpWBxR apGYeuJF37KsYvaOcwRMuJZH/sZPLi2eg44eSi9aPugyEFi6WApAM2zXslMsSmDOcWmp 67oQ== X-Gm-Message-State: AOJu0Yzl0Xm6uI59f9CrUpfMzNHMZcVZ5Ws47yW7rzyEVHRhecihdixZ 8MsJigKJqNekLDPZr2XNmVZAoaAa6d8a2EvWEK69aCKm6MqdlGmgmJ/3mZ3PpqSzbdbn0Q7GADu rhoP/hpyqMNxgpWVqVt1ekYDnDFuw0g1UFD6Avg== X-Gm-Gg: ASbGncsej5cKhdo+p99i+YnXzgBFJg2SV/+VDXkSrEWGnrlDD0WsLMMX66I9i/m9938 XfNEh4ai038hJTe+z2HIEOU2CwZxFaszRSz233ZERbzuLj6ccRUlHz3TGNbyMacwxD/45eTAO X-Google-Smtp-Source: AGHT+IHymcJtuNsMlPb9D9w2l7RY45yWQWISnY0cM31xUaO4zc/BZsLC1mhY8X+Kf2bYFWJ9/vO8cSPQwHEf8xc5WTU= X-Received: by 2002:a05:690c:9681:b0:6f5:393f:cf48 with SMTP id 00721157ae682-6f6eb684324mr234497b3.21.1737060843679; Thu, 16 Jan 2025 12:54:03 -0800 (PST) MIME-Version: 1.0 References: <20240705171341.23894-2-npratte@iol.unh.edu> <20250115141809.3898708-1-luca.vizzarro@arm.com> <20250115141809.3898708-6-luca.vizzarro@arm.com> In-Reply-To: <20250115141809.3898708-6-luca.vizzarro@arm.com> From: Dean Marx Date: Thu, 16 Jan 2025 15:53:55 -0500 X-Gm-Features: AbW1kvZvHo7h2-SQUSPuLPyDTw5H0XjEyfHuDXSXwLJpb6rFvGWGluR1_RUxx7A Message-ID: Subject: Re: [PATCH v3 5/7] dts: handle CLI overrides in the configuration To: Luca Vizzarro Cc: dev@dpdk.org, Nicholas Pratte , Paul Szczepanek , Patrick Robb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jan 15, 2025 at 9:19=E2=80=AFAM Luca Vizzarro wrote: > > The current handling of the configuration loading is inconsistent. After > the whole configuration is loaded, if there are any CLI or environment > overrides set, the code forcefully modifies the frozen configuration to > use them. > > This changes the handling by passing the environment/CLI settings as > part of the configuration context and handle the overrides directly at > the field level before these are validated. As a positive side effect, > the validator won't complain if a field is missing from the file but it > has been specified as an environment/CLI override. > > Bugzilla ID: 1360 > Bugzilla ID: 1598 > > Signed-off-by: Nicholas Pratte > Signed-off-by: Luca Vizzarro > Reviewed-by: Paul Szczepanek Reviewed-by: Dean Marx