From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (unknown [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0AE05460A8; Thu, 16 Jan 2025 22:01:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D116340A4B; Thu, 16 Jan 2025 22:01:34 +0100 (CET) Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) by mails.dpdk.org (Postfix) with ESMTP id EEFBC40696 for ; Thu, 16 Jan 2025 22:01:32 +0100 (CET) Received: by mail-yb1-f171.google.com with SMTP id 3f1490d57ef6-e3c8ae3a3b2so2077059276.0 for ; Thu, 16 Jan 2025 13:01:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1737061292; x=1737666092; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DvLZfZyrArbgAvUk4W1H4Lmrl82fLdK4W+Q8iWycmwI=; b=cudMOAxSj0HOm5Of0PvX7I6xbvObiyVU2bxD5G93BI01NOgJJ1zjqv88pWymcn952j qkFaDPjmoXwGfrBl9EmOoDXU9lORQUpl5jok1x1UwoDJFKLnTGS4nNWMrEJ5OURdIVVE yPQZqkTYWak6CFj4Gh+8+fPw+Ka4meG5QrOzU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737061292; x=1737666092; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DvLZfZyrArbgAvUk4W1H4Lmrl82fLdK4W+Q8iWycmwI=; b=ixQjFXoJYip6W++8V8GdPqhjWOPj9mGMkvlBYFHYus3oMSCLHzOUQriUKYvfVJhIwj hbnj/ViqDu1hLL05Ye8/JL1Hj9Om/Ay5ZABD/9z2l6b95Y89G+Yo/WcPky0g6QUlf3c3 DHIDEYojTOn6WF8lwHR9YectlUX4dJYK5wyhTFCFPTRhuQjpTP4oWJ7LVVy3F5mbQjSv fOSmIlIDUcw3PdhF39dS/e+HjoLXS21cG5+m41y3bjj4dBX6ffRtY8H8AM1uNsLDaTbF w6AhxMH2d3X9AphLHDsYRIJEbvLAKfmEPB0fDblKlNYIKW0IhjiQLPxETfvDpkTRYaLJ ++xQ== X-Gm-Message-State: AOJu0YwaDAAaJc9eciYBafU6UJvT1gRKJ11mI/LB1GwtLG/F6B2CZz5Y 2+S58sQSd1Z6h/nEBdWOw1dUWC/h1t1BaBVynVFrCbeUgfwTcJPAI/gbb1n10KQEMXCNMfKPqb2 9P6vrR50sQudSkUID40Ic2W1oDkBP3EBsaHjpEA== X-Gm-Gg: ASbGncsLVsaAX4KriAVYoXLcaYmTokT99dHVDOlYRe6BpzdC3FigkbEF507RzaCo8G8 Z6ntffogRabGJKCnpV6sZaCpzH1BNXl6lSOZzmAvfTb/DUWKvTjQV+H/xh9ZmgvnQb675qJHX X-Google-Smtp-Source: AGHT+IFvBQnrtYjS+zVdB3aSgwkjlesguErTbfukSriSLNScZCG1BHwoOzYXloR4sCKs356wPtphfCr6NjvRxs+Vl30= X-Received: by 2002:a05:690c:3485:b0:6f4:3b8f:8e3f with SMTP id 00721157ae682-6f6eb9326c9mr108577b3.38.1737061292135; Thu, 16 Jan 2025 13:01:32 -0800 (PST) MIME-Version: 1.0 References: <20240705171341.23894-2-npratte@iol.unh.edu> <20250115141809.3898708-1-luca.vizzarro@arm.com> <20250115141809.3898708-8-luca.vizzarro@arm.com> In-Reply-To: <20250115141809.3898708-8-luca.vizzarro@arm.com> From: Dean Marx Date: Thu, 16 Jan 2025 16:01:23 -0500 X-Gm-Features: AbW1kva8WgWJvYqumCMJ0WwYIu4dMFsZKFxvj-JWD9rT9mbI26Yh3isBA-NdciA Message-ID: Subject: Re: [PATCH v3 7/7] dts: run all test suites by default To: Luca Vizzarro Cc: dev@dpdk.org, Nicholas Pratte , Paul Szczepanek , Patrick Robb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jan 15, 2025 at 9:19=E2=80=AFAM Luca Vizzarro wrote: > > The configuration requires the user to explicitly set the requested test > suites in the files. Sometimes we want to run all the test suites and > don't want to manually specify all of them. It is therefore reasonable > to change the default behaviour to automatically run all the available > test suites if none are specified. > > Bugzilla ID: 1360 > > Signed-off-by: Luca Vizzarro > Reviewed-by: Paul Szczepanek Looks good, would it be worth mentioning in the comment above the test_suites field that removing it will default to running all suites? Otherwise I'm not sure how a user would know this without digging through the docs or framework. i.e.: # the following test suites will be run in their entirety. If removed, all test suites will be run. test_suites: etc. Reviewed-by: Dean Marx