From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0138545681; Mon, 22 Jul 2024 15:09:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E3F094042E; Mon, 22 Jul 2024 15:09:50 +0200 (CEST) Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by mails.dpdk.org (Postfix) with ESMTP id 59C1E402AC for ; Mon, 22 Jul 2024 15:09:50 +0200 (CEST) Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-36865a516f1so2996459f8f.0 for ; Mon, 22 Jul 2024 06:09:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1721653790; x=1722258590; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=kOfi8V6l9XeK6kvLV6mUhlnfKHCCObwOfqkA6Rv+94M=; b=U6NyMJDDi7ZvjXdtCuSmWkzQFks3R4GTQ1LxFw9XsmhZZnZQx5bvKd0qdMBXMx4cMZ 0WknfAMC7LuKhAZq/wM7lY54TNVMNsGZ/ckqBZX/0Ee/qajO4lTWBgxhQE2le3VIPTSH DxQrCxxtBmVWps4dKvbQPlNhmHXT0HUO/hywY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721653790; x=1722258590; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kOfi8V6l9XeK6kvLV6mUhlnfKHCCObwOfqkA6Rv+94M=; b=mP+abS4dEpFP76A5T54JGnwKxPySB2K7osrqBfXnxWsZykFKE0eEkbkLxvNOoosDAI +gMr2dlmxBwqS8HtENxULFa6LPGAFfaK9smCZuVF0qyhqtSdM8b54t9fhGjpwK+lJJiR cI2eoMOSaHS0cJGQF7vgR1w44iSFaWvVUQLfGnxvIvvoZwH05IgoAQghxI854v3xPJjh 3TqY7h/bHZP4HE2rL4I6eNJHxDIuuw3+MYxEEe0E53Ut0ajic/L92EwgZYXcQMlA4xd8 ypdn0X8bKXjkQcQmWuBeZQZPNh9gXLyClpDaLVt7up1rMGzsnKmTX8TaTrAi2KU0i9TJ ozxQ== X-Forwarded-Encrypted: i=1; AJvYcCXVgYgBIKaheXAkKyPpywtNFk3tNAxIDzPD6w1QzVwR5zHpNElv34K8bpivPW5rceURwN/gnkbox9BEaN8= X-Gm-Message-State: AOJu0YwdaW5GFysEKqr4OVt/QweBQBzMZqokoqh0r0jSCwgZDporLIug iz8IXXef0wPQqUEkIB9d5WpW8KQvVzbdU+3gOS6IXP+l/XpK66AJgBAxn9jaAMkwb9hnP38ulbi +HE6Vko05Tvmq9pArzIUKEohC962DRt+kZvGR1w== X-Google-Smtp-Source: AGHT+IFvTshzoUNKfXrnMOPXq9nro6t+/nb5CARhAL3e+2IA5xt006gxj4nZ7sJ4pKCBg/sT20dtOat1B+s2guyWxXU= X-Received: by 2002:a5d:5744:0:b0:368:68d4:94 with SMTP id ffacd0b85a97d-369bae4d53bmr5462865f8f.17.1721653789843; Mon, 22 Jul 2024 06:09:49 -0700 (PDT) MIME-Version: 1.0 References: <20240702192422.2480-2-npratte@iol.unh.edu> <20240702192422.2480-3-npratte@iol.unh.edu> In-Reply-To: <20240702192422.2480-3-npratte@iol.unh.edu> From: Dean Marx Date: Mon, 22 Jul 2024 09:09:32 -0400 Message-ID: Subject: Re: [PATCH v2 1/3] dts: add boolean to adjust addresses To: Nicholas Pratte Cc: Honnappa.Nagarahalli@arm.com, probb@iol.unh.edu, jspewock@iol.unh.edu, juraj.linkes@pantheon.tech, paul.szczepanek@arm.com, luca.vizzarro@arm.com, yoan.picchi@foss.arm.com, dev@dpdk.org Content-Type: multipart/alternative; boundary="00000000000091f8fa061dd5c2d1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --00000000000091f8fa061dd5c2d1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Reviewed-by: Dean Marx On Tue, Jul 2, 2024 at 3:25=E2=80=AFPM Nicholas Pratte wrote: > Various test cases in the mac filter test suite called for granular > manipulation of destination mac addresses to properly test mac address > filtering functionality. To compensate, there is now an > adjust_addresses boolean which the user can toggle if they wish to send > their own addressing; the boolean is true by default. > > Bugzilla ID: 1454 > Signed-off-by: Nicholas Pratte > --- > dts/framework/test_suite.py | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/dts/framework/test_suite.py b/dts/framework/test_suite.py > index 694b2eba65..551a587525 100644 > --- a/dts/framework/test_suite.py > +++ b/dts/framework/test_suite.py > @@ -185,6 +185,7 @@ def send_packet_and_capture( > packet: Packet, > filter_config: PacketFilteringConfig =3D PacketFilteringConfig()= , > duration: float =3D 1, > + adjust_addresses: bool =3D True, > ) -> list[Packet]: > """Send and receive `packet` using the associated TG. > > @@ -195,11 +196,15 @@ def send_packet_and_capture( > packet: The packet to send. > filter_config: The filter to use when capturing packets. > duration: Capture traffic for this amount of time after > sending `packet`. > + adjust_addresses: If :data:'True', adjust addresses of the > egressing packet with > + a default addressing scheme. If :data:'False', do not > adjust the addresses of > + egressing packet. > > Returns: > A list of received packets. > """ > - packet =3D self._adjust_addresses(packet) > + if adjust_addresses: > + packet =3D self._adjust_addresses(packet) > return self.tg_node.send_packet_and_capture( > packet, > self._tg_port_egress, > -- > 2.44.0 > > --00000000000091f8fa061dd5c2d1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Reviewed-by: Dean Marx <dmarx@iol.unh.edu>

On Tue, Jul 2, 2024 = at 3:25=E2=80=AFPM Nicholas Pratte <npratte@iol.unh.edu> wrote:
Various test cases in the mac filter test suite calle= d for granular
manipulation of destination mac addresses to properly test mac address
filtering functionality. To compensate, there is now an
adjust_addresses boolean which the user can toggle if they wish to send
their own addressing; the boolean is true by default.

Bugzilla ID: 1454
Signed-off-by: Nicholas Pratte <npratte@iol.unh.edu>
---
=C2=A0dts/framework/test_suite.py | 7 ++++++-
=C2=A01 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/dts/framework/test_suite.py b/dts/framework/test_suite.py
index 694b2eba65..551a587525 100644
--- a/dts/framework/test_suite.py
+++ b/dts/framework/test_suite.py
@@ -185,6 +185,7 @@ def send_packet_and_capture(
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0packet: Packet,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0filter_config: PacketFilteringConfig =3D = PacketFilteringConfig(),
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0duration: float =3D 1,
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 adjust_addresses: bool =3D True,
=C2=A0 =C2=A0 =C2=A0) -> list[Packet]:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"""Send and receive `packe= t` using the associated TG.

@@ -195,11 +196,15 @@ def send_packet_and_capture(
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0packet: The packet to send.=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0filter_config: The filter t= o use when capturing packets.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0duration: Capture traffic f= or this amount of time after sending `packet`.
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 adjust_addresses: If :data:'= True', adjust addresses of the egressing packet with
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 a default addressi= ng scheme. If :data:'False', do not adjust the addresses of
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 egressing packet.<= br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Returns:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0A list of received packets.=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"""
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 packet =3D self._adjust_addresses(packet)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 if adjust_addresses:
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 packet =3D self._adjust_addresse= s(packet)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return self.tg_node.send_packet_and_captu= re(
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0packet,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self._tg_port_egress,
--
2.44.0

--00000000000091f8fa061dd5c2d1--