From: Andrew Bailey <abailey@iol.unh.edu>
To: Luca Vizzarro <luca.vizzarro@arm.com>
Cc: dev@dpdk.org, dmarx@iol.unh.edu, probb@iol.unh.edu
Subject: Re: [PATCH v3] dts: enable port binding on the TG
Date: Thu, 28 Aug 2025 11:17:55 -0400 [thread overview]
Message-ID: <CABJ3N2UY2N3dGL-Zj97RX5Vqs8pNcCHugUbCG=QmQeT_52CU=g@mail.gmail.com> (raw)
In-Reply-To: <175638514815.25987.9964104140534837687.luca.vizzarro@arm.com>
[-- Attachment #1: Type: text/plain, Size: 1348 bytes --]
Thank you Luca for the feedback,
Future version patches will be in-reply-to the v1. From v2, the only thing
that has changed is the body of the method is_bound_for_dpdk in ports.py.
Before, it would check if the current driver was the same as the dpdk
driver which is inaccurate for the TG node using mellanox cards. This patch
adds coverage for TG's using mellanox cards in this method.
On Thu, Aug 28, 2025 at 8:50 AM Luca Vizzarro <luca.vizzarro@arm.com> wrote:
> Hi Andrew,
>
> I see you've made a bit of a mess with the versioning. v2 was detached
> from the thread, so this is confusing me. Can you make sure that (as per
> contributing guidelines):
> - you always reply with new patches to the very beginning of the thread
> (usually the cover letter of v1 – if it was a single patch, then a
> reply to that patch)
> - you add a cover letter to your patch series explaining your changes
> across versions. You can check other emails in the mailing list to
> gather an understanding of this. Of course, if you are sending a
> single patch, a cover letter is not necessary, but you'll need to
> annotate your patch (the contributing guidelines who how this is done)
>
> Finally, I cannot tell easily tell what changed from v2. Can you please
> give a summary of the changes?
>
> Best,
> Luca
>
[-- Attachment #2: Type: text/html, Size: 1799 bytes --]
next prev parent reply other threads:[~2025-08-28 15:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-08 18:21 [PATCH 1/2] dts: introduce abstract class for TG and SUT DPDK runtime environments Andrew Bailey
2025-08-08 18:21 ` [PATCH 2/2] dts: enable port binding on the TG Andrew Bailey
2025-08-28 12:37 ` [PATCH v3] " Andrew Bailey
2025-08-28 12:50 ` Luca Vizzarro
2025-08-28 15:17 ` Andrew Bailey [this message]
2025-08-28 12:54 ` Patrick Robb
2025-08-11 11:17 ` [PATCH 1/2] dts: introduce abstract class for TG and SUT DPDK runtime environments Luca Vizzarro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABJ3N2UY2N3dGL-Zj97RX5Vqs8pNcCHugUbCG=QmQeT_52CU=g@mail.gmail.com' \
--to=abailey@iol.unh.edu \
--cc=dev@dpdk.org \
--cc=dmarx@iol.unh.edu \
--cc=luca.vizzarro@arm.com \
--cc=probb@iol.unh.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).