Re: [RFC PATCH 3/3] dts: add cryptodev testsuite

[Andrew Bailey <abailey@iol.unh.edu>]

[-- Attachment #1: Type: text/plain, Size: 1523 bytes --]

>
>
> +            print(f"Skipping test: {e}")
>> +            raise
>> +        app.print_stats(results)
>> +        self._verify_throughput(results)
>> +
>> +    @func_test
>> +    def openssl_aead_aes_gcm_encrypt(self) -> None:
>> +        """Basic test to run on all NICs with openssl virtual device.
>>
>
> I don't know about the description above because the testing is being run
> on the vdev, not any NIC (which really isn't involved in the test).
>
> I see from DPDK docs that crypto_openssl vdev supports aead aes-gcm, but
> so do the physical devices, and you have a separate QAT case like the
> openssl one above (and maybe this is a good solution). Is the idea to have
> a testcase per device (physical or virtual) per algo?
> https://doc.dpdk.org/guides-25.11/cryptodevs/overview.html#supported-aead-algorithms
>

      The idea as of currently was to go through every run of the cryptodev
application that I saw in old DTS and make a test case per run of the app.
The openssl test case was for development and can be ignored, which I
failed to note in my submission. There are runs for virtual devices that I
plan to include within this testsuite by the end of it and each will have
its own test case.

>
>
>> +    @func_test
>
> +    def a_wrong_devtype(self) -> None:
>>
>
> Can you explain the name of this test and its purpose?
>

        The last 3 test cases can be ignored as I made them for debugging
purposes in development. I simply forgot to              remove them prior
to my submission.

>
>

[-- Attachment #2: Type: text/html, Size: 2958 bytes --]