DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH 0/2] Small formatting issue fixes in DTS
@ 2025-11-13 23:29 Patrick Robb
  2025-11-13 23:29 ` [PATCH 1/2] dts: fix incorrect import order for RSS testsuite Patrick Robb
  2025-11-13 23:29 ` [PATCH 2/2] dts: shorten a too long line Patrick Robb
  0 siblings, 2 replies; 5+ messages in thread
From: Patrick Robb @ 2025-11-13 23:29 UTC (permalink / raw)
  To: luca.vizzarro; +Cc: dev, thomas, david.marchand, Patrick Robb

There are a few formatting issues in DTS which are being
reported by the devtools dts-check-format script. The 2
commits in this series should resolve these issues.

Patrick Robb (2):
  dts: fix incorrect import order for RSS testsuite
  dts: shorten a too long line

 dts/api/testpmd/__init__.py    | 2 +-
 dts/tests/TestSuite_pmd_rss.py | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.49.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/2] dts: fix incorrect import order for RSS testsuite
  2025-11-13 23:29 [PATCH 0/2] Small formatting issue fixes in DTS Patrick Robb
@ 2025-11-13 23:29 ` Patrick Robb
  2025-11-18 14:34   ` Andrew Bailey
  2025-11-13 23:29 ` [PATCH 2/2] dts: shorten a too long line Patrick Robb
  1 sibling, 1 reply; 5+ messages in thread
From: Patrick Robb @ 2025-11-13 23:29 UTC (permalink / raw)
  To: luca.vizzarro; +Cc: dev, thomas, david.marchand, Patrick Robb

Fix the order of the imports on the RSS testsuite such that
the dts check format script is no longer reporting issues.

Fixes: 367e950f6d24 ("dts: add RSS test suite")

Signed-off-by: Patrick Robb <probb@iol.unh.edu>
---
 dts/tests/TestSuite_pmd_rss.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dts/tests/TestSuite_pmd_rss.py b/dts/tests/TestSuite_pmd_rss.py
index 80f6e310ae..f6adf262c3 100644
--- a/dts/tests/TestSuite_pmd_rss.py
+++ b/dts/tests/TestSuite_pmd_rss.py
@@ -20,8 +20,8 @@
     requires_link_topology,
     requires_nic_capability,
 )
-from api.test import verify
 from api.packet import send_packets_and_capture
+from api.test import verify
 from api.testpmd import TestPmd
 from api.testpmd.config import SimpleForwardingModes
 from api.testpmd.types import (
-- 
2.49.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 2/2] dts: shorten a too long line
  2025-11-13 23:29 [PATCH 0/2] Small formatting issue fixes in DTS Patrick Robb
  2025-11-13 23:29 ` [PATCH 1/2] dts: fix incorrect import order for RSS testsuite Patrick Robb
@ 2025-11-13 23:29 ` Patrick Robb
  2025-11-18 14:34   ` Andrew Bailey
  1 sibling, 1 reply; 5+ messages in thread
From: Patrick Robb @ 2025-11-13 23:29 UTC (permalink / raw)
  To: luca.vizzarro; +Cc: dev, thomas, david.marchand, Patrick Robb

Bring a line which is too long under 100 characters, which
is the limit.

Fixes: f6fb8c6238db ("dts: add link check on testpmd port start")

Signed-off-by: Patrick Robb <probb@iol.unh.edu>
---
 dts/api/testpmd/__init__.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dts/api/testpmd/__init__.py b/dts/api/testpmd/__init__.py
index b6f5a8f0da..e98f882b14 100644
--- a/dts/api/testpmd/__init__.py
+++ b/dts/api/testpmd/__init__.py
@@ -96,7 +96,7 @@ def _requires_started_ports(func: TestPmdMethod) -> TestPmdMethod:
         func: The :class:`TestPmd` method to decorate.
 
     Raises:
-        InteractiveCommandExecutionError: If the ports has been started but a port link will not come up.
+        InteractiveCommandExecutionError: If ports have been started but the link won't come up.
     """
 
     @functools.wraps(func)
-- 
2.49.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] dts: fix incorrect import order for RSS testsuite
  2025-11-13 23:29 ` [PATCH 1/2] dts: fix incorrect import order for RSS testsuite Patrick Robb
@ 2025-11-18 14:34   ` Andrew Bailey
  0 siblings, 0 replies; 5+ messages in thread
From: Andrew Bailey @ 2025-11-18 14:34 UTC (permalink / raw)
  To: Patrick Robb; +Cc: luca.vizzarro, dev, thomas, david.marchand

[-- Attachment #1: Type: text/plain, Size: 1025 bytes --]

Reviewed-by: Andrew Bailey <abailey@iol.unh.edu>

On Thu, Nov 13, 2025 at 6:31 PM Patrick Robb <probb@iol.unh.edu> wrote:

> Fix the order of the imports on the RSS testsuite such that
> the dts check format script is no longer reporting issues.
>
> Fixes: 367e950f6d24 ("dts: add RSS test suite")
>
> Signed-off-by: Patrick Robb <probb@iol.unh.edu>
> ---
>  dts/tests/TestSuite_pmd_rss.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dts/tests/TestSuite_pmd_rss.py
> b/dts/tests/TestSuite_pmd_rss.py
> index 80f6e310ae..f6adf262c3 100644
> --- a/dts/tests/TestSuite_pmd_rss.py
> +++ b/dts/tests/TestSuite_pmd_rss.py
> @@ -20,8 +20,8 @@
>      requires_link_topology,
>      requires_nic_capability,
>  )
> -from api.test import verify
>  from api.packet import send_packets_and_capture
> +from api.test import verify
>  from api.testpmd import TestPmd
>  from api.testpmd.config import SimpleForwardingModes
>  from api.testpmd.types import (
> --
> 2.49.0
>
>

[-- Attachment #2: Type: text/html, Size: 1504 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] dts: shorten a too long line
  2025-11-13 23:29 ` [PATCH 2/2] dts: shorten a too long line Patrick Robb
@ 2025-11-18 14:34   ` Andrew Bailey
  0 siblings, 0 replies; 5+ messages in thread
From: Andrew Bailey @ 2025-11-18 14:34 UTC (permalink / raw)
  To: Patrick Robb; +Cc: luca.vizzarro, dev, thomas, david.marchand

[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]

Reviewed-by: Andrew Bailey <abailey@iol.unh.edu>


On Thu, Nov 13, 2025 at 6:31 PM Patrick Robb <probb@iol.unh.edu> wrote:

> Bring a line which is too long under 100 characters, which
> is the limit.
>
> Fixes: f6fb8c6238db ("dts: add link check on testpmd port start")
>
> Signed-off-by: Patrick Robb <probb@iol.unh.edu>
> ---
>  dts/api/testpmd/__init__.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dts/api/testpmd/__init__.py b/dts/api/testpmd/__init__.py
> index b6f5a8f0da..e98f882b14 100644
> --- a/dts/api/testpmd/__init__.py
> +++ b/dts/api/testpmd/__init__.py
> @@ -96,7 +96,7 @@ def _requires_started_ports(func: TestPmdMethod) ->
> TestPmdMethod:
>          func: The :class:`TestPmd` method to decorate.
>
>      Raises:
> -        InteractiveCommandExecutionError: If the ports has been started
> but a port link will not come up.
> +        InteractiveCommandExecutionError: If ports have been started but
> the link won't come up.
>      """
>
>      @functools.wraps(func)
> --
> 2.49.0
>
>

[-- Attachment #2: Type: text/html, Size: 1595 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-11-18 14:34 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-13 23:29 [PATCH 0/2] Small formatting issue fixes in DTS Patrick Robb
2025-11-13 23:29 ` [PATCH 1/2] dts: fix incorrect import order for RSS testsuite Patrick Robb
2025-11-18 14:34   ` Andrew Bailey
2025-11-13 23:29 ` [PATCH 2/2] dts: shorten a too long line Patrick Robb
2025-11-18 14:34   ` Andrew Bailey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).