From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-la0-f49.google.com (mail-la0-f49.google.com [209.85.215.49]) by dpdk.org (Postfix) with ESMTP id 6D90CC362 for ; Thu, 9 Jul 2015 15:46:25 +0200 (CEST) Received: by laar3 with SMTP id r3so247099543laa.0 for ; Thu, 09 Jul 2015 06:46:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=cGrEKAlIgGR6fPSt0KLpUmEvmm/1MYlpgXGJdXUSwDY=; b=uJQ236HOr93ed18naHYSEAqEyvOU1AUOqC3YHDmr/YCwubKW0QbZ434f0LLqNC3gik j93JUAPD7TFrd+NjXdk6Zs9QbS2VeMdNy+WAITGQP42abmTFEQQBVudAWGpMJ7G1yr2L dAZTDKYr65Kun7JlbidQlmfF/gxbQeJc1+O5OePkfIPAJXAaO0wTUVqNhyOZOuK1jxkE Oz29Q3YuZcqSu+shjF9U6ANOAP4J7XVRa+mcfzLAr0OKXHhW67kV4PUeB57OUyP69NZ3 6T9zqbPogxmi8J/XxZtpmZht9wZxyuRbM90OoQxwLBSgnNMDoX8794XOE3NZbiiQZckF K+WQ== MIME-Version: 1.0 X-Received: by 10.152.43.37 with SMTP id t5mr14689560lal.96.1436449585024; Thu, 09 Jul 2015 06:46:25 -0700 (PDT) Received: by 10.25.127.3 with HTTP; Thu, 9 Jul 2015 06:46:24 -0700 (PDT) In-Reply-To: <1436448159-8394-1-git-send-email-bruce.richardson@intel.com> References: <1436448159-8394-1-git-send-email-bruce.richardson@intel.com> Date: Thu, 9 Jul 2015 09:46:24 -0400 Message-ID: From: Eduard Gibert To: "dev@dpdk.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] mbuf: clarify comment on adding TX offload flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jul 2015 13:46:25 -0000 Hello, I am trying to run any DPDK application in my machine but I'm unable to do so because it always hangs after the print "EAL: Setting up memory.." That applies to all of the DPDK applications. Anyone has any ideas on why this is happening? Thanks, Eduard Gibert Renart 2015-07-09 9:22 GMT-04:00 Bruce Richardson : > The comment for TX offload flags stated that those flags started at bit > 55 and then were added to the right of that, leaving 8 bits reserved for > generic mbuf (i.e. non-offload) use. This comment may not have been > clear as 5 of the 8 flags which were reserved have now been used for TX > offloads. > This patch: > * updates the description so that it now reflects reality that > only three flags are available for generic mbuf use > * reserved the final generic flag so that it can't be taken over for TX > offload in future > * clarifies the comment for TX flags to indicate that they should be > counting downwards not upwards. > > Signed-off-by: Bruce Richardson > --- > lib/librte_mbuf/rte_mbuf.h | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h > index 80419df..0c0034b 100644 > --- a/lib/librte_mbuf/rte_mbuf.h > +++ b/lib/librte_mbuf/rte_mbuf.h > @@ -75,9 +75,10 @@ extern "C" { > * > * - RX flags start at bit position zero, and get added to the left of > previous > * flags. > - * - The most-significant 8 bits are reserved for generic mbuf flags > - * - TX flags therefore start at bit position 55 (i.e. 63-8), and new > flags get > - * added to the right of the previously defined flags > + * - The most-significant 3 bits are reserved for generic mbuf flags > + * - TX flags therefore start at bit position 60 (i.e. 63-3), and new > flags get > + * added to the right of the previously defined flags i.e. they should > count > + * downwards, not upwards. > * > * Keep these flags synchronized with rte_get_rx_ol_flag_name() and > * rte_get_tx_ol_flag_name(). > @@ -197,6 +198,8 @@ extern "C" { > */ > #define PKT_TX_OUTER_IPV6 (1ULL << 60) > > +#define __RESERVED (1ULL << 61) /**< reserved for future mbuf > use */ > + > #define IND_ATTACHED_MBUF (1ULL << 62) /**< Indirect attached mbuf */ > > /* Use final bit of flags to indicate a control mbuf */ > -- > 2.4.3 > >