DPDK patches and discussions
 help / color / mirror / Atom feed
From: Gopakumar Choorakkot Edakkunni <gopakumar.c.e@gmail.com>
To: huawei.xie@intel.com, dev@dpdk.org
Subject: [dpdk-dev] Bug in virtqueue_dequeue_burst_rx()
Date: Mon, 19 Dec 2016 21:59:33 -0800	[thread overview]
Message-ID: <CABK1yFBkaePG37Qd2ebobgJtdeVMj1uNZi5szprFkfyZ5CFZuw@mail.gmail.com> (raw)

While I was testing virtio with ubuntu 14.04 kvm as host and dpdk16.07
linux as guest, quite often I have seen that I get into a situation where
virtio_recv_mergeable_pkts() gets into a forever loop, after sending
traffic for a while. In the below API,  I see that it clearly leads to a
while loop, I am not quite familiar with virtio or mergeable buffers, so
thought of checking with dpdk alias on the intent here.

I checked the linux kernel virtio_net.c file which does the similar
mergeable recieve, and the kernel code breaks out in case of error.
Shouldnt dpdk be breaking out of here on error instead of continue ?

virtio_recv_mergeable_pkts()
{
<snip>
    while (i < nb_used) {
        <snip>
*        num = virtqueue_dequeue_burst_rx(rxvq, rcv_pkts, len, 1);*
*        if (num != 1)*
*            continue;*
       <snip>
    }
<snip?
}

Rgds,
Gopa.

             reply	other threads:[~2016-12-20  5:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-20  5:59 Gopakumar Choorakkot Edakkunni [this message]
2016-12-22  7:38 ` Yuanhan Liu
2017-01-09  9:38   ` Gopakumar Choorakkot Edakkunni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABK1yFBkaePG37Qd2ebobgJtdeVMj1uNZi5szprFkfyZ5CFZuw@mail.gmail.com \
    --to=gopakumar.c.e@gmail.com \
    --cc=dev@dpdk.org \
    --cc=huawei.xie@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).