From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F131A034C; Mon, 24 Oct 2022 14:55:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F0A754069C; Mon, 24 Oct 2022 14:55:04 +0200 (CEST) Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by mails.dpdk.org (Postfix) with ESMTP id A094940695 for ; Mon, 24 Oct 2022 14:55:03 +0200 (CEST) Received: by mail-ed1-f51.google.com with SMTP id m16so30740215edc.4 for ; Mon, 24 Oct 2022 05:55:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=dpPrPvLPZ0hQymeXfhHZuEHrGw45PX8J5Tz4pIYyjkw=; b=AFRDX7O6kpHUqxMtfVEPk2gnW7lUUuZV7d0FhOUb+R1knuTXKnYGgs44lpTEfdTp3p qrWhT19V990BHu92+UrA8Ik4/pvUuE+yiCsIKgkBciMfOdTZmlE4jrzqk0wjrflGfra2 Ydac1KuP0lwJRFZSEtEraWIsrXa2UAS2PYULwS1wEqLNj+n4vsMZHfYl2K1afEqnENZQ fTw95HipZlocDnuRQiMgA/oZZaDer6EY0LEXktAVA9dZJslLpn/pU8p9bfWEFaJqUEkg 9bzC2ZzRNmZTxA6yNv5o0pSlYLcM4x19di1bdW0Ay5HZVOw2MPMZWm87eHyw4c4tLpvX JbCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dpPrPvLPZ0hQymeXfhHZuEHrGw45PX8J5Tz4pIYyjkw=; b=sMst/Zg0NEl0dX+PCGAUWLCoyyvIKSW3wKtS9FdIm9JjIojtrJeXxkUzS6hjHvpJTA 22AJzC59hyfUQx0yT6cIGoeNcmSgTwza5Uye4ULoe0kLFH4+I5Fvn4pTEVvmNstrGzZ+ jq5mq157OXu1mcX7XLS1N1STXwD1jDzviv3TIibErzQwDiSbccIZ2oGcc8DfPGYH4FA9 iA0Yb8pgqZ+SVvbGDAqGkJZs8NWOVwDMktP7crwJYgUOsHRtLot80oJqCD4WTmtJ3AYt /GXlJD+XzndcUIPqDpdWku/fy2NxOFXGTVZCk8tXWxDZyTbHOJfJGT9sICImVdySh0bs KLkA== X-Gm-Message-State: ACrzQf2bP5oWadUDMLVFgcntrWRE5EuPJBNHiMa3/L6JktHGye2bPPsK vX3mTOsF2BTfX0iJusLI/Kr+2EKBWA/bARV82bvx1g== X-Google-Smtp-Source: AMsMyM72IRo2EpGIjIdg+Nssd/8RIHMNqlcP8lY/l0DhqMPdUqjaDYXcBldjI0qx30XM7KXqy2mYgTHEDzuPtPY4YwQ= X-Received: by 2002:a17:907:7fa5:b0:791:9a5f:101a with SMTP id qk37-20020a1709077fa500b007919a5f101amr27354746ejc.453.1666616103233; Mon, 24 Oct 2022 05:55:03 -0700 (PDT) MIME-Version: 1.0 References: <20221019125753.1700071-1-zhangfei.gao@linaro.org> In-Reply-To: From: Zhangfei Gao Date: Mon, 24 Oct 2022 20:54:51 +0800 Message-ID: Subject: Re: [EXT] [PATCH v4 0/6] crypto/uadk: introduce uadk crypto driver To: Akhil Goyal Cc: Declan Doherty , Fan Zhang , Ashish Gupta , Ray Kinsella , "dev@dpdk.org" , "acc@openeuler.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 20 Oct 2022 at 22:46, Akhil Goyal wrote: > > > Introduce a new crypto PMD for hardware accelerators based on UADK [1]. > > > > UADK is a framework for user applications to access hardware accelerato= rs. > > UADK relies on IOMMU SVA (Shared Virtual Address) feature, which share > > the same page table between IOMMU and MMU. > > Thereby user application can directly use virtual address for device dm= a, > > which enhances the performance as well as easy usability. > > > > [1] https://urldefense.proofpoint.com/v2/url?u=3Dhttps- > > 3A__github.com_Linaro_uadk&d=3DDwIDAg&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DDn > > L7Si2wl_PRwpZ9TWey3eu68gBzn7DkPwuqhd6WNyo&m=3DAkCizMeraG64B9u- > > h4gp5S2CYP3SiD5dpvFqvj2WHC4Cfuw6TbzZSeCk1Ryz-qLo&s=3DTm7UGDJ- > > 3QUjCzOkIRUG_tjJA3ckOdK6kSOxuk7V5PQ&e=3D > > > > Test: > > sudo dpdk-test --vdev=3Dcrypto_uadk (--log-level=3D6) > > RTE>>cryptodev_uadk_autotest > > RTE>>quit > > > > Update in v4: > > Akril suggest dpdk use pkg-config, So > > Enable uadk support x86 local build, and support pkg-config. > > Use pkg-config feature for the uadk crypto pmd. > > Add build uadk library steps in doc > > Test on both x86 and arm. > > x86 can build and install, but can not test since no device. > > > I tried with the latest TOT of UADK. This resolved the openssl issue. > But it does not allow me to install UADK into a specific directory. > It installs /usr/local/lib only. > And what is the use of pkg-config if I cannot use a specific directory > To install the libs and headers. > > And even if I install at default location, I am seeing below errors while= compiling DPDK > > [2453/3738] Compiling C object 'drivers/a715181@@tmp_rte_crypto_uadk@sta/= crypto_uadk_uadk_crypto_pmd.c.o'. > FAILED: drivers/a715181@@tmp_rte_crypto_uadk@sta/crypto_uadk_uadk_crypto_= pmd.c.o > ccache cc -Idrivers/a715181@@tmp_rte_crypto_uadk@sta -Idrivers -I../drive= rs -Idrivers/crypto/uadk -I../drivers/crypto/uadk -Ilib/cryptodev -I../lib/= cryptodev -I. -I../ -Iconfig -I../config -Ilib/eal/include -I../lib/eal/inc= lude -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/x86/inclu= de -I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal = -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/telemetry/../metrics -I../l= ib/telemetry/../metrics -Ilib/telemetry -I../lib/telemetry -Ilib/mbuf -I../= lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/rcu = -I../lib/rcu -Idrivers/bus/vdev -I../drivers/bus/vdev -I/usr/local/include = -fdiagnostics-color=3Dalways -pipe -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid= -pch -Wextra -O3 -include rte_config.h -Wcast-qual -Wdeprecated -Wformat -W= format-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-protot= ypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare= -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-member = -Wno-packed-not-aligned -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC= -march=3Dnative -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-= truncation -DRTE_LOG_DEFAULT_LOGTYPE=3Dpmd.crypto.uadk -MD -MQ 'drivers/a71= 5181@@tmp_rte_crypto_uadk@sta/crypto_uadk_uadk_crypto_pmd.c.o' -MF 'drivers= /a715181@@tmp_rte_crypto_uadk@sta/crypto_uadk_uadk_crypto_pmd.c.o.d' -o 'dr= ivers/a715181@@tmp_rte_crypto_uadk@sta/crypto_uadk_uadk_crypto_pmd.c.o' -c = ../drivers/crypto/uadk/uadk_crypto_pmd.c > ../drivers/crypto/uadk/uadk_crypto_pmd.c:9:10: fatal error: rte_comp.h: N= o such file or directory > 9 | #include > | ^~~~~~~~~~~~ > compilation terminated. > > ninja: Entering directory `build' > [65/1253] Compiling C object 'drivers/a715181@@tmp_rte_crypto_uadk@sta/cr= ypto_uadk_uadk_crypto_pmd.c.o'. > FAILED: drivers/a715181@@tmp_rte_crypto_uadk@sta/crypto_uadk_uadk_crypto_= pmd.c.o > ccache cc -Idrivers/a715181@@tmp_rte_crypto_uadk@sta -Idrivers -I../drive= rs -Idrivers/crypto/uadk -I../drivers/crypto/uadk -Ilib/cryptodev -I../lib/= cryptodev -I. -I../ -Iconfig -I../config -Ilib/eal/include -I../lib/eal/inc= lude -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/x86/inclu= de -I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal = -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/telemetry/../metrics -I../l= ib/telemetry/../metrics -Ilib/telemetry -I../lib/telemetry -Ilib/mbuf -I../= lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/rcu = -I../lib/rcu -Idrivers/bus/vdev -I../drivers/bus/vdev -I/usr/local/include = -fdiagnostics-color=3Dalways -pipe -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid= -pch -Wextra -O3 -include rte_config.h -Wcast-qual -Wdeprecated -Wformat -W= format-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-protot= ypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare= -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-member = -Wno-packed-not-aligned -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC= -march=3Dnative -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-= truncation -DRTE_LOG_DEFAULT_LOGTYPE=3Dpmd.crypto.uadk -MD -MQ 'drivers/a71= 5181@@tmp_rte_crypto_uadk@sta/crypto_uadk_uadk_crypto_pmd.c.o' -MF 'drivers= /a715181@@tmp_rte_crypto_uadk@sta/crypto_uadk_uadk_crypto_pmd.c.o.d' -o 'dr= ivers/a715181@@tmp_rte_crypto_uadk@sta/crypto_uadk_uadk_crypto_pmd.c.o' -c = ../drivers/crypto/uadk/uadk_crypto_pmd.c > ../drivers/crypto/uadk/uadk_crypto_pmd.c:11:10: fatal error: uadk/wd_ciph= er.h: No such file or directory > 11 | #include > We originally install header file under uadk folder, like /usr/local/include/uadk/xx.h After switch to pkgconfig, the uadk is removed, like /usr/local/include/xx.= h After re-thinking, we still think using the folder uadk will be better and cleaner, without polluting the system, like openssl, also for back-compatibility. So fix the uadk lib by using pkginclude_HEADERS and nobase_pkginclude_HEADERS accordingly. Thanks