From: Zhangfei Gao <zhangfei.gao@linaro.org>
To: Konstantin Ananyev <konstantin.ananyev@huawei.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Akhil Goyal <gakhil@marvell.com>,
Fan Zhang <fanzhang.oss@gmail.com>,
Ashish Gupta <ashish.gupta@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH 1/3] compress/uadk: Introduce UADK compression driver
Date: Fri, 24 May 2024 17:43:31 +0800 [thread overview]
Message-ID: <CABQgh9F=vPbz00JTPnM_KM+6V58Jae+TNac=rNgNxWTARVR9+w@mail.gmail.com> (raw)
In-Reply-To: <d6404d49b88245e9ba19db8e7c8c6103@huawei.com>
On Fri, 24 May 2024 at 00:30, Konstantin Ananyev
<konstantin.ananyev@huawei.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Stephen Hemminger <stephen@networkplumber.org>
> > Sent: Thursday, May 23, 2024 5:21 PM
> > To: Zhangfei Gao <zhangfei.gao@linaro.org>
> > Cc: Akhil Goyal <gakhil@marvell.com>; Fan Zhang <fanzhang.oss@gmail.com>; Ashish Gupta <ashish.gupta@marvell.com>;
> > dev@dpdk.org
> > Subject: Re: [PATCH 1/3] compress/uadk: Introduce UADK compression driver
> >
> > On Mon, 22 Apr 2024 14:31:00 +0000
> > Zhangfei Gao <zhangfei.gao@linaro.org> wrote:
> >
> > > +static struct rte_compressdev_ops uadk_compress_pmd_ops = {
> > > + .dev_configure = NULL,
> > > + .dev_start = NULL,
> > > + .dev_stop = NULL,
> > > + .dev_close = NULL,
> > > + .stats_get = NULL,
> > > + .stats_reset = NULL,
> > > + .dev_infos_get = NULL,
> > > + .queue_pair_setup = NULL,
> > > + .queue_pair_release = NULL,
> > > + .private_xform_create = NULL,
> > > + .private_xform_free = NULL,
> > > + .stream_create = NULL,
> > > + .stream_free = NULL,
> > > +};
> >
> > If you just used { } then all the elements are initialized to NULL anyway
>
> Or even
> static struct rte_compressdev_ops uadk_compress_pmd_ops;
> should do the same.
Yes, good idea
Thanks Konstantin
next prev parent reply other threads:[~2024-05-24 9:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 14:30 [PATCH 0/3] " Zhangfei Gao
2024-04-22 14:31 ` [PATCH 1/3] compress/uadk: " Zhangfei Gao
2024-05-23 16:20 ` Stephen Hemminger
2024-05-23 16:30 ` Konstantin Ananyev
2024-05-23 16:42 ` Tyler Retzlaff
2024-05-24 9:43 ` Zhangfei Gao [this message]
2024-04-22 14:31 ` [PATCH 2/3] compress/uadk: support basic operations Zhangfei Gao
2024-05-23 15:38 ` [EXTERNAL] " Akhil Goyal
2024-05-24 10:01 ` Zhangfei Gao
2024-05-24 10:20 ` Akhil Goyal
2024-05-24 14:45 ` Zhangfei Gao
2024-05-24 14:54 ` Akhil Goyal
2024-04-22 14:31 ` [PATCH 3/3] compress/uadk: support burst enqueue/dequeue Zhangfei Gao
2024-05-11 3:05 ` [PATCH 0/3] Introduce UADK compression driver Zhangfei Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABQgh9F=vPbz00JTPnM_KM+6V58Jae+TNac=rNgNxWTARVR9+w@mail.gmail.com' \
--to=zhangfei.gao@linaro.org \
--cc=ashish.gupta@marvell.com \
--cc=dev@dpdk.org \
--cc=fanzhang.oss@gmail.com \
--cc=gakhil@marvell.com \
--cc=konstantin.ananyev@huawei.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).