From: Sarosh Arif <sarosh.arif@emumba.com>
To: David Marchand <david.marchand@redhat.com>
Cc: David Hunt <david.hunt@intel.com>,
Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>,
dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [v3 PATCH] test_distributor: prevent memory leakages from the pool
Date: Mon, 28 Sep 2020 14:55:06 +0500 [thread overview]
Message-ID: <CABoZmYNHaOZVBTi11nNeva-=hU91MbgEq_6ukssUSx1o9T9zMA@mail.gmail.com> (raw)
In-Reply-To: <CAJFAV8zU-4ZWx4Q0vOWja6KNfubZ0ow+1_UtUSrihd+FQffqSg@mail.gmail.com>
On Fri, Sep 25, 2020 at 7:22 PM David Marchand <david.marchand@redhat.com>
wrote:
> On Tue, Sep 8, 2020 at 12:22 PM Sarosh Arif <sarosh.arif@emumba.com>
> wrote:
> >
> > rte_mempool_get_bulk is used to get bufs/many_bufs from the pool,
> > but at some locations when test fails the bufs/many_bufs are
> > not returned back to the pool.
> > Due to this, multiple executions of distributor_autotest gives the
> > following error message: Error getting mbufs from pool.
> > To resolve this issue rte_mempool_put_bulk is used whenever the test
> > fails and returns.
> >
> > Signed-off-by: Sarosh Arif <sarosh.arif@emumba.com>
>
> It deserves a Fixes: line.
>
Fixes: c3eabff124e6 ("distributor: add unit tests")
Should I submit another version of this patch to add fixes?
>
> I can see a ack from Lukasz.
> David, review please?
>
>
> --
> David Marchand
>
>
next prev parent reply other threads:[~2020-09-28 9:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200413092039eucas1p1372014e18d014115634fc8eb23508004@eucas1p1.samsung.com>
2020-04-13 9:19 ` [dpdk-dev] [PATCH] test_distributor.c: " Sarosh Arif
2020-04-15 1:15 ` Lukasz Wojciechowski
2020-04-15 6:42 ` [dpdk-dev] [PATCH v2] app/test/test_distributor.c: " Sarosh Arif
2020-04-15 6:52 ` Lukasz Wojciechowski
2020-04-15 7:06 ` Sarosh Arif
2020-04-15 7:08 ` Lukasz Wojciechowski
[not found] ` <CABoZmYPV-GXESgjey7-g-j=cNif38O-SZ4L7TfrDTwb6KfDsog@mail.gmail.com>
[not found] ` <CABoZmYOhpYqV07Q4JguvSwJmAPzfhO-f8fMKUzsMoUdUGU5hjQ@mail.gmail.com>
2020-06-24 10:02 ` Sarosh Arif
2020-09-01 18:31 ` Lukasz Wojciechowski
2020-09-08 10:22 ` [dpdk-dev] [v3 PATCH] test_distributor: " Sarosh Arif
2020-09-16 19:01 ` Lukasz Wojciechowski
2020-09-25 14:22 ` David Marchand
2020-09-25 15:31 ` David Hunt
2020-09-28 9:55 ` Sarosh Arif [this message]
2020-09-28 10:14 ` David Marchand
2020-09-25 15:26 ` David Hunt
2020-10-19 8:34 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABoZmYNHaOZVBTi11nNeva-=hU91MbgEq_6ukssUSx1o9T9zMA@mail.gmail.com' \
--to=sarosh.arif@emumba.com \
--cc=david.hunt@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=l.wojciechow@partner.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).