From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C4AA6A0350; Tue, 23 Jun 2020 11:19:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 992DD1D5ED; Tue, 23 Jun 2020 11:19:31 +0200 (CEST) Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by dpdk.org (Postfix) with ESMTP id A3F4C1D5B4 for ; Tue, 23 Jun 2020 11:19:29 +0200 (CEST) Received: by mail-io1-f68.google.com with SMTP id q8so22788568iow.7 for ; Tue, 23 Jun 2020 02:19:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emumba-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=NozMFdQKkFbmUqJZsietjosy3EYPi1qlH3SMDp70DcA=; b=u/yDfsjgCxanoVz/MYbn4t9I3Exw8fgFZyZh4McMzRNqfoD0qgoE4kDL2YMm0yRxMh 20zkjnRFy6f13YokOr5SP/NjxeXXUbL2L1iByZfrypzNvpIROj/dS1Os8VbliP2sa1NH XSdYgUk11RADg7ChfsqlTBDGSL3Vp34dQ+FrGu7HYODi3lZyQthvsTKSTmWC8cfdhDLw /Lgb5ZBh/gCmbTTO+zwEoj273XVZY9JaiH+rYsXRqTR9GFNM+WD/uFIaIqcsNQhFXBy9 ruYgSBw8J1LpAYrN0IxltipcaoTkG6bKLCe4cynvqU3WEGuMN5eYHqJCbvmXVuL+Gj+5 X4vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=NozMFdQKkFbmUqJZsietjosy3EYPi1qlH3SMDp70DcA=; b=T/vmSqi4zL/Xt+wg1+jG7UrD3fml3T8jB8W2F3tntDqnW6gBXftkujbCqZqqXgEJcK 9LpvYrUN7pNXUAlGI1WAozwr9tx5OJBnSfEU6qvMq69qmGzB3H9mUcKy9DOQeTe9HFTH ZtLvVTQkal6cUWfaKdnbOMsM8L2EZqV2gzwVa0Oe4RnLTzuzMLZIkAYi1rfxBFaQhh8J 7leqyJ/4y1pFBH3XbvoBhzfezxq+R3pMjCMHQnGlGiJy0PA9RfokqhgmFL7sWzfDEhdn 9ty4RWDWRWXHgHgRogVx0dZB3AE7absIEz9hTrdNvNXJybBHvw+RSbERF7UHaG+nJZ+o 7kVQ== X-Gm-Message-State: AOAM533XnkHUyPPtOw4y0uyJRgr0MF4MVMB8A2M6beGPiWTbakqlA41V ALhi5LQn2CbxNfqUIQpfe8QGydPMVOFs49vPI8FILeGOJlw= X-Google-Smtp-Source: ABdhPJw/t0DWvizW5qrTGA/YAzp9e1uGZ1N+AXaCMh/uIO/u3lhH4oKNSpr1WKaM+YRIittREqJBNwHcIYcTGriJfKs= X-Received: by 2002:a6b:9042:: with SMTP id s63mr16178547iod.195.1592903968804; Tue, 23 Jun 2020 02:19:28 -0700 (PDT) MIME-Version: 1.0 References: <20200605114828.20372-1-sarosh.arif@emumba.com> In-Reply-To: <20200605114828.20372-1-sarosh.arif@emumba.com> From: Sarosh Arif Date: Tue, 23 Jun 2020 14:19:17 +0500 Message-ID: To: dev@dpdk.org, reshma.pattan@intel.com Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] examples/packet_ordering: Use rte_exit in case of invalid EAL or application arguments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello, This patch has been sitting around for more than 3 weeks. Is there something that needs to be done further for acceptance? Regards, Sarosh On Fri, Jun 5, 2020 at 4:49 PM Sarosh Arif wrote: > rte_exit should be called when the application exits due to > invalid EAL or application arguments. > > Fixes: 850f3733f840 ("examples/packet_ordering: new sample app") > Cc: sergio.gonzalez.monroy@intel.com > > Signed-off-by: Sarosh Arif > --- > examples/packet_ordering/main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/examples/packet_ordering/main.c > b/examples/packet_ordering/main.c > index b397b318e..edaf810d9 100644 > --- a/examples/packet_ordering/main.c > +++ b/examples/packet_ordering/main.c > @@ -675,7 +675,7 @@ main(int argc, char **argv) > /* Initialize EAL */ > ret = rte_eal_init(argc, argv); > if (ret < 0) > - return -1; > + rte_exit(EXIT_FAILURE, "Invalid EAL arguments\n"); > > argc -= ret; > argv += ret; > @@ -683,7 +683,7 @@ main(int argc, char **argv) > /* Parse the application specific arguments */ > ret = parse_args(argc, argv); > if (ret < 0) > - return -1; > + rte_exit(EXIT_FAILURE, "Invalid packet_ordering > arguments\n"); > > /* Check if we have enought cores */ > if (rte_lcore_count() < 3) > -- > 2.17.1 > >