Re: [PATCH v2] net/memif: default to physical socket

[Nathan Skrzypczak <nathan.skrzypczak@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2205 bytes --]

Hi Stephen, Hi Ferruh,

I don't have a strong opinion on usage of regular sockets vs abstract
sockets. My point is that most existing memif implementations
either don't yet properly support abstract sockets or require extra flags
to be passed by users (iirc VPP, gomemif, libmemif, etc...).
As a matter of fact, abstract socket support in dpdk was broken until quite
recently. So I expect most users to be somewhat
constrained by their implementation to use regular sockets.

Also, as a user when you come with a filesystem path, understanding you
need to pass the following is not really straightforward
--vdev=net_memif,socket=/tmp/memif.sock,socket-abstract=no

A better solution might be to use the '@' prefix which seems the usual
representation and remove the socket-abstract=no altogether
--vdev=net_memif,socket=@memif
--vdev=net_memif,socket=/tmp/memif.sock

What do you think ?

(Also iirc Jakub is not receiving emails on this address)

Cheers
-Nathan

Le mer. 7 déc. 2022 à 22:01, Stephen Hemminger <stephen@networkplumber.org>
a écrit :

> On Wed, 7 Dec 2022 17:15:06 +0000
> Ferruh Yigit <ferruh.yigit@amd.com> wrote:
>
> > On 12/7/2022 3:56 PM, Nathan Skrzypczak wrote:
> > > Hi Ferruh,
> > >
> >
> > Hi Nathan,
> >
> > > Thank you for your reply,
> > >
> > > On the potential confusion for users of the DPDK memif PMD : when
> > > defaulting to abstract sockets was added in [0] (v20.10 release)
> > > it did change the existing behavior, so reverting it would restore the
> > > old behavior.> Also abstract sockets are quite a unusual feature in
> linux (a 0byte
> > > prefixed string...), so I'm expecting most users of memif to just use
> > > regular sockets because they're way easier to handle.
> > >
> >
> > Not sure if regular socket is easier to handle, or users prefer regular
> > sockets, we need more input on these.
>
> Regular sockets are actually harder handle, it is more that users
> are less familiar with them! Regular sockets have to go through
> file permission checks which makes dealing with containers and SELinux
> hard.  Regular sockets persist when application crashes which makes
> recovery harder.
>

[-- Attachment #2: Type: text/html, Size: 2967 bytes --]