From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 46786A0C43;
Thu, 23 Sep 2021 22:38:04 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 0ECAA41260;
Thu, 23 Sep 2021 22:38:04 +0200 (CEST)
Received: from mail-io1-f44.google.com (mail-io1-f44.google.com
[209.85.166.44])
by mails.dpdk.org (Postfix) with ESMTP id 2E53341257;
Thu, 23 Sep 2021 22:38:02 +0200 (CEST)
Received: by mail-io1-f44.google.com with SMTP id h129so9884531iof.1;
Thu, 23 Sep 2021 13:38:02 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
h=mime-version:references:in-reply-to:from:date:message-id:subject:to
:cc; bh=xbrl5nscaloN65sLExsLOu1zUxKe/H+xC3OLhsmgiNs=;
b=VMvIWXvZ8UpnR8DPItbOP/NOr/KV2pP31UmgBqB334Y3K8v4KmOmNC7onlwgZor+qV
tpt19X45R/Hziui0gzpQaUiBBXhcW9ZQtmQqHNg4gQ/vun4j/e2/TpHUSVUdFYRkY0+M
yS7LEG5c4XtGPBUEQn/LJuXiwpu6Uof/7eL6ypUL3ETxuShjANkfJ+w37JSQ1BRiQ5zX
LBwUXqmKB/R2HplihbCHbf1VjKD2ulI5omLVJ4Fjib51YnZHInDUvVq9z0h75NJPvIlc
Lv28/WpBPHsocLFXO/GtuaDPP36Aue9tCtm5LEsaDpCf2hQNCm35ghIO4Rd4f+qhpYvn
lLRA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=xbrl5nscaloN65sLExsLOu1zUxKe/H+xC3OLhsmgiNs=;
b=1NlcKVw8TLEQ7viPfnfw+PMSD/Jg04uEVVE9Mo1qMAYDZ0KhiUZIsv4MiQIf0cGYvn
zw9O4ss66yohO1/qpIilHvW/s+ARPAdHkr3seZE+qplPCJe0Z5VjZRZynLzed5gGrEte
gprQm2Jsnz/MLJvcVXpo1vNPKKknvgxHP1as92ro4G8mAFQPUSp7LU/rleiD6SjymLy7
NcW5zVU0ByT6lHLJ5UghHJIN/Y+g++GaMHG3IxP9GnL8r6HXx79ElyDZ4Ij+zJR11nEu
q8Gy/YI0D52kFetOauenmgiuxDjaM/mFT79hd+5eGWP3eZ/bcj5u9W+vCgD285BfX98g
bfrA==
X-Gm-Message-State: AOAM53384oxhLLz2124DvCuKo7fggAy6r7mVrEnEjxKCZZY/mpr4Dl0U
jbYZimDHCYce1XXuer3X2qLDjX51wiJ0oILwSKsjJyhp76g=
X-Google-Smtp-Source: ABdhPJyuDPfiID2YtqU2/gxFIR2aatJIi03m9+2WpmNMG8oJoCdalG7B5mdm/dC/+jlS0cVEIWIoad7OLrriFRk1SX0=
X-Received: by 2002:a05:6638:2050:: with SMTP id
t16mr5757379jaj.101.1632429481339;
Thu, 23 Sep 2021 13:38:01 -0700 (PDT)
MIME-Version: 1.0
References: <bug-814-3@http.bugs.dpdk.org/>
In-Reply-To: <bug-814-3@http.bugs.dpdk.org/>
From: spyroot <spyroot@gmail.com>
Date: Fri, 24 Sep 2021 00:37:50 +0400
Message-ID: <CABsV3rCizJnHET4S8WyuTdUw1gn0Hwi3p++7dgZv+thZUk1ufg@mail.gmail.com>
To: bugzilla@dpdk.org
Cc: dev@dpdk.org
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
Subject: Re: [dpdk-dev] [Bug 814] Intel PMD both i40 and iavf send
OP_DISABLE_VLAN_STRIPPING and it not mandatory
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
The second issue is in CONFIG_RSS_LUT.
That *VIRTCHNL_OP_CONFIG_RSS_LUT*
<http://code.dpdk.org/dpdk/v20.05/ident/VIRTCHNL_OP_CONFIG_RSS_LUT>; is
optional so if it returns ret it must be handled correctly.
int
*iavf_configure_rss_lut*
<http://code.dpdk.org/dpdk/v20.05/ident/iavf_configure_rss_lut>(struct
*iavf_adapter* <http://code.dpdk.org/dpdk/v20.05/ident/iavf_adapter>
*adapter)
{
struct *iavf_info*
<http://code.dpdk.org/dpdk/v20.05/ident/iavf_info> *vf =
*IAVF_DEV_PRIVATE_TO_VF*
<http://code.dpdk.org/dpdk/v20.05/ident/IAVF_DEV_PRIVATE_TO_VF>(adapter);
struct *virtchnl_rss_lut*
<http://code.dpdk.org/dpdk/v20.05/ident/virtchnl_rss_lut> *rss_lut;
struct *iavf_cmd_info*
<http://code.dpdk.org/dpdk/v20.05/ident/iavf_cmd_info> args;
int len, err = 0;
len = sizeof(*rss_lut) + vf->vf_res->rss_lut_size - 1;
rss_lut = *rte_zmalloc*
<http://code.dpdk.org/dpdk/v20.05/ident/rte_zmalloc>("rss_lut", len,
0);
if (!rss_lut)
return -ENOMEM;
rss_lut->vsi_id = vf->vsi_res->vsi_id;
rss_lut->lut_entries = vf->vf_res->rss_lut_size;
*rte_memcpy*
<http://code.dpdk.org/dpdk/v20.05/ident/rte_memcpy>(rss_lut->lut,
vf->rss_lut, vf->vf_res->rss_lut_size);
args.ops = *VIRTCHNL_OP_CONFIG_RSS_LUT*
<http://code.dpdk.org/dpdk/v20.05/ident/VIRTCHNL_OP_CONFIG_RSS_LUT>;
args.in_args = (*u8*
<http://code.dpdk.org/dpdk/v20.05/ident/u8> *)rss_lut;
args.in_args_size = len;
args.out_buffer = vf->aq_resp;
args.out_size = *IAVF_AQ_BUF_SZ*
<http://code.dpdk.org/dpdk/v20.05/ident/IAVF_AQ_BUF_SZ>;
err = *iavf_execute_vf_cmd*
<http://code.dpdk.org/dpdk/v20.05/ident/iavf_execute_vf_cmd>(adapter,
&args);
if (err)
*PMD_DRV_LOG*
<http://code.dpdk.org/dpdk/v20.05/ident/PMD_DRV_LOG>(ERR,
"Failed to execute command of OP_CONFIG_RSS_LUT");
*rte_free* <http://code.dpdk.org/dpdk/v20.05/ident/rte_free>(rss_lut);
return err;
}
On Fri, Sep 24, 2021 at 12:29 AM <bugzilla@dpdk.org> wrote:
> https://bugs.dpdk.org/show_bug.cgi?id=814
>
> Bug ID: 814
> Summary: Intel PMD both i40 and iavf send
> OP_DISABLE_VLAN_STRIPPING and it not mandatory
> Product: DPDK
> Version: 20.11
> Hardware: All
> OS: All
> Status: UNCONFIRMED
> Severity: normal
> Priority: Normal
> Component: core
> Assignee: dev@dpdk.org
> Reporter: spyroot@gmail.com
> Target Milestone: ---
>
> Hi Folks,
>
> There is an issue in i40 and ivfx PMD's both drivers send optional commands
> that require trusted mode enabled and if OP_DISABLE_VLAN_STRIPPING discard
> by
> PF, PMD return error and not gracefully handles.
>
>
> Example iavf_disable_vlan_strip() same function present in i40 that disable
> vlan strip. That is optional and not required and must be gracefully be
> handled.
>
>
> EAL: Detected 4 lcore(s)
> EAL: Detected 1 NUMA nodes
> EAL: Detected static linkage of DPDK
> EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
> EAL: Selected IOVA mode 'PA'
> EAL: No available hugepages reported in hugepages-1048576kB
> EAL: Probing VFIO support...
> EAL: Probe PCI driver: net_iavf (8086:1889) device: 0000:13:00.0 (socket 0)
> EAL: Error reading from file descriptor 26: Input/output error
> EAL: No legacy callbacks, legacy socket not created
> testpmd: create a new mbuf pool <mb_pool_0>: n=171456, size=2176, socket=0
> testpmd: preferred mempool ops selected: ring_mp_mc
>
> Warning! port-topology=paired and odd forward ports number, the last port
> will
> pair with itself.
>
> Configuring Port 0 (socket 0)
> iavf_execute_vf_cmd(): No response for cmd 28
> iavf_disable_vlan_strip(): Failed to execute command of
> OP_DISABLE_VLAN_STRIPPING
> iavf_init_rss(): RSS is enabled by PF by default
> iavf_execute_vf_cmd(): No response for cmd 24
> iavf_configure_rss_lut(): Failed to execute command of OP_CONFIG_RSS_LUT
> iavf_dev_configure(): configure rss failed
> Port0 dev_configure = -1
> Fail to configure port 0
> EAL: Error - exiting with code: 1
> Cause: Start ports failed
>
> Thank you,
> Mus>
>
> --
> You are receiving this mail because:
> You are the assignee for the bug.