* [dpdk-dev] [PATCH] ci: exit setup on any error
@ 2019-08-08 12:22 David Marchand
2019-08-08 13:07 ` Michael Santana Francisco
2019-08-08 14:30 ` Aaron Conole
0 siblings, 2 replies; 4+ messages in thread
From: David Marchand @ 2019-08-08 12:22 UTC (permalink / raw)
To: dev; +Cc: aconole, msantana
-e is preferrable so that we can catch errors in the middle of this
script.
An example is this Travis job [1] that should have errored at the meson
install step rather than go to the build step.
Adding debug mode as it can help post-mortem.
1: https://travis-ci.com/DPDK/dpdk/jobs/223511683
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
.ci/linux-setup.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.ci/linux-setup.sh b/.ci/linux-setup.sh
index a40e62e..dfb9d4a 100755
--- a/.ci/linux-setup.sh
+++ b/.ci/linux-setup.sh
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/sh -xe
# need to install as 'root' since some of the unit tests won't run without it
sudo python3 -m pip install --upgrade meson
--
1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] ci: exit setup on any error
2019-08-08 12:22 [dpdk-dev] [PATCH] ci: exit setup on any error David Marchand
@ 2019-08-08 13:07 ` Michael Santana Francisco
2019-08-08 14:30 ` Aaron Conole
1 sibling, 0 replies; 4+ messages in thread
From: Michael Santana Francisco @ 2019-08-08 13:07 UTC (permalink / raw)
To: David Marchand; +Cc: dev, Aaron Conole
On Thu, Aug 8, 2019 at 8:22 AM David Marchand <david.marchand@redhat.com> wrote:
>
> -e is preferrable so that we can catch errors in the middle of this
> script.
> An example is this Travis job [1] that should have errored at the meson
> install step rather than go to the build step.
>
> Adding debug mode as it can help post-mortem.
>
> 1: https://travis-ci.com/DPDK/dpdk/jobs/223511683
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Michael Santana <msantana@redhat.com>
> ---
> .ci/linux-setup.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.ci/linux-setup.sh b/.ci/linux-setup.sh
> index a40e62e..dfb9d4a 100755
> --- a/.ci/linux-setup.sh
> +++ b/.ci/linux-setup.sh
> @@ -1,4 +1,4 @@
> -#!/bin/sh
> +#!/bin/sh -xe
>
> # need to install as 'root' since some of the unit tests won't run without it
> sudo python3 -m pip install --upgrade meson
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] ci: exit setup on any error
2019-08-08 12:22 [dpdk-dev] [PATCH] ci: exit setup on any error David Marchand
2019-08-08 13:07 ` Michael Santana Francisco
@ 2019-08-08 14:30 ` Aaron Conole
2019-09-13 11:19 ` Thomas Monjalon
1 sibling, 1 reply; 4+ messages in thread
From: Aaron Conole @ 2019-08-08 14:30 UTC (permalink / raw)
To: David Marchand; +Cc: dev, msantana
David Marchand <david.marchand@redhat.com> writes:
> -e is preferrable so that we can catch errors in the middle of this
> script.
> An example is this Travis job [1] that should have errored at the meson
> install step rather than go to the build step.
>
> Adding debug mode as it can help post-mortem.
>
> 1: https://travis-ci.com/DPDK/dpdk/jobs/223511683
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Good call.
Acked-by: Aaron Conole <aconole@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] ci: exit setup on any error
2019-08-08 14:30 ` Aaron Conole
@ 2019-09-13 11:19 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2019-09-13 11:19 UTC (permalink / raw)
To: David Marchand; +Cc: dev, Aaron Conole
08/08/2019 16:30, Aaron Conole:
> David Marchand <david.marchand@redhat.com> writes:
>
> > -e is preferrable so that we can catch errors in the middle of this
> > script.
> > An example is this Travis job [1] that should have errored at the meson
> > install step rather than go to the build step.
> >
> > Adding debug mode as it can help post-mortem.
> >
> > 1: https://travis-ci.com/DPDK/dpdk/jobs/223511683
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
>
> Good call.
>
> Acked-by: Aaron Conole <aconole@redhat.com>
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-13 11:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-08 12:22 [dpdk-dev] [PATCH] ci: exit setup on any error David Marchand
2019-08-08 13:07 ` Michael Santana Francisco
2019-08-08 14:30 ` Aaron Conole
2019-09-13 11:19 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).