From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0ACE0A0487 for ; Mon, 1 Jul 2019 20:09:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EEBD81BA5E; Mon, 1 Jul 2019 20:08:12 +0200 (CEST) Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by dpdk.org (Postfix) with ESMTP id 600501B9A6 for ; Mon, 1 Jul 2019 20:08:06 +0200 (CEST) Received: by mail-io1-f68.google.com with SMTP id h6so30949025ioh.3 for ; Mon, 01 Jul 2019 11:08:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+Xlckuh3XT2mr5PvOFSplQqthEKOZIkX73TBOeDbNNM=; b=Uba1fXVKzBm9wvCFzV5yIrg3UDrr8byR6NiYF4nGIAnyo2qIryfC5ZVPkL9c2XRm1M dimv30V6oBqgzd/yONMWg8FVgI9itt5xSpg+gjGoGJSxGEfOBYpbqwiFcjuOHBf9/fh/ l7b6pRgAaG1z+jnrnyjQGi9+LH3oeyCU0WkykYYA+9GC4eb57yr1NLDE5RgLTAhHE7J+ IxmkrZohhzTZepzxVa6gH3BtQpmRfndP16ZnmPL/3DY+xdqsulHNacpG/qZVAPegzum1 PsJoU44yRgHAXa6h3sKZwtx0ZuaF4Rzp8mUdRE4lV8W5kdgjfLH+nPF14v38w6C2c/Nq UA5g== X-Gm-Message-State: APjAAAVblfUKVWENz2OI9e4cY4T1ITBfXlqyVjrl/VMDFSGU1PjoXG5G 2m0WFMO/qMWd0aeh7r81iEr6VLyEA71jMVqyeuInKg== X-Google-Smtp-Source: APXvYqx4tkVWaQLJGDj7gBjd+vycKBUVtuP6G/HpsaAUN44Gt5zxi4r+a2951X1KVm+++JnctHQEcK5/51/mJJSxafk= X-Received: by 2002:a6b:7b01:: with SMTP id l1mr2434081iop.60.1562004485812; Mon, 01 Jul 2019 11:08:05 -0700 (PDT) MIME-Version: 1.0 References: <1559638792-8608-1-git-send-email-david.marchand@redhat.com> <1560580950-16754-1-git-send-email-david.marchand@redhat.com> <70986373.KVGszKu7e3@xps> In-Reply-To: From: Michael Santana Francisco Date: Mon, 1 Jul 2019 14:07:54 -0400 Message-ID: To: David Marchand Cc: Aaron Conole , Thomas Monjalon , dev , JananeeX M Parthasarathy Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 00/15] Unit tests fixes for CI X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > On Mon, Jul 1, 2019 at 6:04 PM Aaron Conole wrote: >> >> >> - rwlock_autotest and hash_readwrite_lf_autotest are taking a little more >> >> than 10s, >> >> Occasionally the distributor test times out as well. I've moved them as >> part of a separate patch, that I'll post along with a bigger series to >> enable the unit tests under travis. Michael and I are leaning toward >> introducing a new variable called RUN_TESTS which will do the docs and >> unit testing since those combined would add quite a bit to the execution >> time of each job (and feel free to bike shed the name, since the patches >> aren't final). > > > Seeing how the distributor autotest usually takes less than a second to complete, this sounds like a bug. > I don't think I caught this so far. So I actually ran into the distributor test timing out. I agree with David in that it is a bug with the test. Looking at the logs that test normally finishes in less than 1/2 a second, so running to 10 seconds and timing out is a big jump in run time. I ran into the issue where it timedout, so I restarted the job and it finished no problem. The test fails every so often for no good reason and the logs[1] dont really say much. I speculate that it is waiting for a resource to become available or in the worse case a deadlock. Seeing that it only fails every so often and it passes when restarted I don't think it's a big deal, nevertheless it's worth investing time figuring out what's wrong [1] https://api.travis-ci.com/v3/job/212335916/log.txt > > > Yes, we need a variable to control this and select the targets that will do the tests and/or build the doc. > About the name, RUN_TESTS is ok for me. > > What do you want to make of this variable? > Have it as a simple boolean that enables everything? Or a selector with strings like unit-tests+doc+perf-tests? > > >> >> >> - librte_table unit test crashes on ipv6 [2], >> >> I guess we're waiting on a patch from Jananee (CC'd)? > > > Yep. > > > -- > David Marchand