[dpdk-dev] [PATCH] eal: order experimental symbols per release

[dpdk-dev] [PATCH] eal: order experimental symbols per release

[David Marchand]

Sort the experimental symbols per release to make it easier/quicker to
check for how long we have them.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 lib/librte_eal/rte_eal_version.map | 110 +++++++++++++++++++++----------------
 1 file changed, 62 insertions(+), 48 deletions(-)

diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
index 2344877..d30386f 100644
--- a/lib/librte_eal/rte_eal_version.map
+++ b/lib/librte_eal/rte_eal_version.map
@@ -315,91 +315,104 @@ DPDK_19.08 {
 EXPERIMENTAL {
 	global:
 
-	rte_class_find;
-	rte_class_find_by_name;
-	rte_class_register;
-	rte_class_unregister;
-	rte_delay_us_sleep;
-	rte_dev_dma_map;
-	rte_dev_dma_unmap;
-	rte_dev_event_callback_process;
+	# added in 18.02
+	rte_mp_action_register;
+	rte_mp_action_unregister;
+	rte_mp_reply;
+	rte_mp_sendmsg;
+
+	# added in 18.05
 	rte_dev_event_callback_register;
 	rte_dev_event_callback_unregister;
 	rte_dev_event_monitor_start;
 	rte_dev_event_monitor_stop;
-	rte_dev_hotplug_handle_disable;
-	rte_dev_hotplug_handle_enable;
-	rte_dev_iterator_init;
-	rte_dev_iterator_next;
-	rte_extmem_attach;
-	rte_extmem_detach;
-	rte_extmem_register;
-	rte_extmem_unregister;
 	rte_fbarray_attach;
 	rte_fbarray_destroy;
 	rte_fbarray_detach;
 	rte_fbarray_dump_metadata;
 	rte_fbarray_find_idx;
-	rte_fbarray_find_biggest_free;
-	rte_fbarray_find_biggest_used;
 	rte_fbarray_find_next_free;
 	rte_fbarray_find_next_used;
 	rte_fbarray_find_next_n_free;
 	rte_fbarray_find_next_n_used;
-	rte_fbarray_find_prev_free;
-	rte_fbarray_find_prev_used;
-	rte_fbarray_find_prev_n_free;
-	rte_fbarray_find_prev_n_used;
 	rte_fbarray_find_contig_free;
 	rte_fbarray_find_contig_used;
-	rte_fbarray_find_rev_biggest_free;
-	rte_fbarray_find_rev_biggest_used;
-	rte_fbarray_find_rev_contig_free;
-	rte_fbarray_find_rev_contig_used;
 	rte_fbarray_get;
 	rte_fbarray_init;
 	rte_fbarray_is_used;
 	rte_fbarray_set_free;
 	rte_fbarray_set_used;
-	rte_intr_callback_unregister_pending;
 	rte_log_register_type_and_pick_level;
 	rte_malloc_dump_heaps;
-	rte_malloc_heap_create;
-	rte_malloc_heap_destroy;
-	rte_malloc_heap_get_socket;
-	rte_malloc_heap_memory_add;
-	rte_malloc_heap_memory_attach;
-	rte_malloc_heap_memory_detach;
-	rte_malloc_heap_memory_remove;
-	rte_malloc_heap_socket_is_external;
 	rte_mem_alloc_validator_register;
 	rte_mem_alloc_validator_unregister;
 	rte_mem_check_dma_mask;
-	rte_mem_check_dma_mask_thread_unsafe;
 	rte_mem_event_callback_register;
 	rte_mem_event_callback_unregister;
 	rte_mem_iova2virt;
-	rte_mem_set_dma_mask;
 	rte_mem_virt2memseg;
 	rte_mem_virt2memseg_list;
 	rte_memseg_contig_walk;
+	rte_memseg_list_walk;
+	rte_memseg_walk;
+	rte_mp_request_async;
+	rte_mp_request_sync;
+
+	# added in 18.08
+	rte_class_find;
+	rte_class_find_by_name;
+	rte_class_register;
+	rte_class_unregister;
+	rte_dev_iterator_init;
+	rte_dev_iterator_next;
+	rte_fbarray_find_prev_free;
+	rte_fbarray_find_prev_used;
+	rte_fbarray_find_prev_n_free;
+	rte_fbarray_find_prev_n_used;
+	rte_fbarray_find_rev_contig_free;
+	rte_fbarray_find_rev_contig_used;
 	rte_memseg_contig_walk_thread_unsafe;
+	rte_memseg_list_walk_thread_unsafe;
+	rte_memseg_walk_thread_unsafe;
+	rte_service_lcore_attr_get;
+	rte_service_lcore_attr_reset_all;
+	rte_service_may_be_active;
+
+	# added in 18.11
+	rte_delay_us_sleep;
+	rte_dev_event_callback_process;
+	rte_dev_hotplug_handle_disable;
+	rte_dev_hotplug_handle_enable;
+	rte_malloc_heap_create;
+	rte_malloc_heap_destroy;
+	rte_malloc_heap_get_socket;
+	rte_malloc_heap_memory_add;
+	rte_malloc_heap_memory_attach;
+	rte_malloc_heap_memory_detach;
+	rte_malloc_heap_memory_remove;
+	rte_malloc_heap_socket_is_external;
+	rte_mem_check_dma_mask_thread_unsafe;
+	rte_mem_set_dma_mask;
 	rte_memseg_get_fd;
 	rte_memseg_get_fd_offset;
 	rte_memseg_get_fd_thread_unsafe;
 	rte_memseg_get_fd_offset_thread_unsafe;
-	rte_memseg_list_walk;
-	rte_memseg_list_walk_thread_unsafe;
-	rte_memseg_walk;
-	rte_memseg_walk_thread_unsafe;
-	rte_mp_action_register;
-	rte_mp_action_unregister;
-	rte_mp_reply;
-	rte_mp_request_sync;
-	rte_mp_request_async;
-	rte_mp_sendmsg;
 	rte_option_register;
-	rte_rand_max;
+
+	# added in 19.02
+	rte_extmem_attach;
+	rte_extmem_detach;
+	rte_extmem_register;
+	rte_extmem_unregister;
+
+	# added in 19.05
+	rte_dev_dma_map;
+	rte_dev_dma_unmap;
+	rte_fbarray_find_biggest_free;
+	rte_fbarray_find_biggest_used;
+	rte_fbarray_find_rev_biggest_free;
+	rte_fbarray_find_rev_biggest_used;
+	rte_intr_callback_unregister_pending;
 	rte_realloc_socket;
 
 	# added in 19.08
@@ -408,4 +421,5 @@ EXPERIMENTAL {
 	rte_lcore_to_cpu_id;
 	rte_mcfg_timer_lock;
 	rte_mcfg_timer_unlock;
+	rte_rand_max;
 };
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH] eal: order experimental symbols per release

[David Marchand]

On Fri, Jul 26, 2019 at 3:52 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> Sort the experimental symbols per release to make it easier/quicker to
> check for how long we have them.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Rebase damage...
v2 in progress, sorry.

-- 
David Marchand

[dpdk-dev] [PATCH v2] eal: sort experimental symbols per release

[David Marchand]

Sort the experimental symbols per release to make it easier/quicker to
check for how long we have them.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
Changelog since v1:
- rte_service symbols who got promoted to stable got reintroduced in
  experimental when rebasing this patch on master

---
 lib/librte_eal/rte_eal_version.map | 107 ++++++++++++++++++++-----------------
 1 file changed, 59 insertions(+), 48 deletions(-)

diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
index 2344877..ed52071 100644
--- a/lib/librte_eal/rte_eal_version.map
+++ b/lib/librte_eal/rte_eal_version.map
@@ -315,91 +315,101 @@ DPDK_19.08 {
 EXPERIMENTAL {
 	global:
 
-	rte_class_find;
-	rte_class_find_by_name;
-	rte_class_register;
-	rte_class_unregister;
-	rte_delay_us_sleep;
-	rte_dev_dma_map;
-	rte_dev_dma_unmap;
-	rte_dev_event_callback_process;
+	# added in 18.02
+	rte_mp_action_register;
+	rte_mp_action_unregister;
+	rte_mp_reply;
+	rte_mp_sendmsg;
+
+	# added in 18.05
 	rte_dev_event_callback_register;
 	rte_dev_event_callback_unregister;
 	rte_dev_event_monitor_start;
 	rte_dev_event_monitor_stop;
-	rte_dev_hotplug_handle_disable;
-	rte_dev_hotplug_handle_enable;
-	rte_dev_iterator_init;
-	rte_dev_iterator_next;
-	rte_extmem_attach;
-	rte_extmem_detach;
-	rte_extmem_register;
-	rte_extmem_unregister;
 	rte_fbarray_attach;
 	rte_fbarray_destroy;
 	rte_fbarray_detach;
 	rte_fbarray_dump_metadata;
 	rte_fbarray_find_idx;
-	rte_fbarray_find_biggest_free;
-	rte_fbarray_find_biggest_used;
 	rte_fbarray_find_next_free;
 	rte_fbarray_find_next_used;
 	rte_fbarray_find_next_n_free;
 	rte_fbarray_find_next_n_used;
-	rte_fbarray_find_prev_free;
-	rte_fbarray_find_prev_used;
-	rte_fbarray_find_prev_n_free;
-	rte_fbarray_find_prev_n_used;
 	rte_fbarray_find_contig_free;
 	rte_fbarray_find_contig_used;
-	rte_fbarray_find_rev_biggest_free;
-	rte_fbarray_find_rev_biggest_used;
-	rte_fbarray_find_rev_contig_free;
-	rte_fbarray_find_rev_contig_used;
 	rte_fbarray_get;
 	rte_fbarray_init;
 	rte_fbarray_is_used;
 	rte_fbarray_set_free;
 	rte_fbarray_set_used;
-	rte_intr_callback_unregister_pending;
 	rte_log_register_type_and_pick_level;
 	rte_malloc_dump_heaps;
-	rte_malloc_heap_create;
-	rte_malloc_heap_destroy;
-	rte_malloc_heap_get_socket;
-	rte_malloc_heap_memory_add;
-	rte_malloc_heap_memory_attach;
-	rte_malloc_heap_memory_detach;
-	rte_malloc_heap_memory_remove;
-	rte_malloc_heap_socket_is_external;
 	rte_mem_alloc_validator_register;
 	rte_mem_alloc_validator_unregister;
 	rte_mem_check_dma_mask;
-	rte_mem_check_dma_mask_thread_unsafe;
 	rte_mem_event_callback_register;
 	rte_mem_event_callback_unregister;
 	rte_mem_iova2virt;
-	rte_mem_set_dma_mask;
 	rte_mem_virt2memseg;
 	rte_mem_virt2memseg_list;
 	rte_memseg_contig_walk;
+	rte_memseg_list_walk;
+	rte_memseg_walk;
+	rte_mp_request_async;
+	rte_mp_request_sync;
+
+	# added in 18.08
+	rte_class_find;
+	rte_class_find_by_name;
+	rte_class_register;
+	rte_class_unregister;
+	rte_dev_iterator_init;
+	rte_dev_iterator_next;
+	rte_fbarray_find_prev_free;
+	rte_fbarray_find_prev_used;
+	rte_fbarray_find_prev_n_free;
+	rte_fbarray_find_prev_n_used;
+	rte_fbarray_find_rev_contig_free;
+	rte_fbarray_find_rev_contig_used;
 	rte_memseg_contig_walk_thread_unsafe;
+	rte_memseg_list_walk_thread_unsafe;
+	rte_memseg_walk_thread_unsafe;
+
+	# added in 18.11
+	rte_delay_us_sleep;
+	rte_dev_event_callback_process;
+	rte_dev_hotplug_handle_disable;
+	rte_dev_hotplug_handle_enable;
+	rte_malloc_heap_create;
+	rte_malloc_heap_destroy;
+	rte_malloc_heap_get_socket;
+	rte_malloc_heap_memory_add;
+	rte_malloc_heap_memory_attach;
+	rte_malloc_heap_memory_detach;
+	rte_malloc_heap_memory_remove;
+	rte_malloc_heap_socket_is_external;
+	rte_mem_check_dma_mask_thread_unsafe;
+	rte_mem_set_dma_mask;
 	rte_memseg_get_fd;
 	rte_memseg_get_fd_offset;
 	rte_memseg_get_fd_thread_unsafe;
 	rte_memseg_get_fd_offset_thread_unsafe;
-	rte_memseg_list_walk;
-	rte_memseg_list_walk_thread_unsafe;
-	rte_memseg_walk;
-	rte_memseg_walk_thread_unsafe;
-	rte_mp_action_register;
-	rte_mp_action_unregister;
-	rte_mp_reply;
-	rte_mp_request_sync;
-	rte_mp_request_async;
-	rte_mp_sendmsg;
 	rte_option_register;
-	rte_rand_max;
+
+	# added in 19.02
+	rte_extmem_attach;
+	rte_extmem_detach;
+	rte_extmem_register;
+	rte_extmem_unregister;
+
+	# added in 19.05
+	rte_dev_dma_map;
+	rte_dev_dma_unmap;
+	rte_fbarray_find_biggest_free;
+	rte_fbarray_find_biggest_used;
+	rte_fbarray_find_rev_biggest_free;
+	rte_fbarray_find_rev_biggest_used;
+	rte_intr_callback_unregister_pending;
 	rte_realloc_socket;
 
 	# added in 19.08
@@ -408,4 +418,5 @@ EXPERIMENTAL {
 	rte_lcore_to_cpu_id;
 	rte_mcfg_timer_lock;
 	rte_mcfg_timer_unlock;
+	rte_rand_max;
 };
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH v2] eal: sort experimental symbols per release

[David Marchand]

Thomas,

On Fri, Jul 26, 2019 at 4:06 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> Sort the experimental symbols per release to make it easier/quicker to
> check for how long we have them.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> Changelog since v1:
> - rte_service symbols who got promoted to stable got reintroduced in
>   experimental when rebasing this patch on master
>

I know you love shel scripts, so here is what I used to check this patch:

$ map=lib/librte_eal/rte_eal_version.map
$ ./buildtools/map-list-symbol.sh -S EXPERIMENTAL $map |while read
file section symbol; do
  sha1=$(git log --pretty=tformat:%h --follow -S $symbol $map |head -1);
  rev=$(git describe --contains $sha1 2>/dev/null || git describe $sha1);
  echo $symbol introduced in $rev;
done

rte_class_find introduced in v18.08-rc1~9
rte_class_find_by_name introduced in v18.08-rc1~9
rte_class_register introduced in v18.08-rc1~9
rte_class_unregister introduced in v18.08-rc1~9
rte_delay_us_sleep introduced in v18.11-rc1~66
rte_dev_dma_map introduced in v19.05-rc1~283
rte_dev_dma_unmap introduced in v19.05-rc1~283
rte_dev_event_callback_process introduced in v18.11-rc1~431
rte_dev_event_callback_register introduced in v18.05-rc1~626
rte_dev_event_callback_unregister introduced in v18.05-rc1~626
rte_dev_event_monitor_start introduced in v18.05-rc1~626
rte_dev_event_monitor_stop introduced in v18.05-rc1~626
rte_dev_hotplug_handle_disable introduced in v18.11-rc1~434
rte_dev_hotplug_handle_enable introduced in v18.11-rc1~434
rte_dev_iterator_init introduced in v18.08-rc1~6
rte_dev_iterator_next introduced in v18.08-rc1~5
rte_extmem_attach introduced in v19.02-rc1~141
rte_extmem_detach introduced in v19.02-rc1~141
rte_extmem_register introduced in v19.02-rc1~142
rte_extmem_unregister introduced in v19.02-rc1~142
rte_fbarray_attach introduced in v18.05-rc1~665
rte_fbarray_destroy introduced in v18.05-rc1~665
rte_fbarray_detach introduced in v18.05-rc1~665
rte_fbarray_dump_metadata introduced in v18.05-rc1~665
rte_fbarray_find_idx introduced in v18.05-rc1~665
rte_fbarray_find_biggest_free introduced in v19.05-rc1~317
rte_fbarray_find_biggest_used introduced in v19.05-rc1~317
rte_fbarray_find_next_free introduced in v18.05-rc1~665
rte_fbarray_find_next_used introduced in v18.05-rc1~665
rte_fbarray_find_next_n_free introduced in v18.05-rc1~665
rte_fbarray_find_next_n_used introduced in v18.05-rc1~665
rte_fbarray_find_prev_free introduced in v18.05-477-gb8d07c5
rte_fbarray_find_prev_used introduced in v18.05-477-gb8d07c5
rte_fbarray_find_prev_n_free introduced in v18.05-478-ge1ca5dc
rte_fbarray_find_prev_n_used introduced in v18.05-478-ge1ca5dc
rte_fbarray_find_contig_free introduced in v18.05-rc1~665
rte_fbarray_find_contig_used introduced in v18.05-rc1~665
rte_fbarray_find_rev_biggest_free introduced in v19.05-rc1~317
rte_fbarray_find_rev_biggest_used introduced in v19.05-rc1~317
rte_fbarray_find_rev_contig_free introduced in v18.05-479-g4d2dde2
rte_fbarray_find_rev_contig_used introduced in v18.05-479-g4d2dde2
rte_fbarray_get introduced in v18.05-rc1~665
rte_fbarray_init introduced in v18.05-rc1~665
rte_fbarray_is_used introduced in v18.05-rc1~665
rte_fbarray_set_free introduced in v18.05-rc1~665
rte_fbarray_set_used introduced in v18.05-rc1~665
rte_intr_callback_unregister_pending introduced in v19.05-rc1~337
rte_log_register_type_and_pick_level introduced in v18.05-rc1~872
rte_malloc_dump_heaps introduced in v18.05-rc1~709
rte_malloc_heap_create introduced in v18.08-376-g02e323a
rte_malloc_heap_destroy introduced in v18.08-377-g15d6dd0
rte_malloc_heap_get_socket introduced in v18.08-374-ge1fe3c2
rte_malloc_heap_memory_add introduced in v18.08-378-g7d75c31
rte_malloc_heap_memory_attach introduced in v18.08-380-gff3619d
rte_malloc_heap_memory_detach introduced in v18.08-381-gc842d1c
rte_malloc_heap_memory_remove introduced in v18.08-379-g75185aa
rte_malloc_heap_socket_is_external introduced in v18.08-375-g65ff37b
rte_mem_alloc_validator_register introduced in v18.05-rc1~645
rte_mem_alloc_validator_unregister introduced in v18.05-rc1~645
rte_mem_check_dma_mask introduced in v18.11-rc1-25-g84e7477
rte_mem_check_dma_mask_thread_unsafe introduced in v18.11-rc1-25-g84e7477
rte_mem_event_callback_register introduced in v18.05-rc1~651
rte_mem_event_callback_unregister introduced in v18.05-rc1~651
rte_mem_iova2virt introduced in v18.05-rc1~677
rte_mem_set_dma_mask introduced in v18.11-rc1-21-g9d15773
rte_mem_virt2memseg introduced in v18.05-rc1~664
rte_mem_virt2memseg_list introduced in v18.05-rc1~664
rte_memseg_contig_walk introduced in v18.05-483-gb917147
rte_memseg_contig_walk_thread_unsafe introduced in v18.05-483-gb917147
rte_memseg_get_fd introduced in v18.11-rc1~948
rte_memseg_get_fd_offset introduced in v18.11-rc1~948
rte_memseg_get_fd_thread_unsafe introduced in v18.11-rc1~949
rte_memseg_get_fd_offset_thread_unsafe introduced in v18.11-rc1~948
rte_memseg_list_walk introduced in v18.05-485-ge264154
rte_memseg_list_walk_thread_unsafe introduced in v18.05-485-ge264154
rte_memseg_walk introduced in v18.05-484-g7c790af
rte_memseg_walk_thread_unsafe introduced in v18.05-484-g7c790af
rte_mp_action_register introduced in v18.02-rc2~191
rte_mp_action_unregister introduced in v18.02-rc2~191
rte_mp_reply introduced in v18.02-rc2~190
rte_mp_request_sync introduced in v18.05-rc1~782
rte_mp_request_async introduced in v18.05-rc1~781
rte_mp_sendmsg introduced in v18.02-rc2~191
rte_option_register introduced in v18.11-rc1~55
rte_rand_max introduced in v19.08-rc1~474
rte_realloc_socket introduced in v19.02-228-ga7cece2
rte_intr_ack introduced in v19.08-rc2~162
rte_lcore_cpuset introduced in v19.08-rc1~757
rte_lcore_to_cpu_id introduced in v19.08-rc1~757
rte_mcfg_timer_lock introduced in v19.05-620-gf9d6cd8
rte_mcfg_timer_unlock introduced in v19.05-620-gf9d6cd8



-- 
David Marchand

Re: [dpdk-dev] [PATCH v2] eal: sort experimental symbols per release

[Ferruh Yigit]

On 7/26/2019 3:06 PM, David Marchand wrote:
> Sort the experimental symbols per release to make it easier/quicker to
> check for how long we have them.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Re: [dpdk-dev] [PATCH v2] eal: sort experimental symbols per release

[Michael Santana Francisco]

On 7/26/19 10:06 AM, David Marchand wrote:
> Sort the experimental symbols per release to make it easier/quicker to
> check for how long we have them.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> Changelog since v1:
> - rte_service symbols who got promoted to stable got reintroduced in
>    experimental when rebasing this patch on master
Just going off Stephen's original proposal; it should be sorted by 
release and then by alphabetical order. Some blocks weren't sorted by 
alphabetical order when I ran sort after I applied your patch
>
> ---
>   lib/librte_eal/rte_eal_version.map | 107 ++++++++++++++++++++-----------------
>   1 file changed, 59 insertions(+), 48 deletions(-)
>
> diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
> index 2344877..ed52071 100644
> --- a/lib/librte_eal/rte_eal_version.map
> +++ b/lib/librte_eal/rte_eal_version.map
> @@ -315,91 +315,101 @@ DPDK_19.08 {
>   EXPERIMENTAL {
>   	global:
>   
> -	rte_class_find;
> -	rte_class_find_by_name;
> -	rte_class_register;
> -	rte_class_unregister;
> -	rte_delay_us_sleep;
> -	rte_dev_dma_map;
> -	rte_dev_dma_unmap;
> -	rte_dev_event_callback_process;
> +	# added in 18.02
> +	rte_mp_action_register;
> +	rte_mp_action_unregister;
> +	rte_mp_reply;
> +	rte_mp_sendmsg;
> +
> +	# added in 18.05
>   	rte_dev_event_callback_register;
>   	rte_dev_event_callback_unregister;
>   	rte_dev_event_monitor_start;
>   	rte_dev_event_monitor_stop;
> -	rte_dev_hotplug_handle_disable;
> -	rte_dev_hotplug_handle_enable;
> -	rte_dev_iterator_init;
> -	rte_dev_iterator_next;
> -	rte_extmem_attach;
> -	rte_extmem_detach;
> -	rte_extmem_register;
> -	rte_extmem_unregister;
>   	rte_fbarray_attach;
>   	rte_fbarray_destroy;
>   	rte_fbarray_detach;
>   	rte_fbarray_dump_metadata;
>   	rte_fbarray_find_idx;
> -	rte_fbarray_find_biggest_free;
> -	rte_fbarray_find_biggest_used;
>   	rte_fbarray_find_next_free;
>   	rte_fbarray_find_next_used;
>   	rte_fbarray_find_next_n_free;
>   	rte_fbarray_find_next_n_used;
> -	rte_fbarray_find_prev_free;
> -	rte_fbarray_find_prev_used;
> -	rte_fbarray_find_prev_n_free;
> -	rte_fbarray_find_prev_n_used;
>   	rte_fbarray_find_contig_free;
>   	rte_fbarray_find_contig_used;
> -	rte_fbarray_find_rev_biggest_free;
> -	rte_fbarray_find_rev_biggest_used;
> -	rte_fbarray_find_rev_contig_free;
> -	rte_fbarray_find_rev_contig_used;
>   	rte_fbarray_get;
>   	rte_fbarray_init;
>   	rte_fbarray_is_used;
>   	rte_fbarray_set_free;
>   	rte_fbarray_set_used;
> -	rte_intr_callback_unregister_pending;
>   	rte_log_register_type_and_pick_level;
>   	rte_malloc_dump_heaps;
> -	rte_malloc_heap_create;
> -	rte_malloc_heap_destroy;
> -	rte_malloc_heap_get_socket;
> -	rte_malloc_heap_memory_add;
> -	rte_malloc_heap_memory_attach;
> -	rte_malloc_heap_memory_detach;
> -	rte_malloc_heap_memory_remove;
> -	rte_malloc_heap_socket_is_external;
>   	rte_mem_alloc_validator_register;
>   	rte_mem_alloc_validator_unregister;
>   	rte_mem_check_dma_mask;
> -	rte_mem_check_dma_mask_thread_unsafe;
>   	rte_mem_event_callback_register;
>   	rte_mem_event_callback_unregister;
>   	rte_mem_iova2virt;
> -	rte_mem_set_dma_mask;
>   	rte_mem_virt2memseg;
>   	rte_mem_virt2memseg_list;
>   	rte_memseg_contig_walk;
> +	rte_memseg_list_walk;
> +	rte_memseg_walk;
> +	rte_mp_request_async;
> +	rte_mp_request_sync;
> +
> +	# added in 18.08
> +	rte_class_find;
> +	rte_class_find_by_name;
> +	rte_class_register;
> +	rte_class_unregister;
> +	rte_dev_iterator_init;
> +	rte_dev_iterator_next;
> +	rte_fbarray_find_prev_free;
> +	rte_fbarray_find_prev_used;
> +	rte_fbarray_find_prev_n_free;
> +	rte_fbarray_find_prev_n_used;
> +	rte_fbarray_find_rev_contig_free;
> +	rte_fbarray_find_rev_contig_used;
>   	rte_memseg_contig_walk_thread_unsafe;
> +	rte_memseg_list_walk_thread_unsafe;
> +	rte_memseg_walk_thread_unsafe;
> +
> +	# added in 18.11
> +	rte_delay_us_sleep;
> +	rte_dev_event_callback_process;
> +	rte_dev_hotplug_handle_disable;
> +	rte_dev_hotplug_handle_enable;
> +	rte_malloc_heap_create;
> +	rte_malloc_heap_destroy;
> +	rte_malloc_heap_get_socket;
> +	rte_malloc_heap_memory_add;
> +	rte_malloc_heap_memory_attach;
> +	rte_malloc_heap_memory_detach;
> +	rte_malloc_heap_memory_remove;
> +	rte_malloc_heap_socket_is_external;
> +	rte_mem_check_dma_mask_thread_unsafe;
> +	rte_mem_set_dma_mask;
>   	rte_memseg_get_fd;
>   	rte_memseg_get_fd_offset;
>   	rte_memseg_get_fd_thread_unsafe;
>   	rte_memseg_get_fd_offset_thread_unsafe;
> -	rte_memseg_list_walk;
> -	rte_memseg_list_walk_thread_unsafe;
> -	rte_memseg_walk;
> -	rte_memseg_walk_thread_unsafe;
> -	rte_mp_action_register;
> -	rte_mp_action_unregister;
> -	rte_mp_reply;
> -	rte_mp_request_sync;
> -	rte_mp_request_async;
> -	rte_mp_sendmsg;
>   	rte_option_register;
> -	rte_rand_max;
> +
> +	# added in 19.02
> +	rte_extmem_attach;
> +	rte_extmem_detach;
> +	rte_extmem_register;
> +	rte_extmem_unregister;
> +
> +	# added in 19.05
> +	rte_dev_dma_map;
> +	rte_dev_dma_unmap;
> +	rte_fbarray_find_biggest_free;
> +	rte_fbarray_find_biggest_used;
> +	rte_fbarray_find_rev_biggest_free;
> +	rte_fbarray_find_rev_biggest_used;
> +	rte_intr_callback_unregister_pending;
>   	rte_realloc_socket;
>   
>   	# added in 19.08
> @@ -408,4 +418,5 @@ EXPERIMENTAL {
>   	rte_lcore_to_cpu_id;
>   	rte_mcfg_timer_lock;
>   	rte_mcfg_timer_unlock;
> +	rte_rand_max;
>   };

Re: [dpdk-dev] [PATCH v2] eal: sort experimental symbols per release

[David Marchand]

On Fri, Jul 26, 2019 at 6:06 PM Michael Santana Francisco
<msantana@redhat.com> wrote:
>
> On 7/26/19 10:06 AM, David Marchand wrote:
>
> Sort the experimental symbols per release to make it easier/quicker to
> check for how long we have them.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> Changelog since v1:
> - rte_service symbols who got promoted to stable got reintroduced in
>   experimental when rebasing this patch on master
>
> Just going off Stephen's original proposal; it should be sorted by release and then by alphabetical order. Some blocks weren't sorted by alphabetical order when I ran sort after I applied your patch

Ah yes, I had moved some blocks as is without checking them.
Fixed in v3.
Thanks!


-- 
David Marchand

[dpdk-dev] [PATCH v3] eal: sort experimental symbols per release

[David Marchand]

Sort the experimental symbols per release to make it easier/quicker to
check for how long we have them.

Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Changelog since v2:
- fixed alphabetical order per release

Changelog since v1:
- rte_service symbols who got promoted to stable got reintroduced in
  experimental when rebasing this patch on master

---
 lib/librte_eal/rte_eal_version.map | 115 ++++++++++++++++++++-----------------
 1 file changed, 63 insertions(+), 52 deletions(-)

diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
index 2344877..7cbf82d 100644
--- a/lib/librte_eal/rte_eal_version.map
+++ b/lib/librte_eal/rte_eal_version.map
@@ -315,91 +315,101 @@ DPDK_19.08 {
 EXPERIMENTAL {
 	global:
 
-	rte_class_find;
-	rte_class_find_by_name;
-	rte_class_register;
-	rte_class_unregister;
-	rte_delay_us_sleep;
-	rte_dev_dma_map;
-	rte_dev_dma_unmap;
-	rte_dev_event_callback_process;
+	# added in 18.02
+	rte_mp_action_register;
+	rte_mp_action_unregister;
+	rte_mp_reply;
+	rte_mp_sendmsg;
+
+	# added in 18.05
 	rte_dev_event_callback_register;
 	rte_dev_event_callback_unregister;
 	rte_dev_event_monitor_start;
 	rte_dev_event_monitor_stop;
-	rte_dev_hotplug_handle_disable;
-	rte_dev_hotplug_handle_enable;
-	rte_dev_iterator_init;
-	rte_dev_iterator_next;
-	rte_extmem_attach;
-	rte_extmem_detach;
-	rte_extmem_register;
-	rte_extmem_unregister;
 	rte_fbarray_attach;
 	rte_fbarray_destroy;
 	rte_fbarray_detach;
 	rte_fbarray_dump_metadata;
+	rte_fbarray_find_contig_free;
+	rte_fbarray_find_contig_used;
 	rte_fbarray_find_idx;
-	rte_fbarray_find_biggest_free;
-	rte_fbarray_find_biggest_used;
 	rte_fbarray_find_next_free;
-	rte_fbarray_find_next_used;
 	rte_fbarray_find_next_n_free;
 	rte_fbarray_find_next_n_used;
-	rte_fbarray_find_prev_free;
-	rte_fbarray_find_prev_used;
-	rte_fbarray_find_prev_n_free;
-	rte_fbarray_find_prev_n_used;
-	rte_fbarray_find_contig_free;
-	rte_fbarray_find_contig_used;
-	rte_fbarray_find_rev_biggest_free;
-	rte_fbarray_find_rev_biggest_used;
-	rte_fbarray_find_rev_contig_free;
-	rte_fbarray_find_rev_contig_used;
+	rte_fbarray_find_next_used;
 	rte_fbarray_get;
 	rte_fbarray_init;
 	rte_fbarray_is_used;
 	rte_fbarray_set_free;
 	rte_fbarray_set_used;
-	rte_intr_callback_unregister_pending;
 	rte_log_register_type_and_pick_level;
 	rte_malloc_dump_heaps;
-	rte_malloc_heap_create;
-	rte_malloc_heap_destroy;
-	rte_malloc_heap_get_socket;
-	rte_malloc_heap_memory_add;
-	rte_malloc_heap_memory_attach;
-	rte_malloc_heap_memory_detach;
-	rte_malloc_heap_memory_remove;
-	rte_malloc_heap_socket_is_external;
 	rte_mem_alloc_validator_register;
 	rte_mem_alloc_validator_unregister;
 	rte_mem_check_dma_mask;
-	rte_mem_check_dma_mask_thread_unsafe;
 	rte_mem_event_callback_register;
 	rte_mem_event_callback_unregister;
 	rte_mem_iova2virt;
-	rte_mem_set_dma_mask;
 	rte_mem_virt2memseg;
 	rte_mem_virt2memseg_list;
 	rte_memseg_contig_walk;
+	rte_memseg_list_walk;
+	rte_memseg_walk;
+	rte_mp_request_async;
+	rte_mp_request_sync;
+
+	# added in 18.08
+	rte_class_find;
+	rte_class_find_by_name;
+	rte_class_register;
+	rte_class_unregister;
+	rte_dev_iterator_init;
+	rte_dev_iterator_next;
+	rte_fbarray_find_prev_free;
+	rte_fbarray_find_prev_n_free;
+	rte_fbarray_find_prev_n_used;
+	rte_fbarray_find_prev_used;
+	rte_fbarray_find_rev_contig_free;
+	rte_fbarray_find_rev_contig_used;
 	rte_memseg_contig_walk_thread_unsafe;
+	rte_memseg_list_walk_thread_unsafe;
+	rte_memseg_walk_thread_unsafe;
+
+	# added in 18.11
+	rte_delay_us_sleep;
+	rte_dev_event_callback_process;
+	rte_dev_hotplug_handle_disable;
+	rte_dev_hotplug_handle_enable;
+	rte_malloc_heap_create;
+	rte_malloc_heap_destroy;
+	rte_malloc_heap_get_socket;
+	rte_malloc_heap_memory_add;
+	rte_malloc_heap_memory_attach;
+	rte_malloc_heap_memory_detach;
+	rte_malloc_heap_memory_remove;
+	rte_malloc_heap_socket_is_external;
+	rte_mem_check_dma_mask_thread_unsafe;
+	rte_mem_set_dma_mask;
 	rte_memseg_get_fd;
 	rte_memseg_get_fd_offset;
-	rte_memseg_get_fd_thread_unsafe;
 	rte_memseg_get_fd_offset_thread_unsafe;
-	rte_memseg_list_walk;
-	rte_memseg_list_walk_thread_unsafe;
-	rte_memseg_walk;
-	rte_memseg_walk_thread_unsafe;
-	rte_mp_action_register;
-	rte_mp_action_unregister;
-	rte_mp_reply;
-	rte_mp_request_sync;
-	rte_mp_request_async;
-	rte_mp_sendmsg;
+	rte_memseg_get_fd_thread_unsafe;
 	rte_option_register;
-	rte_rand_max;
+
+	# added in 19.02
+	rte_extmem_attach;
+	rte_extmem_detach;
+	rte_extmem_register;
+	rte_extmem_unregister;
+
+	# added in 19.05
+	rte_dev_dma_map;
+	rte_dev_dma_unmap;
+	rte_fbarray_find_biggest_free;
+	rte_fbarray_find_biggest_used;
+	rte_fbarray_find_rev_biggest_free;
+	rte_fbarray_find_rev_biggest_used;
+	rte_intr_callback_unregister_pending;
 	rte_realloc_socket;
 
 	# added in 19.08
@@ -408,4 +418,5 @@ EXPERIMENTAL {
 	rte_lcore_to_cpu_id;
 	rte_mcfg_timer_lock;
 	rte_mcfg_timer_unlock;
+	rte_rand_max;
 };
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH v3] eal: sort experimental symbols per release

[Michael Santana Francisco]

On Sat, Jul 27, 2019 at 3:21 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> Sort the experimental symbols per release to make it easier/quicker to
> check for how long we have them.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Changelog since v2:
> - fixed alphabetical order per release
>
> Changelog since v1:
> - rte_service symbols who got promoted to stable got reintroduced in
>   experimental when rebasing this patch on master
>
Acked-by: Michael Santana <msantana@redhat.com>
> ---
>  lib/librte_eal/rte_eal_version.map | 115 ++++++++++++++++++++-----------------
>  1 file changed, 63 insertions(+), 52 deletions(-)
>
> diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
> index 2344877..7cbf82d 100644
> --- a/lib/librte_eal/rte_eal_version.map
> +++ b/lib/librte_eal/rte_eal_version.map
> @@ -315,91 +315,101 @@ DPDK_19.08 {
>  EXPERIMENTAL {
>         global:
>
> -       rte_class_find;
> -       rte_class_find_by_name;
> -       rte_class_register;
> -       rte_class_unregister;
> -       rte_delay_us_sleep;
> -       rte_dev_dma_map;
> -       rte_dev_dma_unmap;
> -       rte_dev_event_callback_process;
> +       # added in 18.02
> +       rte_mp_action_register;
> +       rte_mp_action_unregister;
> +       rte_mp_reply;
> +       rte_mp_sendmsg;
> +
> +       # added in 18.05
>         rte_dev_event_callback_register;
>         rte_dev_event_callback_unregister;
>         rte_dev_event_monitor_start;
>         rte_dev_event_monitor_stop;
> -       rte_dev_hotplug_handle_disable;
> -       rte_dev_hotplug_handle_enable;
> -       rte_dev_iterator_init;
> -       rte_dev_iterator_next;
> -       rte_extmem_attach;
> -       rte_extmem_detach;
> -       rte_extmem_register;
> -       rte_extmem_unregister;
>         rte_fbarray_attach;
>         rte_fbarray_destroy;
>         rte_fbarray_detach;
>         rte_fbarray_dump_metadata;
> +       rte_fbarray_find_contig_free;
> +       rte_fbarray_find_contig_used;
>         rte_fbarray_find_idx;
> -       rte_fbarray_find_biggest_free;
> -       rte_fbarray_find_biggest_used;
>         rte_fbarray_find_next_free;
> -       rte_fbarray_find_next_used;
>         rte_fbarray_find_next_n_free;
>         rte_fbarray_find_next_n_used;
> -       rte_fbarray_find_prev_free;
> -       rte_fbarray_find_prev_used;
> -       rte_fbarray_find_prev_n_free;
> -       rte_fbarray_find_prev_n_used;
> -       rte_fbarray_find_contig_free;
> -       rte_fbarray_find_contig_used;
> -       rte_fbarray_find_rev_biggest_free;
> -       rte_fbarray_find_rev_biggest_used;
> -       rte_fbarray_find_rev_contig_free;
> -       rte_fbarray_find_rev_contig_used;
> +       rte_fbarray_find_next_used;
>         rte_fbarray_get;
>         rte_fbarray_init;
>         rte_fbarray_is_used;
>         rte_fbarray_set_free;
>         rte_fbarray_set_used;
> -       rte_intr_callback_unregister_pending;
>         rte_log_register_type_and_pick_level;
>         rte_malloc_dump_heaps;
> -       rte_malloc_heap_create;
> -       rte_malloc_heap_destroy;
> -       rte_malloc_heap_get_socket;
> -       rte_malloc_heap_memory_add;
> -       rte_malloc_heap_memory_attach;
> -       rte_malloc_heap_memory_detach;
> -       rte_malloc_heap_memory_remove;
> -       rte_malloc_heap_socket_is_external;
>         rte_mem_alloc_validator_register;
>         rte_mem_alloc_validator_unregister;
>         rte_mem_check_dma_mask;
> -       rte_mem_check_dma_mask_thread_unsafe;
>         rte_mem_event_callback_register;
>         rte_mem_event_callback_unregister;
>         rte_mem_iova2virt;
> -       rte_mem_set_dma_mask;
>         rte_mem_virt2memseg;
>         rte_mem_virt2memseg_list;
>         rte_memseg_contig_walk;
> +       rte_memseg_list_walk;
> +       rte_memseg_walk;
> +       rte_mp_request_async;
> +       rte_mp_request_sync;
> +
> +       # added in 18.08
> +       rte_class_find;
> +       rte_class_find_by_name;
> +       rte_class_register;
> +       rte_class_unregister;
> +       rte_dev_iterator_init;
> +       rte_dev_iterator_next;
> +       rte_fbarray_find_prev_free;
> +       rte_fbarray_find_prev_n_free;
> +       rte_fbarray_find_prev_n_used;
> +       rte_fbarray_find_prev_used;
> +       rte_fbarray_find_rev_contig_free;
> +       rte_fbarray_find_rev_contig_used;
>         rte_memseg_contig_walk_thread_unsafe;
> +       rte_memseg_list_walk_thread_unsafe;
> +       rte_memseg_walk_thread_unsafe;
> +
> +       # added in 18.11
> +       rte_delay_us_sleep;
> +       rte_dev_event_callback_process;
> +       rte_dev_hotplug_handle_disable;
> +       rte_dev_hotplug_handle_enable;
> +       rte_malloc_heap_create;
> +       rte_malloc_heap_destroy;
> +       rte_malloc_heap_get_socket;
> +       rte_malloc_heap_memory_add;
> +       rte_malloc_heap_memory_attach;
> +       rte_malloc_heap_memory_detach;
> +       rte_malloc_heap_memory_remove;
> +       rte_malloc_heap_socket_is_external;
> +       rte_mem_check_dma_mask_thread_unsafe;
> +       rte_mem_set_dma_mask;
>         rte_memseg_get_fd;
>         rte_memseg_get_fd_offset;
> -       rte_memseg_get_fd_thread_unsafe;
>         rte_memseg_get_fd_offset_thread_unsafe;
> -       rte_memseg_list_walk;
> -       rte_memseg_list_walk_thread_unsafe;
> -       rte_memseg_walk;
> -       rte_memseg_walk_thread_unsafe;
> -       rte_mp_action_register;
> -       rte_mp_action_unregister;
> -       rte_mp_reply;
> -       rte_mp_request_sync;
> -       rte_mp_request_async;
> -       rte_mp_sendmsg;
> +       rte_memseg_get_fd_thread_unsafe;
>         rte_option_register;
> -       rte_rand_max;
> +
> +       # added in 19.02
> +       rte_extmem_attach;
> +       rte_extmem_detach;
> +       rte_extmem_register;
> +       rte_extmem_unregister;
> +
> +       # added in 19.05
> +       rte_dev_dma_map;
> +       rte_dev_dma_unmap;
> +       rte_fbarray_find_biggest_free;
> +       rte_fbarray_find_biggest_used;
> +       rte_fbarray_find_rev_biggest_free;
> +       rte_fbarray_find_rev_biggest_used;
> +       rte_intr_callback_unregister_pending;
>         rte_realloc_socket;
>
>         # added in 19.08
> @@ -408,4 +418,5 @@ EXPERIMENTAL {
>         rte_lcore_to_cpu_id;
>         rte_mcfg_timer_lock;
>         rte_mcfg_timer_unlock;
> +       rte_rand_max;
>  };
> --
> 1.8.3.1
>

Re: [dpdk-dev] [PATCH v3] eal: sort experimental symbols per release

[Thomas Monjalon]

29/07/2019 17:10, Michael Santana Francisco:
> On Sat, Jul 27, 2019 at 3:21 AM David Marchand
> <david.marchand@redhat.com> wrote:
> >
> > Sort the experimental symbols per release to make it easier/quicker to
> > check for how long we have them.
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > ---
> > Changelog since v2:
> > - fixed alphabetical order per release
> >
> > Changelog since v1:
> > - rte_service symbols who got promoted to stable got reintroduced in
> >   experimental when rebasing this patch on master
> >
> Acked-by: Michael Santana <msantana@redhat.com>

Applied, thanks