From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 584E7430F1; Thu, 24 Aug 2023 17:44:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E536A40EE1; Thu, 24 Aug 2023 17:44:26 +0200 (CEST) Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) by mails.dpdk.org (Postfix) with ESMTP id 8A8234067B for ; Thu, 24 Aug 2023 17:44:25 +0200 (CEST) Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-58fba83feb0so335497b3.3 for ; Thu, 24 Aug 2023 08:44:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1692891864; x=1693496664; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=vnCgXbTW9fKa2LgKNSPsVgKLiswYrv1inq6BW1vSU9A=; b=C/1t4941a4Bim/0CJHB9e5SypsN+HRNJbo69ryIB2DxstSYlTeARcwhlCou6uXZ75/ YWIhZTmuhqixCz/n2SAL4BUZojXiOt8bwDKyxsNvBdMHRCczqTKtYHZfjtFZPrX/ZLjT eb3PYh/RmySFwto7ggr/ZneVQEGicdoLISj3I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692891864; x=1693496664; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vnCgXbTW9fKa2LgKNSPsVgKLiswYrv1inq6BW1vSU9A=; b=f9jp6M/Gds2O65qvc425co46+EFLv5AMUiO4eLgAgC3Qh42Md26MMaapo2HRPiyC4/ PJLOuQHNu30mKlc8CMFV0Pz/3RqywinPXann4p4gFR+F5JKdDh5LSMXonPWK/AnagxVK WYkXQ0d8ypze6pS0TvYR7NTs/fPH2eF0RNa7cszsvtuGO6UnSUpXlQdYQrep7b1qRb++ JHMUo/HXAeieOwUCWwv7HwleRVcekYh+lNZnmlWjviE4qpOJlogXcZJShCb7MiOy7u1d BFVYJ+SfHEKzK4mxVJhZ1UtZGa8roKejtPVqGtPFVwhbgqRrO9gGhnM/DTgisMcQGllj K/SQ== X-Gm-Message-State: AOJu0YyrR30pHK1pJ+TguS9/KQLNI5chUNXt3xGJDjVA6rmUljGkGprI zkN69wQOvkTF8P7LxIBf6lSv0MNZW5oYuzdJSB5JPQ== X-Google-Smtp-Source: AGHT+IEX5Cxz2DshXYioqumvgm2MUKCf2CJNwvK5OrMg6SKdHQhdcpR2ii6gyVvCfxrpt7sI5gq5tkHvqTVFoeN7bi0= X-Received: by 2002:a0d:c7c5:0:b0:570:89bf:6f10 with SMTP id j188-20020a0dc7c5000000b0057089bf6f10mr13465699ywd.25.1692891864715; Thu, 24 Aug 2023 08:44:24 -0700 (PDT) MIME-Version: 1.0 References: <20230803075038.307012-1-david.marchand@redhat.com> In-Reply-To: <20230803075038.307012-1-david.marchand@redhat.com> From: Adam Hassick Date: Thu, 24 Aug 2023 11:44:53 -0400 Message-ID: Subject: Re: [PATCH 00/14] Cleanup PCI(e) drivers To: David Marchand Cc: dev@dpdk.org Content-Type: multipart/alternative; boundary="0000000000003d6bbf0603ad1a60" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000003d6bbf0603ad1a60 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Recheck-request: iol-sample-apps-testing This is a test of the retesting system, please ignore this email. On Thu, Aug 3, 2023 at 3:50=E2=80=AFAM David Marchand wrote: > Rather than rely on Linux headers to find some PCI(e) standard constants > or reinvent the same PCI capability helper, this series complements the > pci library and the pci bus driver. > PCI drivers can then use OS agnostic macros and helpers. > > WARNING: this is only compile tested. > > -- > David Marchand > > David Marchand (14): > drivers: remove duplicated PCI master control > bus/pci: add const to some experimental API > bus/pci: find PCI capability > pci: define some capability constants > pci: define some MSIX constants > pci: define some command constants > pci: define some BAR constants > pci: define some PM constants > pci: define some PCIe constants > pci: define some extended capability constants > pci: define some ACS constants > pci: define some PRI constants > pci: define some AER constants > devtools: forbid inclusion of Linux header for PCI > > devtools/checkpatches.sh | 8 ++ > drivers/bus/pci/linux/pci_init.h | 18 ---- > drivers/bus/pci/linux/pci_uio.c | 32 +----- > drivers/bus/pci/linux/pci_vfio.c | 142 ++++++------------------- > drivers/bus/pci/pci_common.c | 49 ++++++++- > drivers/bus/pci/rte_bus_pci.h | 35 ++++++- > drivers/bus/pci/version.map | 2 + > drivers/crypto/virtio/virtio_pci.c | 67 ++++-------- > drivers/event/dlb2/pf/dlb2_main.c | 156 ++++++++-------------------- > drivers/net/bnx2x/bnx2x.c | 86 ++++++++------- > drivers/net/bnx2x/bnx2x.h | 46 -------- > drivers/net/cxgbe/base/adapter.h | 31 +----- > drivers/net/gve/gve_ethdev.c | 46 +------- > drivers/net/gve/gve_ethdev.h | 14 +-- > drivers/net/hns3/hns3_ethdev_vf.c | 109 +++---------------- > drivers/net/ngbe/base/ngbe_hw.c | 20 +--- > drivers/net/ngbe/base/ngbe_osdep.h | 3 - > drivers/net/virtio/virtio_pci.c | 131 ++++------------------- > drivers/vdpa/ifc/base/ifcvf_osdep.h | 4 +- > lib/pci/rte_pci.h | 77 +++++++++++++- > 20 files changed, 346 insertions(+), 730 deletions(-) > > -- > 2.41.0 > > --0000000000003d6bbf0603ad1a60 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Recheck-request: iol-sample-apps-tes= ting

This is a test of the retesting system, please ignore thi= s email.

On Thu, Aug 3, 2023 at 3:50=E2=80=AFAM David Marchand <david.marchand@redhat.com> w= rote:
Rather tha= n rely on Linux headers to find some PCI(e) standard constants
or reinvent the same PCI capability helper, this series complements the
pci library and the pci bus driver.
PCI drivers can then use OS agnostic macros and helpers.

WARNING: this is only compile tested.

--
David Marchand

David Marchand (14):
=C2=A0 drivers: remove duplicated PCI master control
=C2=A0 bus/pci: add const to some experimental API
=C2=A0 bus/pci: find PCI capability
=C2=A0 pci: define some capability constants
=C2=A0 pci: define some MSIX constants
=C2=A0 pci: define some command constants
=C2=A0 pci: define some BAR constants
=C2=A0 pci: define some PM constants
=C2=A0 pci: define some PCIe constants
=C2=A0 pci: define some extended capability constants
=C2=A0 pci: define some ACS constants
=C2=A0 pci: define some PRI constants
=C2=A0 pci: define some AER constants
=C2=A0 devtools: forbid inclusion of Linux header for PCI

=C2=A0devtools/checkpatches.sh=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |= =C2=A0 =C2=A08 ++
=C2=A0drivers/bus/pci/linux/pci_init.h=C2=A0 =C2=A0 |=C2=A0 18 ----
=C2=A0drivers/bus/pci/linux/pci_uio.c=C2=A0 =C2=A0 =C2=A0|=C2=A0 32 +-----<= br> =C2=A0drivers/bus/pci/linux/pci_vfio.c=C2=A0 =C2=A0 | 142 ++++++-----------= --------
=C2=A0drivers/bus/pci/pci_common.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 49 ++= ++++++-
=C2=A0drivers/bus/pci/rte_bus_pci.h=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 35 ++= ++++-
=C2=A0drivers/bus/pci/version.map=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 = =C2=A02 +
=C2=A0drivers/crypto/virtio/virtio_pci.c=C2=A0 |=C2=A0 67 ++++--------
=C2=A0drivers/event/dlb2/pf/dlb2_main.c=C2=A0 =C2=A0| 156 ++++++++---------= -----------
=C2=A0drivers/net/bnx2x/bnx2x.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|= =C2=A0 86 ++++++++-------
=C2=A0drivers/net/bnx2x/bnx2x.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|= =C2=A0 46 --------
=C2=A0drivers/net/cxgbe/base/adapter.h=C2=A0 =C2=A0 |=C2=A0 31 +-----
=C2=A0drivers/net/gve/gve_ethdev.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 46 +-= ------
=C2=A0drivers/net/gve/gve_ethdev.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 14 +-= -
=C2=A0drivers/net/hns3/hns3_ethdev_vf.c=C2=A0 =C2=A0| 109 +++--------------= --
=C2=A0drivers/net/ngbe/base/ngbe_hw.c=C2=A0 =C2=A0 =C2=A0|=C2=A0 20 +--- =C2=A0drivers/net/ngbe/base/ngbe_osdep.h=C2=A0 |=C2=A0 =C2=A03 -
=C2=A0drivers/net/virtio/virtio_pci.c=C2=A0 =C2=A0 =C2=A0| 131 ++++--------= -----------
=C2=A0drivers/vdpa/ifc/base/ifcvf_osdep.h |=C2=A0 =C2=A04 +-
=C2=A0lib/pci/rte_pci.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0|=C2=A0 77 +++++++++++++-
=C2=A020 files changed, 346 insertions(+), 730 deletions(-)

--
2.41.0

--0000000000003d6bbf0603ad1a60--