From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 257D745E47; Sat, 7 Dec 2024 18:47:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 969CC4025E; Sat, 7 Dec 2024 18:47:57 +0100 (CET) Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by mails.dpdk.org (Postfix) with ESMTP id 3F6C6400D6 for ; Sat, 7 Dec 2024 18:47:56 +0100 (CET) Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-7ee51d9ae30so2148689a12.1 for ; Sat, 07 Dec 2024 09:47:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733593675; x=1734198475; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=81kIc11kDVd7rjDKJUkvlsBMqgE7y40ejOyXKWEW3JU=; b=XeANgvMHYoppkXmnyCosqnFEXsj8ul+r6ChOkMSDLs9xK/PkeA49P4dinuFgBsEg1r 8Dr2O/WgtGxMmEPpXNCLNGa6jOsCRDjaEMG+vKm0QXnOvxCJQ1Yk0K1bqPIkqbWxWo9D A0mQy3Li39TsceXjq6OVu3fdVlqc0H4cj38dEgVIwJR8ZAF45++cfapMEaHbA3Sl6GZu CqO6mp8WEMkcj3kiVVt5lnygeokrxA7OEYKfTVZWrhnWSTu67jLnJoPg+BUS5V8/717l O6LpOXY7CBPWDfWlivPLckYsCJVYxHZ0/f9vcDtfAJKWH9rAIvGIwKb/dmbEiVefTbVD ApCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733593675; x=1734198475; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=81kIc11kDVd7rjDKJUkvlsBMqgE7y40ejOyXKWEW3JU=; b=TW0nhWOI7wwc2FGV0ob+OqBGFp8Y9Eki2mYAgUsTDha+WNf6o1VUnzJElRSTUbVBRj PcReyx234WsEP5lfmcEnemYj41IvQ5sA34L7j3FC+qbS533XRoCZx2VL89vrSRY9EDe9 K02L28gtqOgyq1mI751p4aUpKBaECKaziZfKGN8oXV7tijeaMwqrBwB/UoC85ApqmDTk R3PZ5cwgS1RfzdK5XLTASF2zddzIn26O/6i3xnuPDnRBUyEKKSOa9epXPn7I7+4FvEVi 4TeGNSuyCbd6CYTYBRyzZhv4Z6wrge7idmYesz+XboFpib/szUXmKKGJzHTz9Pw2mUfY tqEA== X-Gm-Message-State: AOJu0YwdBMl+4qsHcGUDUw2cNw5wXWJ2otHjPP5gVEbXLJH29eRM5PQO h4oZQFJbgpHVpgMWiE/WAbxhrg30Opn5Ob9ExrLh1FsyRzViBP41eS5wCmlU7KdcdL/JdBWRdk8 ZRQJ4l5RAzhN315dh61gf6QyQJ2o= X-Gm-Gg: ASbGnct/dFx/hyFIF4NzyHFzcFT8tSh1Dpy0NW4Dhg5D56ZVEWUNLXfaNJG5W9zfj4M w0fJV2ryhrjEG9MHYTSdJg7htE/Ap+Vj5 X-Google-Smtp-Source: AGHT+IHliTW2MP/w/7bBKsDXnODEqgjFHs+KoKgaNoneZa9yYC/6rH6PYJiUrwBb7DCcyaQRRWFfDUbD3+e0hcCqyS0= X-Received: by 2002:a17:90b:2e8e:b0:2ee:cd83:8fc3 with SMTP id 98e67ed59e1d1-2ef6aaf3ecbmr11791702a91.37.1733593675184; Sat, 07 Dec 2024 09:47:55 -0800 (PST) MIME-Version: 1.0 References: <20240917115147.378146-1-iboukris@gmail.com> <20241203095654.1f050da2@hermes.local> In-Reply-To: <20241203095654.1f050da2@hermes.local> From: Isaac Boukris Date: Sat, 7 Dec 2024 19:47:44 +0200 Message-ID: Subject: Re: [PATCH] net/tap: add new macpair option for split MAC address To: Stephen Hemminger Cc: dev@dpdk.org, mb@smartsharesystems.com, Ferruh Yigit Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Stephen, > 2. Need more error checks. macpair won't work with TUN device. > and what happens if mac address is specified? Following Ferruh's feedback, and since the use-case is a bit different, I was thinking perhaps it would make more sense to add this functionality as a new device type rather than piggyback on the tap device (like --vdev=net_veth). This would allow for better isolation, both in code and in the configuration options, and would also be more accurate as the dpdk device is completely virtual while the tap device is the peer one. > 3. Should the mac address devarg, take two args? If we go with net_veth as above, then we can either drop the mac address option for simplicity, and let the user set them manually (the dpdk interface via dpdk API, and the kernel interface via ip / ifconfig), or provide an option to set either or both mac addresses as preferred. If it sounds good, I'll rework the patch first to implement it as a new net_veth device, post it, and then try to work out some basic tests (the latter might take some time tbh). Thanks!