From: Isaac Boukris <iboukris@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [PATCH] net/tap: add new macpair option for split MAC address
Date: Tue, 17 Sep 2024 09:48:51 +0300 [thread overview]
Message-ID: <CAC-fF8Td0AoNJ5Wj4tJ0U7NqrEvvqVNeu4ht6csoWeHOhc7EXg@mail.gmail.com> (raw)
In-Reply-To: <20240916203602.62f8f66e@hermes.local>
Hi Stephen
On Tue, Sep 17, 2024 at 6:36 AM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Mon, 16 Sep 2024 20:38:51 +0300
> Isaac Boukris <iboukris@gmail.com> wrote:
>
> > + if (mac_pair) {
> > + struct rte_ether_addr *mac;
> > + mac = (struct rte_ether_addr*)ifr.ifr_hwaddr.sa_data;
> > + mac->addr_bytes[3]++;
>
> You need to generate a new MAC to be safe, just incrementing by one can
> easily cause address conflicts.
I assumed these two MACs would be the only ones connected to the link,
so it should be ok. If I generate a new random one, should I just
assume it is unlikely I got the same?
next prev parent reply other threads:[~2024-09-17 6:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 17:38 Isaac Boukris
2024-09-17 3:34 ` Stephen Hemminger
2024-09-17 3:36 ` Stephen Hemminger
2024-09-17 6:48 ` Isaac Boukris [this message]
2024-09-17 7:38 ` Morten Brørup
2024-09-17 11:51 Isaac Boukris
2024-09-17 12:14 ` Isaac Boukris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAC-fF8Td0AoNJ5Wj4tJ0U7NqrEvvqVNeu4ht6csoWeHOhc7EXg@mail.gmail.com \
--to=iboukris@gmail.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).