From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0B980459BA; Tue, 17 Sep 2024 08:49:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AAB0440267; Tue, 17 Sep 2024 08:49:06 +0200 (CEST) Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by mails.dpdk.org (Postfix) with ESMTP id 6740E40267 for ; Tue, 17 Sep 2024 08:49:04 +0200 (CEST) Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-2daaa9706a9so4301348a91.1 for ; Mon, 16 Sep 2024 23:49:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726555743; x=1727160543; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Mmyqo5bpW9JTYgkiCXR+DbrBfBRiVx5OIJ6wXwuSIaE=; b=HoDKSErUFBQiAGb/B2dGtIraiuAlFTELjvfBdMeuXYS+bcn+2nhE2ZwpI8xd60H8VQ LYDdL6SJ+DvwVYNnHYi/apd95A8VDBs/4bMrfmZYWZE5u8NOJXh9YMXkIze63QKcKWay riQtqMf/ZW/U03yBlwW2Vpf0sy8xl7mMSAHEy3yRbA5bZqg6pggsxT4Wf17Y1iS0o9B/ sxrD4ZIFjmtxoOXEsWlm9IueOgxKN3F9qfKbzPTnzuFjOXTZnQjapsXz2U3+hzpqSaZN Qt04WaCm4B5XGD/8jTbDutN07eIi4Rm3rRSJeTysfkO6tDzU4VwLJ6SBawEBPnxkXzU5 e3WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726555743; x=1727160543; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Mmyqo5bpW9JTYgkiCXR+DbrBfBRiVx5OIJ6wXwuSIaE=; b=cWzQbMbMADEgLbPSSVJcQThaW56DGf4VWgKqW4/oEvzOhhufpCTqpEv6hlGJ7l11BK wgbpXzFv8m+qvFnhAuRireDce2AZ7Bpxa70YCM55Ujo9PWP6V7pL17h3gAtKttmLjMS2 eyMEbwcW18sQ2kjmH9WcIKYUfmPapFWqrjcNLvuAN+v19ujdriyRJ74GGQtmSKnqtP/U HyoLvEqI6oJXZqfFrC/J3Md87kpGF8dcgZEIDUXCCfPjs6sbf0L8rNG/k8huAbPM2+eo BeW/XJMjaFRFhOjhF5jDba4/tfmreLmvjGIwhBNeQPHVhSz73n86qIhjLGXuJlvnZPC4 NB8g== X-Gm-Message-State: AOJu0Yziij+CyZsYeXtTkrd3LRZl+Pwfg5cJ+0yztWEAEEwxgk7596eT 4E9OeYdSm6tHNj1/WSTBTrfaRgKu48F91iIWGcmcVtE84rsfl61tjhfLtihwMFbI5awnLfx2tuD Gwr+6DRxifIpyRq1LSY70W6v1LGcWng== X-Google-Smtp-Source: AGHT+IHM1yB06+X3GyMBM56LojHaTPizAehDH0I6ZeLT7v84+57PqSQS79qdHBCBl79yZHXXBsRQgvFl2sxG0+7JvqA= X-Received: by 2002:a17:90a:6685:b0:2da:5acc:4e9c with SMTP id 98e67ed59e1d1-2dba0062a71mr21650037a91.29.1726555743182; Mon, 16 Sep 2024 23:49:03 -0700 (PDT) MIME-Version: 1.0 References: <20240916173851.369395-1-iboukris@gmail.com> <20240916203602.62f8f66e@hermes.local> In-Reply-To: <20240916203602.62f8f66e@hermes.local> From: Isaac Boukris Date: Tue, 17 Sep 2024 09:48:51 +0300 Message-ID: Subject: Re: [PATCH] net/tap: add new macpair option for split MAC address To: Stephen Hemminger Cc: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Stephen On Tue, Sep 17, 2024 at 6:36=E2=80=AFAM Stephen Hemminger wrote: > > On Mon, 16 Sep 2024 20:38:51 +0300 > Isaac Boukris wrote: > > > + if (mac_pair) { > > + struct rte_ether_addr *mac; > > + mac =3D (struct rte_ether_addr*)ifr.ifr_hwaddr.sa= _data; > > + mac->addr_bytes[3]++; > > You need to generate a new MAC to be safe, just incrementing by one can > easily cause address conflicts. I assumed these two MACs would be the only ones connected to the link, so it should be ok. If I generate a new random one, should I just assume it is unlikely I got the same?