From: Radha Mohan <mohun106@gmail.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Radha Mohan Chintakuntla <radhac@marvell.com>,
Chengwen Feng <fengchengwen@huawei.com>, dpdk-dev <dev@dpdk.org>,
Satananda Burla <sburla@marvell.com>
Subject: Re: [dpdk-dev] [PATCH] usertools/devbind: update octeontx2 DMA device
Date: Tue, 9 Nov 2021 15:24:11 -0800 [thread overview]
Message-ID: <CAC8NTUWBkSYytbOa3WrrzyZ3kUWipFegRqrHduSAT4C=KxqiNQ@mail.gmail.com> (raw)
In-Reply-To: <6995554.cnLEcGnZd8@thomas>
On Tue, Nov 9, 2021 at 12:50 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 09/11/2021 17:55, Radha Mohan Chintakuntla:
> > The octeontx2_dma rawdev driver is removed in DPDK-21.11. The new driver
> > for the same device uses the dmadev. So this patch updates the device
> > naming and lists it under dma devices section.
> >
> > Signed-off-by: Radha Mohan Chintakuntla <radhac@marvell.com>
> > ---
> > usertools/dpdk-devbind.py | 11 ++++++-----
> > 1 file changed, 6 insertions(+), 5 deletions(-)
> >
> > diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
> > index af9a0ad5ab..e298ad5f75 100755
> > --- a/usertools/dpdk-devbind.py
> > +++ b/usertools/dpdk-devbind.py
> > @@ -41,8 +41,8 @@
> > 'SVendor': None, 'SDevice': None}
> > octeontx2_npa = {'Class': '08', 'Vendor': '177d', 'Device': 'a0fb,a0fc',
> > 'SVendor': None, 'SDevice': None}
> > -octeontx2_dma = {'Class': '08', 'Vendor': '177d', 'Device': 'a081',
> > - 'SVendor': None, 'SDevice': None}
> > +cnxk_dma = {'Class': '08', 'Vendor': '177d', 'Device': 'a081',
> > + 'SVendor': None, 'SDevice': None}
>
> It doesn't look logical to have cnxk device in the middle of octeontx2 ones.
> Maybe before to sort it a bit alphabetically?
ok sure will do. I thought about it but rest of them were not in any
order so didn't think it wouldn't matter.
>
> > dma_devices = [hisilicon_dma,
> > - intel_idxd_spr, intel_ioat_bdw, intel_ioat_icx, intel_ioat_skx]
> > + intel_idxd_spr, intel_ioat_bdw, intel_ioat_icx, intel_ioat_skx,
> > + cnxk_dma]
>
> Would be better at the beginning of the list, before hisilicon
> so it is alphabetically sorted.
ok.
>
>
>
next prev parent reply other threads:[~2021-11-09 23:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 16:55 Radha Mohan Chintakuntla
2021-11-09 20:50 ` Thomas Monjalon
2021-11-09 23:24 ` Radha Mohan [this message]
2021-11-09 23:32 ` [dpdk-dev] [PATCH v2] " Radha Mohan Chintakuntla
2021-11-10 13:16 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAC8NTUWBkSYytbOa3WrrzyZ3kUWipFegRqrHduSAT4C=KxqiNQ@mail.gmail.com' \
--to=mohun106@gmail.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=radhac@marvell.com \
--cc=sburla@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).