From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB6AB42966; Mon, 17 Apr 2023 05:11:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6A49040DFB; Mon, 17 Apr 2023 05:11:00 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id F1D1D40698 for ; Mon, 17 Apr 2023 05:10:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681701058; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NQ0xrkQ9aThzLdbiCDVd/BDkjfCbuDJsnwF19Q9Xknc=; b=GxZRJMBdhmNUTNSAuqWeeIA81/KzfvvAqzM81vBgVlVo6z6s+RZS4jtyq1CbLEtbxzInWE 0jIyuMwmVNQrmO5Xtiho7DpKDxue0XSXJHjSvz7XcyV1nAuM13lGvMdOt/giiytHefIEPo 05SDtOYu4WynR3ualGs8jqPrHqobXu0= Received: from mail-ot1-f71.google.com (mail-ot1-f71.google.com [209.85.210.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-127-TjK97gQ8PZ202J3GGtcXug-1; Sun, 16 Apr 2023 23:10:56 -0400 X-MC-Unique: TjK97gQ8PZ202J3GGtcXug-1 Received: by mail-ot1-f71.google.com with SMTP id b17-20020a056830105100b006a42f47618fso2735956otp.19 for ; Sun, 16 Apr 2023 20:10:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681701056; x=1684293056; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NQ0xrkQ9aThzLdbiCDVd/BDkjfCbuDJsnwF19Q9Xknc=; b=iLgATccMeSUFbCGTZiHpC76ubpyyXd+1l534wxXrwTmk2UePgJatb7JzwmoWPoQ6JP W2zc/yK7oLIz6ynyPSSnpFPoS1cxdEbeaQJl4pvu8CQvVQFV99weztHfBuneJjJOGpFB ycuuaianZ/iCVnRLO4Ju7F+57TsGgVazr0AjH4Rs1KpRMmOHvZJHAeTsL6ByQf3TbyGS u4xdApju6B79dMPfRY/bFG+rzC6mVwLqY1epiM9QE22ITPNb0xY290btp/smv2VsUld9 KHMLDFdBiYvUQxG7CYD/vdWdcwc4jECJtnAqVyYXGQHZ/Ffsk3QczQx672yEMQG7LyHc DWoQ== X-Gm-Message-State: AAQBX9e1tJWastCuqMwsQlO2A8GCZfTyFbnFF5DNSZjIrsPhQm1uraRb O+S2msoDgOOUiHY/oju33ktdocnj1QJma2DJ9CMhJAhAU/NsDROt3CX1eMpzkU6sz5lJ62ZmVAU 8qai5bk/ceRkbjCc1wP4= X-Received: by 2002:a05:6870:c34e:b0:187:89c5:1efa with SMTP id e14-20020a056870c34e00b0018789c51efamr5990451oak.9.1681701056096; Sun, 16 Apr 2023 20:10:56 -0700 (PDT) X-Google-Smtp-Source: AKy350ZaaxiIJhmKHQPWfnw7l7ArRkAfxoZHPZFsu6oZuy0lRcuv03L6dWICW2ElyDWRgXN4zbtP7iu5AgZ8VCPdg1s= X-Received: by 2002:a05:6870:c34e:b0:187:89c5:1efa with SMTP id e14-20020a056870c34e00b0018789c51efamr5990428oak.9.1681701055870; Sun, 16 Apr 2023 20:10:55 -0700 (PDT) MIME-Version: 1.0 References: <20230331154259.1447831-1-maxime.coquelin@redhat.com> <3789c0c7-281b-89c3-45aa-3d985736b04a@amd.com> <107f53d8-c0c3-68a8-1857-4b6ef0165b48@redhat.com> <98CBD80474FA8B44BF855DF32C47DC35D8786B@smartserver.smartshare.dk> <58480498-8037-ec45-548a-8027e185fcaf@redhat.com> <94efd072-ae82-60ca-a84b-529b69db2810@redhat.com> In-Reply-To: From: Jason Wang Date: Mon, 17 Apr 2023 11:10:44 +0800 Message-ID: Subject: Re: [RFC 00/27] Add VDUSE support to Vhost library To: Ferruh Yigit Cc: Maxime Coquelin , "Xia, Chenbo" , =?UTF-8?Q?Morten_Br=C3=B8rup?= , "dev@dpdk.org" , "david.marchand@redhat.com" , "mkp@redhat.com" , "fbl@redhat.com" , "Liang, Cunming" , "Xie, Yongji" , "echaudro@redhat.com" , "eperezma@redhat.com" , "amorenoz@redhat.com" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Apr 14, 2023 at 10:25=E2=80=AFPM Ferruh Yigit wrote: > > On 4/14/2023 1:06 PM, Maxime Coquelin wrote: > > > > > > On 4/14/23 12:48, Ferruh Yigit wrote: > >> On 4/13/2023 8:59 AM, Maxime Coquelin wrote: > >>> Hi, > >>> > >>> On 4/13/23 09:08, Xia, Chenbo wrote: > >>>>> -----Original Message----- > >>>>> From: Morten Br=C3=B8rup > >>>>> Sent: Thursday, April 13, 2023 3:41 AM > >>>>> To: Maxime Coquelin ; Ferruh Yigit > >>>>> ; dev@dpdk.org; david.marchand@redhat.com; Xi= a, > >>>>> Chenbo ; mkp@redhat.com; fbl@redhat.com; > >>>>> jasowang@redhat.com; Liang, Cunming ; Xie, > >>>>> Yongji > >>>>> ; echaudro@redhat.com; eperezma@redhat.com= ; > >>>>> amorenoz@redhat.com > >>>>> Subject: RE: [RFC 00/27] Add VDUSE support to Vhost library > >>>>> > >>>>>> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com] > >>>>>> Sent: Wednesday, 12 April 2023 17.28 > >>>>>> > >>>>>> Hi Ferruh, > >>>>>> > >>>>>> On 4/12/23 13:33, Ferruh Yigit wrote: > >>>>>>> On 3/31/2023 4:42 PM, Maxime Coquelin wrote: > >>>>>>>> This series introduces a new type of backend, VDUSE, > >>>>>>>> to the Vhost library. > >>>>>>>> > >>>>>>>> VDUSE stands for vDPA device in Userspace, it enables > >>>>>>>> implementing a Virtio device in userspace and have it > >>>>>>>> attached to the Kernel vDPA bus. > >>>>>>>> > >>>>>>>> Once attached to the vDPA bus, it can be used either by > >>>>>>>> Kernel Virtio drivers, like virtio-net in our case, via > >>>>>>>> the virtio-vdpa driver. Doing that, the device is visible > >>>>>>>> to the Kernel networking stack and is exposed to userspace > >>>>>>>> as a regular netdev. > >>>>>>>> > >>>>>>>> It can also be exposed to userspace thanks to the > >>>>>>>> vhost-vdpa driver, via a vhost-vdpa chardev that can be > >>>>>>>> passed to QEMU or Virtio-user PMD. > >>>>>>>> > >>>>>>>> While VDUSE support is already available in upstream > >>>>>>>> Kernel, a couple of patches are required to support > >>>>>>>> network device type: > >>>>>>>> > >>>>>>>> https://gitlab.com/mcoquelin/linux/-/tree/vduse_networking_poc > >>>>>>>> > >>>>>>>> In order to attach the created VDUSE device to the vDPA > >>>>>>>> bus, a recent iproute2 version containing the vdpa tool is > >>>>>>>> required. > >>>>>>> > >>>>>>> Hi Maxime, > >>>>>>> > >>>>>>> Is this a replacement to the existing DPDK vDPA framework? What > >>>>>>> is the > >>>>>>> plan for long term? > >>>>>>> > >>>>>> > >>>>>> No, this is not a replacement for DPDK vDPA framework. > >>>>>> > >>>>>> We (Red Hat) don't have plans to support DPDK vDPA framework in ou= r > >>>>>> products, but there are still contribution to DPDK vDPA by several > >>>>>> vDPA > >>>>>> hardware vendors (Intel, Nvidia, Xilinx), so I don't think it is > >>>>>> going > >>>>>> to be deprecated soon. > >>>>> > >>>>> Ferruh's question made me curious... > >>>>> > >>>>> I don't know anything about VDUSE or vDPA, and don't use any of it,= so > >>>>> consider me ignorant in this area. > >>>>> > >>>>> Is VDUSE an alternative to the existing DPDK vDPA framework? What a= re > >>>>> the > >>>>> differences, e.g. in which cases would an application developer (or > >>>>> user) > >>>>> choose one or the other? > >>>> > >>>> Maxime should give better explanation.. but let me just explain a bi= t. > >>>> > >>>> Vendors have vDPA HW that support vDPA framework (most likely in the= ir > >>>> DPU/IPU > >>>> products). This work is introducing a way to emulate a SW vDPA > >>>> device in > >>>> userspace (DPDK), and this SW vDPA device also supports vDPA framewo= rk. > >>>> > >>>> So it's not an alternative to existing DPDK vDPA framework :) > >>> > >>> Correct. > >>> > >>> When using DPDK vDPA, the datapath of a Vhost-user port is offloaded = to > >>> a compatible physical NIC (i.e. a NIC that implements Virtio rings > >>> support), the control path remains the same as a regular Vhost-user > >>> port, i.e. it provides a Vhost-user unix socket to the application (l= ike > >>> QEMU or DPDK Virtio-user PMD). > >>> > >>> When using Kernel vDPA, the datapath is also offloaded to a vDPA > >>> compatible device, and the control path is managed by the vDPA bus. > >>> It can either be consumed by a Kernel Virtio device (here Virtio-net) > >>> when using Virtio-vDPA. In this case the device is exposed as a regul= ar > >>> netdev and, in the case of Kubernetes, can be used as primary interfa= ces > >>> for the pods. > >>> Or it can be exposed to user-space via Vhost-vDPA, a chardev that can= be > >>> seen as an alternative to Vhost-user sockets. In this case it can for > >>> example be used by QEMU or DPDK Virtio-user PMD. In Kubernetes, it ca= n > >>> be used as a secondary interface. > >>> > >>> Now comes VDUSE. VDUSE is a Kernel vDPA device, but instead of being = a > >>> physical device where the Virtio datapath is offloaded, the Virtio > >>> datapath is offloaded to a user-space application. With this series, = a > >>> DPDK application, like OVS-DPDK for instance, can create VDUSE device > >>> and expose them either as regular netdev when binding them to Kernel > >>> Virtio-net driver via Virtio-vDPA, or as Vhost-vDPA interface to be > >>> consumed by another userspace appliation like QEMU or DPDK applicatio= n > >>> using Virtio-user PMD. With this solution, OVS-DPDK could serve both > >>> primary and secondary interfaces of Kubernetes pods. > >>> > >>> I hope it clarifies, I will add these information in the cover-letter > >>> for next revisions. Let me know if anything is still unclear. > >>> > >>> I did a presentation at last DPDK summit [0], maybe the diagrams will > >>> help to clarify furthermore. > >>> > >> > >> Thanks Chenbo, Maxime for clarification. > >> > >> After reading a little more (I think) I got it better, slides [0] were > >> useful. > >> > >> So this is more like a backend/handler, similar to vhost-user, althoug= h > >> it is vDPA device emulation. > >> Can you please describe more the benefit of vduse comparing to > >> vhost-user? > > > > The main benefit is that VDUSE device can be exposed as a regular > > netdev, while this is not possible with Vhost-user. > > > > Got it, thanks. I think better to highlight this in commit logs. > > And out of curiosity, > Why there is no virtio(guest) to virtio(host) communication support > (without vdpa), something like adding virtio as backend to vhost-net, is > it not needed or technical difficulties? The main reason is that a lot of operations are not supported by virtio yet= : 1) virtqueue saving, restoring 2) provisioning and management 3) address space id etc Thanks > > >> Also what is "VDUSE daemon", which is referred a few times in > >> documentation, is it another userspace implementation of the vduse? > > > > VDUSE daemon is the application that implements the VDUSE device, e.g. > > OVS-DPDK with DPDK Vhost library using this series in our case. > > > > Maxime > >> > >>>>> > >>>>> And if it is a better alternative, perhaps the documentation should > >>>>> mention that it is recommended over DPDK vDPA. Just like we started > >>>>> recommending alternatives to the KNI driver, so we could phase it o= ut > >>>>> and > >>>>> eventually get rid of it. > >>>>> > >>>>>> > >>>>>> Regards, > >>>>>> Maxime > >>>> > >>> > >>> [0]: > >>> https://static.sched.com/hosted_files/dpdkuserspace22/9f/Open%20DPDK%= 20to%20containers%20networking%20with%20VDUSE.pdf > >>> > >> > > >