From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 20C75A0540;
	Wed,  6 Jul 2022 09:16:45 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id AE25E40DF7;
	Wed,  6 Jul 2022 09:16:44 +0200 (CEST)
Received: from mail-io1-f43.google.com (mail-io1-f43.google.com
 [209.85.166.43]) by mails.dpdk.org (Postfix) with ESMTP id 8411A40691
 for <dev@dpdk.org>; Wed,  6 Jul 2022 09:16:42 +0200 (CEST)
Received: by mail-io1-f43.google.com with SMTP id p128so13260802iof.1
 for <dev@dpdk.org>; Wed, 06 Jul 2022 00:16:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=emumba-com.20210112.gappssmtp.com; s=20210112;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to;
 bh=Wx1FKvoVLYsOGAaHBBaoWunCthR9satJOB9e22L7FmI=;
 b=IwOaPflkuH9nMSU2+UeD7hmfFg4yTjZ7P3x/fv/nvqcDhgOkbTkw7RsUc0DKUruRxU
 VYkGgxnVs14l8KaQ2wC8WVwz+4ajOb+mzSRf34bS6hZOnKNPWpR9ut9gd4SKCcDQSjIE
 Jq7BeqABBs8MfcWMiFCgh3829WZ4jIgPSi+sO5J0M98LVgwVaK/ouXrZGJJd5Uumu6T4
 toS6OKROZ9qyoPMsIS/xpNvXcEt81G2YA+/1vsWit2W0QqpQNWZljce22akJANZnbF4r
 dDRN97IZMg6N9JTtSzLz8m89HQTs2eRkyw4G204U/FpgmjzszMDZvMQxLcFhvyMgjVkF
 nRAA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to;
 bh=Wx1FKvoVLYsOGAaHBBaoWunCthR9satJOB9e22L7FmI=;
 b=yu7H09mEr8sfrD6D6PNK55pBkrYbkIEdaRI7goqj+YgbtVXI0njlUEUyGjG4vbDtYc
 PQwTzWNKYy+spUq7ULmY3iRJlqZPNLd936/XbEbcrBd9o+iTH5AIamCV8qH0+gQ0ufmm
 1dL37a0zcILeTQe0ooW7mQh+mzeNgHC6g4VPnx7pnm9knOCJcan0HcUKmOFjIrTcAm7d
 EgOQ/TKZOcTp5G+vvA4kjKP7JxunB2w4h2uhkkisJZNe6Ir9rrmxE9tt4+LP1B4axOcN
 bRA21BLck1CaG20ZabPRzJRuiAoAliSu1K0fCzsjfQQ29CjLikh+KOT2YvHFppYExwLq
 slWg==
X-Gm-Message-State: AJIora+cXG6PFABCghVttKE7I9dY9/QZmeuoZw2I2UJ+t43qrDGj0xma
 NeTagnkN3BU2kP0yGlAM67Sa8shQekX5VunILn7htl+X+Wk=
X-Google-Smtp-Source: AGRyM1vVMT4wq6VPZKg46wcwxdvfjKWmIApFkmOXUhN8lHJ65jMXiuB0bkZGcWaaM1J6U6apcjtvGqqJyMGQQc5l7hw=
X-Received: by 2002:a02:9682:0:b0:33c:6a7d:87ca with SMTP id
 w2-20020a029682000000b0033c6a7d87camr25282610jai.136.1657091801539; Wed, 06
 Jul 2022 00:16:41 -0700 (PDT)
MIME-Version: 1.0
References: <20220529142850.76501-1-jawad.hussain@emumba.com>
In-Reply-To: <20220529142850.76501-1-jawad.hussain@emumba.com>
From: Muhammad Jawad Hussain <jawad.hussain@emumba.com>
Date: Wed, 6 Jul 2022 12:16:30 +0500
Message-ID: <CACKbeL8jgFBKO-8wLQ7cdQQqBGZyNeWKR3LnuFg5pbBbQn4F4Q@mail.gmail.com>
Subject: Re: [PATCH v2] examples/ethtool: update rxmode to increase
 functionality
To: dev@dpdk.org
Content-Type: multipart/alternative; boundary="00000000000030f80e05e31dc073"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

--00000000000030f80e05e31dc073
Content-Type: text/plain; charset="UTF-8"

Hi,
I submitted this patch on 29th may,2022. I am getting a bad coding
style warning because I did not email version 2 in the reply of version 1.
Should I resend it in the reply?

Regards,
Jawad Hussain

On Sun, May 29, 2022 at 7:29 PM Muhammad Jawad Hussain <
jawad.hussain@emumba.com> wrote:

> previously rxmode functionality did not allow the user to choose
> between different vfs nor did it allow the user to choose rxmode settings
> by default it was set to vf = 0, rxmode = AUPE and the on/off state toggled
> without letting the user know what state it is in
> also there were no error messages
>
> Changes:
> - added flag for vf id
> - added flags for AUPE|ROPE|BAM|MPE rxmodes
> - added flag for on/off
> - added error messages
> - added info messages
>
> Signed-off-by: Muhammad Jawad Hussain <jawad.hussain@emumba.com>
> ---
>  doc/guides/sample_app_ug/ethtool.rst  |   2 +-
>  examples/ethtool/ethtool-app/ethapp.c | 134 ++++++++++++++++++++------
>  examples/ethtool/lib/rte_ethtool.c    |  38 --------
>  examples/ethtool/meson.build          |   4 +-
>  4 files changed, 110 insertions(+), 68 deletions(-)
>
> diff --git a/doc/guides/sample_app_ug/ethtool.rst
> b/doc/guides/sample_app_ug/ethtool.rst
> index 159e9e0639..2e53084cc3 100644
> --- a/doc/guides/sample_app_ug/ethtool.rst
> +++ b/doc/guides/sample_app_ug/ethtool.rst
> @@ -53,7 +53,7 @@ they do as follows:
>  * ``portstats``: Print port statistics
>  * ``regs``: Dump port register(s) to file
>  * ``ringparam``: Get/set ring parameters
> -* ``rxmode``: Toggle port Rx mode
> +* ``rxmode``: Set rxmode of vfs on ports
>  * ``stop``: Stop port
>  * ``validate``: Check that given MAC address is valid unicast address
>  * ``vlan``: Add/remove VLAN id
> diff --git a/examples/ethtool/ethtool-app/ethapp.c
> b/examples/ethtool/ethtool-app/ethapp.c
> index 78e86534e8..214433a98b 100644
> --- a/examples/ethtool/ethtool-app/ethapp.c
> +++ b/examples/ethtool/ethtool-app/ethapp.c
> @@ -8,12 +8,30 @@
>  #include <cmdline_parse_etheraddr.h>
>  #include <cmdline_socket.h>
>  #include <cmdline.h>
> -
> +#ifdef RTE_NET_IXGBE
> +#include <rte_pmd_ixgbe.h>
> +#endif
> +#ifdef RTE_NET_BNXT
> +#include <rte_pmd_bnxt.h>
> +#endif
>  #include "rte_ethtool.h"
>  #include "ethapp.h"
>
>  #define EEPROM_DUMP_CHUNKSIZE 1024
>
> +typedef uint16_t portid_t;
> +
> +/* *** CONFIGURE VF RECEIVE MODE *** */
> +struct cmd_set_vf_rxmode {
> +       cmdline_fixed_string_t set;
> +       cmdline_fixed_string_t port;
> +       portid_t port_id;
> +       cmdline_fixed_string_t vf;
> +       uint8_t vf_id;
> +       cmdline_fixed_string_t what;
> +       cmdline_fixed_string_t mode;
> +       cmdline_fixed_string_t on;
> +};
>
>  struct pcmd_get_params {
>         cmdline_fixed_string_t cmd;
> @@ -65,8 +83,6 @@ cmdline_parse_token_string_t pcmd_open_token_cmd =
>         TOKEN_STRING_INITIALIZER(struct pcmd_int_params, cmd, "open");
>  cmdline_parse_token_string_t pcmd_stop_token_cmd =
>         TOKEN_STRING_INITIALIZER(struct pcmd_int_params, cmd, "stop");
> -cmdline_parse_token_string_t pcmd_rxmode_token_cmd =
> -       TOKEN_STRING_INITIALIZER(struct pcmd_int_params, cmd, "rxmode");
>  cmdline_parse_token_string_t pcmd_portstats_token_cmd =
>         TOKEN_STRING_INITIALIZER(struct pcmd_int_params, cmd, "portstats");
>  cmdline_parse_token_num_t pcmd_int_token_port =
> @@ -133,6 +149,31 @@ cmdline_parse_token_string_t pcmd_vlan_token_mode =
>  cmdline_parse_token_num_t pcmd_vlan_token_vid =
>         TOKEN_NUM_INITIALIZER(struct pcmd_vlan_params, vid, RTE_UINT16);
>
> +/* rxmode */
> +cmdline_parse_token_string_t cmd_set_vf_rxmode_set =
> +       TOKEN_STRING_INITIALIZER(struct cmd_set_vf_rxmode,
> +                                set, "set");
> +cmdline_parse_token_string_t cmd_set_vf_rxmode_port =
> +       TOKEN_STRING_INITIALIZER(struct cmd_set_vf_rxmode,
> +                                port, "port");
> +cmdline_parse_token_num_t cmd_set_vf_rxmode_portid =
> +       TOKEN_NUM_INITIALIZER(struct cmd_set_vf_rxmode,
> +                             port_id, RTE_UINT16);
> +cmdline_parse_token_string_t cmd_set_vf_rxmode_vf =
> +       TOKEN_STRING_INITIALIZER(struct cmd_set_vf_rxmode,
> +                                vf, "vf");
> +cmdline_parse_token_num_t cmd_set_vf_rxmode_vfid =
> +       TOKEN_NUM_INITIALIZER(struct cmd_set_vf_rxmode,
> +                             vf_id, RTE_UINT8);
> +cmdline_parse_token_string_t cmd_set_vf_rxmode_what =
> +       TOKEN_STRING_INITIALIZER(struct cmd_set_vf_rxmode,
> +                                what, "rxmode");
> +cmdline_parse_token_string_t cmd_set_vf_rxmode_mode =
> +       TOKEN_STRING_INITIALIZER(struct cmd_set_vf_rxmode,
> +                                mode, "AUPE#ROPE#BAM#MPE");
> +cmdline_parse_token_string_t cmd_set_vf_rxmode_on =
> +       TOKEN_STRING_INITIALIZER(struct cmd_set_vf_rxmode,
> +                                on, "on#off");
>
>  static void
>  pcmd_quit_callback(__rte_unused void *ptr_params,
> @@ -142,7 +183,6 @@ pcmd_quit_callback(__rte_unused void *ptr_params,
>         cmdline_quit(ctx);
>  }
>
> -
>  static void
>  pcmd_drvinfo_callback(__rte_unused void *ptr_params,
>         __rte_unused struct cmdline *ctx,
> @@ -150,7 +190,6 @@ pcmd_drvinfo_callback(__rte_unused void *ptr_params,
>  {
>         struct ethtool_drvinfo info;
>         uint16_t id_port;
> -
>         RTE_ETH_FOREACH_DEV(id_port) {
>                 memset(&info, 0, sizeof(info));
>                 if (rte_ethtool_get_drvinfo(id_port, &info)) {
> @@ -447,26 +486,57 @@ pcmd_stop_callback(__rte_unused void *ptr_params,
>                 printf("Port %i: Error stopping device\n", params->port);
>  }
>
> -
>  static void
> -pcmd_rxmode_callback(void *ptr_params,
> -       __rte_unused struct cmdline *ctx,
> -       __rte_unused void *ptr_data)
> +pcmd_rxmode_callback(void *parsed_result,
> +                      __rte_unused struct cmdline *cl,
> +                      __rte_unused void *data)
>  {
> -       struct pcmd_intstr_params *params = ptr_params;
> -       int stat;
> +       int ret = -ENOTSUP;
> +       uint16_t vf_rxmode = 0;
> +       struct cmd_set_vf_rxmode *res = parsed_result;
> +
> +       int is_on = (strcmp(res->on, "on") == 0) ? 1 : 0;
> +       if (!strcmp(res->what, "rxmode")) {
> +               if (!strcmp(res->mode, "AUPE"))
> +                       vf_rxmode |= RTE_ETH_VMDQ_ACCEPT_UNTAG;
> +               else if (!strcmp(res->mode, "ROPE"))
> +                       vf_rxmode |= RTE_ETH_VMDQ_ACCEPT_HASH_UC;
> +               else if (!strcmp(res->mode, "BAM"))
> +                       vf_rxmode |= RTE_ETH_VMDQ_ACCEPT_BROADCAST;
> +               else if (!strncmp(res->mode, "MPE", 3))
> +                       vf_rxmode |= RTE_ETH_VMDQ_ACCEPT_MULTICAST;
> +       }
>
> -       if (!rte_eth_dev_is_valid_port(params->port)) {
> -               printf("Error: Invalid port number %i\n", params->port);
> -               return;
> +       RTE_SET_USED(is_on);
> +       RTE_SET_USED(vf_rxmode);
> +
> +#ifdef RTE_NET_IXGBE
> +       if (ret == -ENOTSUP) {
> +               ret = rte_pmd_ixgbe_set_vf_rxmode(res->port_id, res->vf_id,
> +                                                 vf_rxmode,
> (uint8_t)is_on);
> +               if (ret == -ENOTSUP)
> +                       printf("ixgbe not supported\n");
>         }
> -       stat = rte_ethtool_net_set_rx_mode(params->port);
> -       if (stat == 0)
> -               return;
> -       else if (stat == -ENOTSUP)
> -               printf("Port %i: Operation not supported\n", params->port);
> -       else
> -               printf("Port %i: Error setting rx mode\n", params->port);
> +#endif
> +#ifdef RTE_NET_BNXT
> +       if (ret == -ENOTSUP) {
> +               ret = rte_pmd_bnxt_set_vf_rxmode(res->port_id, res->vf_id,
> +                                                vf_rxmode,
> (uint8_t)is_on);
> +               if (ret == -ENOTSUP)
> +                       printf("bnxt not supported\n");
> +       }
> +#endif
> +       int ret_offload = -ENOTSUP;
> +       if (!strcmp(res->mode, "AUPE")) {
> +               ret_offload = rte_eth_dev_set_vlan_offload(res->port_id,
> RTE_ETH_VLAN_FILTER_MASK);
> +               if (ret_offload == -ENOTSUP)
> +                       printf("Port %i: VLAN Filter setting mask not
> supported\n", res->port_id);
> +       }
> +       if (ret < 0)
> +               fprintf(stderr,
> +                       "bad VF receive mode parameter, return code =
> %d\n", ret);
> +       else if (ret == 0)
> +               printf("Successful\n");
>  }
>
>
> @@ -763,16 +833,25 @@ cmdline_parse_inst_t pcmd_stop = {
>                 NULL
>         },
>  };
> -cmdline_parse_inst_t pcmd_rxmode = {
> +
> +cmdline_parse_inst_t cmd_set_vf_rxmode = {
>         .f = pcmd_rxmode_callback,
>         .data = NULL,
> -       .help_str = "rxmode <port_id>\n     Toggle port Rx mode",
> +       .help_str = "set port <port_id> vf <vf_id> rxmode "
> +               "AUPE|ROPE|BAM|MPE on|off",
>         .tokens = {
> -               (void *)&pcmd_rxmode_token_cmd,
> -               (void *)&pcmd_int_token_port,
> -               NULL
> +               (void *)&cmd_set_vf_rxmode_set,
> +               (void *)&cmd_set_vf_rxmode_port,
> +               (void *)&cmd_set_vf_rxmode_portid,
> +               (void *)&cmd_set_vf_rxmode_vf,
> +               (void *)&cmd_set_vf_rxmode_vfid,
> +               (void *)&cmd_set_vf_rxmode_what,
> +               (void *)&cmd_set_vf_rxmode_mode,
> +               (void *)&cmd_set_vf_rxmode_on,
> +               NULL,
>         },
>  };
> +
>  cmdline_parse_inst_t pcmd_macaddr_get = {
>         .f = pcmd_macaddr_callback,
>         .data = NULL,
> @@ -869,7 +948,6 @@ cmdline_parse_inst_t pcmd_vlan = {
>         },
>  };
>
> -
>  cmdline_parse_ctx_t list_prompt_commands[] = {
>         (cmdline_parse_inst_t *)&pcmd_drvinfo,
>         (cmdline_parse_inst_t *)&pcmd_eeprom,
> @@ -885,7 +963,7 @@ cmdline_parse_ctx_t list_prompt_commands[] = {
>         (cmdline_parse_inst_t *)&pcmd_regs,
>         (cmdline_parse_inst_t *)&pcmd_ringparam,
>         (cmdline_parse_inst_t *)&pcmd_ringparam_set,
> -       (cmdline_parse_inst_t *)&pcmd_rxmode,
> +       (cmdline_parse_inst_t *)&cmd_set_vf_rxmode,
>         (cmdline_parse_inst_t *)&pcmd_stop,
>         (cmdline_parse_inst_t *)&pcmd_validate,
>         (cmdline_parse_inst_t *)&pcmd_vlan,
> diff --git a/examples/ethtool/lib/rte_ethtool.c
> b/examples/ethtool/lib/rte_ethtool.c
> index ffaad96498..6951f0c2a8 100644
> --- a/examples/ethtool/lib/rte_ethtool.c
> +++ b/examples/ethtool/lib/rte_ethtool.c
> @@ -373,44 +373,6 @@ rte_ethtool_net_vlan_rx_kill_vid(uint16_t port_id,
> uint16_t vid)
>         return rte_eth_dev_vlan_filter(port_id, vid, 0);
>  }
>
> -/*
> - * The set_rx_mode provides driver-specific rx mode setting.
> - * This implementation implements rx mode setting based upon
> - * ixgbe/igb drivers. Further improvement is to provide a
> - * callback op field over struct rte_eth_dev::dev_ops so each
> - * driver can register device-specific implementation
> - */
> -int
> -rte_ethtool_net_set_rx_mode(uint16_t port_id)
> -{
> -       uint16_t num_vfs;
> -       struct rte_eth_dev_info dev_info;
> -       uint16_t vf;
> -       int ret;
> -
> -       ret = rte_eth_dev_info_get(port_id, &dev_info);
> -       if (ret != 0)
> -               return ret;
> -
> -       num_vfs = dev_info.max_vfs;
> -
> -       /* Set VF vf_rx_mode, VF unsupport status is discard */
> -       for (vf = 0; vf < num_vfs; vf++) {
> -#ifdef RTE_NET_IXGBE
> -               rte_pmd_ixgbe_set_vf_rxmode(port_id, vf,
> -                       RTE_ETH_VMDQ_ACCEPT_UNTAG, 0);
> -#endif
> -       }
> -
> -       /* Enable Rx vlan filter, VF unsupported status is discard */
> -       ret = rte_eth_dev_set_vlan_offload(port_id,
> RTE_ETH_VLAN_FILTER_MASK);
> -       if (ret != 0)
> -               return ret;
> -
> -       return 0;
> -}
> -
> -
>  int
>  rte_ethtool_get_ringparam(uint16_t port_id,
>         struct ethtool_ringparam *ring_param)
> diff --git a/examples/ethtool/meson.build b/examples/ethtool/meson.build
> index d7f63d48af..175a5ddd7a 100644
> --- a/examples/ethtool/meson.build
> +++ b/examples/ethtool/meson.build
> @@ -22,5 +22,7 @@ deps += 'bus_pci'
>  if dpdk_conf.has('RTE_NET_IXGBE')
>      deps += 'net_ixgbe'
>  endif
> -
> +if dpdk_conf.has('RTE_NET_BNXT')
> +    deps += 'net_bnxt'
> +endif
>  allow_experimental_apis = true
> --
> 2.32.0
>
>

--00000000000030f80e05e31dc073
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi,<div>I submitted this patch on 29th may,2022. I am gett=
ing a bad coding style=C2=A0warning because I did not email version 2 in th=
e reply of version 1. Should I resend it in the=C2=A0reply?</div><div><br><=
/div><div>Regards,</div><div>Jawad Hussain</div></div><br><div class=3D"gma=
il_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Sun, May 29, 2022 at 7:2=
9 PM Muhammad Jawad Hussain &lt;<a href=3D"mailto:jawad.hussain@emumba.com"=
>jawad.hussain@emumba.com</a>&gt; wrote:<br></div><blockquote class=3D"gmai=
l_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,20=
4,204);padding-left:1ex">previously rxmode functionality did not allow the =
user to choose<br>
between different vfs nor did it allow the user to choose rxmode settings<b=
r>
by default it was set to vf =3D 0, rxmode =3D AUPE and the on/off state tog=
gled<br>
without letting the user know what state it is in<br>
also there were no error messages<br>
<br>
Changes:<br>
- added flag for vf id<br>
- added flags for AUPE|ROPE|BAM|MPE rxmodes<br>
- added flag for on/off<br>
- added error messages<br>
- added info messages<br>
<br>
Signed-off-by: Muhammad Jawad Hussain &lt;<a href=3D"mailto:jawad.hussain@e=
mumba.com" target=3D"_blank">jawad.hussain@emumba.com</a>&gt;<br>
---<br>
=C2=A0doc/guides/sample_app_ug/ethtool.rst=C2=A0 |=C2=A0 =C2=A02 +-<br>
=C2=A0examples/ethtool/ethtool-app/ethapp.c | 134 ++++++++++++++++++++-----=
-<br>
=C2=A0examples/ethtool/lib/rte_ethtool.c=C2=A0 =C2=A0 |=C2=A0 38 --------<b=
r>
=C2=A0examples/ethtool/meson.build=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=
=A0 =C2=A04 +-<br>
=C2=A04 files changed, 110 insertions(+), 68 deletions(-)<br>
<br>
diff --git a/doc/guides/sample_app_ug/ethtool.rst b/doc/guides/sample_app_u=
g/ethtool.rst<br>
index 159e9e0639..2e53084cc3 100644<br>
--- a/doc/guides/sample_app_ug/ethtool.rst<br>
+++ b/doc/guides/sample_app_ug/ethtool.rst<br>
@@ -53,7 +53,7 @@ they do as follows:<br>
=C2=A0* ``portstats``: Print port statistics<br>
=C2=A0* ``regs``: Dump port register(s) to file<br>
=C2=A0* ``ringparam``: Get/set ring parameters<br>
-* ``rxmode``: Toggle port Rx mode<br>
+* ``rxmode``: Set rxmode of vfs on ports<br>
=C2=A0* ``stop``: Stop port<br>
=C2=A0* ``validate``: Check that given MAC address is valid unicast address=
<br>
=C2=A0* ``vlan``: Add/remove VLAN id<br>
diff --git a/examples/ethtool/ethtool-app/ethapp.c b/examples/ethtool/ethto=
ol-app/ethapp.c<br>
index 78e86534e8..214433a98b 100644<br>
--- a/examples/ethtool/ethtool-app/ethapp.c<br>
+++ b/examples/ethtool/ethtool-app/ethapp.c<br>
@@ -8,12 +8,30 @@<br>
=C2=A0#include &lt;cmdline_parse_etheraddr.h&gt;<br>
=C2=A0#include &lt;cmdline_socket.h&gt;<br>
=C2=A0#include &lt;cmdline.h&gt;<br>
-<br>
+#ifdef RTE_NET_IXGBE<br>
+#include &lt;rte_pmd_ixgbe.h&gt;<br>
+#endif<br>
+#ifdef RTE_NET_BNXT<br>
+#include &lt;rte_pmd_bnxt.h&gt;<br>
+#endif<br>
=C2=A0#include &quot;rte_ethtool.h&quot;<br>
=C2=A0#include &quot;ethapp.h&quot;<br>
<br>
=C2=A0#define EEPROM_DUMP_CHUNKSIZE 1024<br>
<br>
+typedef uint16_t portid_t;<br>
+<br>
+/* *** CONFIGURE VF RECEIVE MODE *** */<br>
+struct cmd_set_vf_rxmode {<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0cmdline_fixed_string_t set;<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0cmdline_fixed_string_t port;<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0portid_t port_id;<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0cmdline_fixed_string_t vf;<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0uint8_t vf_id;<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0cmdline_fixed_string_t what;<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0cmdline_fixed_string_t mode;<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0cmdline_fixed_string_t on;<br>
+};<br>
<br>
=C2=A0struct pcmd_get_params {<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 cmdline_fixed_string_t cmd;<br>
@@ -65,8 +83,6 @@ cmdline_parse_token_string_t pcmd_open_token_cmd =3D<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 TOKEN_STRING_INITIALIZER(struct pcmd_int_params=
, cmd, &quot;open&quot;);<br>
=C2=A0cmdline_parse_token_string_t pcmd_stop_token_cmd =3D<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 TOKEN_STRING_INITIALIZER(struct pcmd_int_params=
, cmd, &quot;stop&quot;);<br>
-cmdline_parse_token_string_t pcmd_rxmode_token_cmd =3D<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0TOKEN_STRING_INITIALIZER(struct pcmd_int_params=
, cmd, &quot;rxmode&quot;);<br>
=C2=A0cmdline_parse_token_string_t pcmd_portstats_token_cmd =3D<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 TOKEN_STRING_INITIALIZER(struct pcmd_int_params=
, cmd, &quot;portstats&quot;);<br>
=C2=A0cmdline_parse_token_num_t pcmd_int_token_port =3D<br>
@@ -133,6 +149,31 @@ cmdline_parse_token_string_t pcmd_vlan_token_mode =3D<=
br>
=C2=A0cmdline_parse_token_num_t pcmd_vlan_token_vid =3D<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 TOKEN_NUM_INITIALIZER(struct pcmd_vlan_params, =
vid, RTE_UINT16);<br>
<br>
+/* rxmode */<br>
+cmdline_parse_token_string_t cmd_set_vf_rxmode_set =3D<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0TOKEN_STRING_INITIALIZER(struct cmd_set_vf_rxmo=
de,<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 set, &quot;set&quot;);<br>
+cmdline_parse_token_string_t cmd_set_vf_rxmode_port =3D<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0TOKEN_STRING_INITIALIZER(struct cmd_set_vf_rxmo=
de,<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 port, &quot;port&quot;);<br>
+cmdline_parse_token_num_t cmd_set_vf_rxmode_portid =3D<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0TOKEN_NUM_INITIALIZER(struct cmd_set_vf_rxmode,=
<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0port_id, RTE_UINT16);<br>
+cmdline_parse_token_string_t cmd_set_vf_rxmode_vf =3D<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0TOKEN_STRING_INITIALIZER(struct cmd_set_vf_rxmo=
de,<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 vf, &quot;vf&quot;);<br>
+cmdline_parse_token_num_t cmd_set_vf_rxmode_vfid =3D<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0TOKEN_NUM_INITIALIZER(struct cmd_set_vf_rxmode,=
<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0vf_id, RTE_UINT8);<br>
+cmdline_parse_token_string_t cmd_set_vf_rxmode_what =3D<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0TOKEN_STRING_INITIALIZER(struct cmd_set_vf_rxmo=
de,<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 what, &quot;rxmode&quot;);<br>
+cmdline_parse_token_string_t cmd_set_vf_rxmode_mode =3D<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0TOKEN_STRING_INITIALIZER(struct cmd_set_vf_rxmo=
de,<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 mode, &quot;AUPE#ROPE#BAM#MPE&quot;)=
;<br>
+cmdline_parse_token_string_t cmd_set_vf_rxmode_on =3D<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0TOKEN_STRING_INITIALIZER(struct cmd_set_vf_rxmo=
de,<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 on, &quot;on#off&quot;);<br>
<br>
=C2=A0static void<br>
=C2=A0pcmd_quit_callback(__rte_unused void *ptr_params,<br>
@@ -142,7 +183,6 @@ pcmd_quit_callback(__rte_unused void *ptr_params,<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 cmdline_quit(ctx);<br>
=C2=A0}<br>
<br>
-<br>
=C2=A0static void<br>
=C2=A0pcmd_drvinfo_callback(__rte_unused void *ptr_params,<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 __rte_unused struct cmdline *ctx,<br>
@@ -150,7 +190,6 @@ pcmd_drvinfo_callback(__rte_unused void *ptr_params,<br=
>
=C2=A0{<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 struct ethtool_drvinfo info;<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 uint16_t id_port;<br>
-<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 RTE_ETH_FOREACH_DEV(id_port) {<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 memset(&amp;info, 0=
, sizeof(info));<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (rte_ethtool_get=
_drvinfo(id_port, &amp;info)) {<br>
@@ -447,26 +486,57 @@ pcmd_stop_callback(__rte_unused void *ptr_params,<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 printf(&quot;Port %=
i: Error stopping device\n&quot;, params-&gt;port);<br>
=C2=A0}<br>
<br>
-<br>
=C2=A0static void<br>
-pcmd_rxmode_callback(void *ptr_params,<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0__rte_unused struct cmdline *ctx,<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0__rte_unused void *ptr_data)<br>
+pcmd_rxmode_callback(void *parsed_result,<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 __rte_unused struct cmdline *cl,<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 __rte_unused void *data)<br>
=C2=A0{<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0struct pcmd_intstr_params *params =3D ptr_param=
s;<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0int stat;<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0int ret =3D -ENOTSUP;<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0uint16_t vf_rxmode =3D 0;<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0struct cmd_set_vf_rxmode *res =3D parsed_result=
;<br>
+<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0int is_on =3D (strcmp(res-&gt;on, &quot;on&quot=
;) =3D=3D 0) ? 1 : 0;<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0if (!strcmp(res-&gt;what, &quot;rxmode&quot;)) =
{<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (!strcmp(res-&gt=
;mode, &quot;AUPE&quot;))<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0vf_rxmode |=3D RTE_ETH_VMDQ_ACCEPT_UNTAG;<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0else if (!strcmp(re=
s-&gt;mode, &quot;ROPE&quot;))<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0vf_rxmode |=3D RTE_ETH_VMDQ_ACCEPT_HASH_UC;<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0else if (!strcmp(re=
s-&gt;mode, &quot;BAM&quot;))<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0vf_rxmode |=3D RTE_ETH_VMDQ_ACCEPT_BROADCAST;<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0else if (!strncmp(r=
es-&gt;mode, &quot;MPE&quot;, 3))<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0vf_rxmode |=3D RTE_ETH_VMDQ_ACCEPT_MULTICAST;<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0}<br>
<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0if (!rte_eth_dev_is_valid_port(params-&gt;port)=
) {<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0printf(&quot;Error:=
 Invalid port number %i\n&quot;, params-&gt;port);<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return;<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0RTE_SET_USED(is_on);<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0RTE_SET_USED(vf_rxmode);<br>
+<br>
+#ifdef RTE_NET_IXGBE<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0if (ret =3D=3D -ENOTSUP) {<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ret =3D rte_pmd_ixg=
be_set_vf_rxmode(res-&gt;port_id, res-&gt;vf_id,<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0vf_rxmode, (uint8_t)is_on);<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (ret =3D=3D -ENO=
TSUP)<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0printf(&quot;ixgbe not supported\n&quot;);<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 }<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0stat =3D rte_ethtool_net_set_rx_mode(params-&gt=
;port);<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0if (stat =3D=3D 0)<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return;<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0else if (stat =3D=3D -ENOTSUP)<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0printf(&quot;Port %=
i: Operation not supported\n&quot;, params-&gt;port);<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0else<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0printf(&quot;Port %=
i: Error setting rx mode\n&quot;, params-&gt;port);<br>
+#endif<br>
+#ifdef RTE_NET_BNXT<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0if (ret =3D=3D -ENOTSUP) {<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ret =3D rte_pmd_bnx=
t_set_vf_rxmode(res-&gt;port_id, res-&gt;vf_id,<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 vf_rxmode, (uint8_t)is_on);<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (ret =3D=3D -ENO=
TSUP)<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0printf(&quot;bnxt not supported\n&quot;);<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0}<br>
+#endif<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0int ret_offload =3D -ENOTSUP;<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0if (!strcmp(res-&gt;mode, &quot;AUPE&quot;)) {<=
br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ret_offload =3D rte=
_eth_dev_set_vlan_offload(res-&gt;port_id, RTE_ETH_VLAN_FILTER_MASK);<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (ret_offload =3D=
=3D -ENOTSUP)<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0printf(&quot;Port %i: VLAN Filter setting mask not supported\n&qu=
ot;, res-&gt;port_id);<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0}<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0if (ret &lt; 0)<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0fprintf(stderr,<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0&quot;bad VF receive mode parameter, return code =3D %d\n&quot;, =
ret);<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0else if (ret =3D=3D 0)<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0printf(&quot;Succes=
sful\n&quot;);<br>
=C2=A0}<br>
<br>
<br>
@@ -763,16 +833,25 @@ cmdline_parse_inst_t pcmd_stop =3D {<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 NULL<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 },<br>
=C2=A0};<br>
-cmdline_parse_inst_t pcmd_rxmode =3D {<br>
+<br>
+cmdline_parse_inst_t cmd_set_vf_rxmode =3D {<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 .f =3D pcmd_rxmode_callback,<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 .data =3D NULL,<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0.help_str =3D &quot;rxmode &lt;port_id&gt;\n=C2=
=A0 =C2=A0 =C2=A0Toggle port Rx mode&quot;,<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0.help_str =3D &quot;set port &lt;port_id&gt; vf=
 &lt;vf_id&gt; rxmode &quot;<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;AUPE|ROPE|BAM=
|MPE on|off&quot;,<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 .tokens =3D {<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(void *)&amp;pcmd_r=
xmode_token_cmd,<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(void *)&amp;pcmd_i=
nt_token_port,<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0NULL<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(void *)&amp;cmd_se=
t_vf_rxmode_set,<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(void *)&amp;cmd_se=
t_vf_rxmode_port,<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(void *)&amp;cmd_se=
t_vf_rxmode_portid,<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(void *)&amp;cmd_se=
t_vf_rxmode_vf,<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(void *)&amp;cmd_se=
t_vf_rxmode_vfid,<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(void *)&amp;cmd_se=
t_vf_rxmode_what,<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(void *)&amp;cmd_se=
t_vf_rxmode_mode,<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(void *)&amp;cmd_se=
t_vf_rxmode_on,<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0NULL,<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 },<br>
=C2=A0};<br>
+<br>
=C2=A0cmdline_parse_inst_t pcmd_macaddr_get =3D {<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 .f =3D pcmd_macaddr_callback,<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 .data =3D NULL,<br>
@@ -869,7 +948,6 @@ cmdline_parse_inst_t pcmd_vlan =3D {<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 },<br>
=C2=A0};<br>
<br>
-<br>
=C2=A0cmdline_parse_ctx_t list_prompt_commands[] =3D {<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (cmdline_parse_inst_t *)&amp;pcmd_drvinfo,<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (cmdline_parse_inst_t *)&amp;pcmd_eeprom,<br>
@@ -885,7 +963,7 @@ cmdline_parse_ctx_t list_prompt_commands[] =3D {<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (cmdline_parse_inst_t *)&amp;pcmd_regs,<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (cmdline_parse_inst_t *)&amp;pcmd_ringparam,<br=
>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (cmdline_parse_inst_t *)&amp;pcmd_ringparam_set=
,<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0(cmdline_parse_inst_t *)&amp;pcmd_rxmode,<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0(cmdline_parse_inst_t *)&amp;cmd_set_vf_rxmode,=
<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (cmdline_parse_inst_t *)&amp;pcmd_stop,<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (cmdline_parse_inst_t *)&amp;pcmd_validate,<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (cmdline_parse_inst_t *)&amp;pcmd_vlan,<br>
diff --git a/examples/ethtool/lib/rte_ethtool.c b/examples/ethtool/lib/rte_=
ethtool.c<br>
index ffaad96498..6951f0c2a8 100644<br>
--- a/examples/ethtool/lib/rte_ethtool.c<br>
+++ b/examples/ethtool/lib/rte_ethtool.c<br>
@@ -373,44 +373,6 @@ rte_ethtool_net_vlan_rx_kill_vid(uint16_t port_id, uin=
t16_t vid)<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 return rte_eth_dev_vlan_filter(port_id, vid, 0)=
;<br>
=C2=A0}<br>
<br>
-/*<br>
- * The set_rx_mode provides driver-specific rx mode setting.<br>
- * This implementation implements rx mode setting based upon<br>
- * ixgbe/igb drivers. Further improvement is to provide a<br>
- * callback op field over struct rte_eth_dev::dev_ops so each<br>
- * driver can register device-specific implementation<br>
- */<br>
-int<br>
-rte_ethtool_net_set_rx_mode(uint16_t port_id)<br>
-{<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0uint16_t num_vfs;<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0struct rte_eth_dev_info dev_info;<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0uint16_t vf;<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0int ret;<br>
-<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0ret =3D rte_eth_dev_info_get(port_id, &amp;dev_=
info);<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0if (ret !=3D 0)<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return ret;<br>
-<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0num_vfs =3D dev_info.max_vfs;<br>
-<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0/* Set VF vf_rx_mode, VF unsupport status is di=
scard */<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0for (vf =3D 0; vf &lt; num_vfs; vf++) {<br>
-#ifdef RTE_NET_IXGBE<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0rte_pmd_ixgbe_set_v=
f_rxmode(port_id, vf,<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0RTE_ETH_VMDQ_ACCEPT_UNTAG, 0);<br>
-#endif<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0}<br>
-<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0/* Enable Rx vlan filter, VF unsupported status=
 is discard */<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0ret =3D rte_eth_dev_set_vlan_offload(port_id, R=
TE_ETH_VLAN_FILTER_MASK);<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0if (ret !=3D 0)<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return ret;<br>
-<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0return 0;<br>
-}<br>
-<br>
-<br>
=C2=A0int<br>
=C2=A0rte_ethtool_get_ringparam(uint16_t port_id,<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 struct ethtool_ringparam *ring_param)<br>
diff --git a/examples/ethtool/meson.build b/examples/ethtool/meson.build<br=
>
index d7f63d48af..175a5ddd7a 100644<br>
--- a/examples/ethtool/meson.build<br>
+++ b/examples/ethtool/meson.build<br>
@@ -22,5 +22,7 @@ deps +=3D &#39;bus_pci&#39;<br>
=C2=A0if dpdk_conf.has(&#39;RTE_NET_IXGBE&#39;)<br>
=C2=A0 =C2=A0 =C2=A0deps +=3D &#39;net_ixgbe&#39;<br>
=C2=A0endif<br>
-<br>
+if dpdk_conf.has(&#39;RTE_NET_BNXT&#39;)<br>
+=C2=A0 =C2=A0 deps +=3D &#39;net_bnxt&#39;<br>
+endif<br>
=C2=A0allow_experimental_apis =3D true<br>
-- <br>
2.32.0<br>
<br>
</blockquote></div>

--00000000000030f80e05e31dc073--