From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Lance Richardson <lance.richardson@broadcom.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Somnath Kotur <somnath.kotur@broadcom.com>,
dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: remove useless prefetches
Date: Thu, 5 Nov 2020 14:24:59 -0800 [thread overview]
Message-ID: <CACZ4nhs063MW52Kp2E-P_EZgXTPmj844tCt1+vb-2HAM5hwy+A@mail.gmail.com> (raw)
In-Reply-To: <CADyeNEBEP5Tc15cGdLG5_7uSWj-nwc8Syb_EjBUqzi1E3EgK_Q@mail.gmail.com>
On Thu, Nov 5, 2020 at 7:18 AM Lance Richardson <
lance.richardson@broadcom.com> wrote:
> On Wed, Nov 4, 2020 at 12:03 PM Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > Prefetching only helps performance if it is done several 100
> > instructions before the actual use. The purpose of the prefetch
> > is to read ahead, it doesn't help if the next instruction
> > will block.
> >
> > The code in the bnxt driver was doing these unnecessary prefetches.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> > drivers/net/bnxt/bnxt_rxr.c | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c
> > index 2645ed61f402..140d79e0e829 100644
> > --- a/drivers/net/bnxt/bnxt_rxr.c
> > +++ b/drivers/net/bnxt/bnxt_rxr.c
> > @@ -305,7 +305,6 @@ static inline struct rte_mbuf *bnxt_tpa_end(
> > mbuf = tpa_info->mbuf;
> > RTE_ASSERT(mbuf != NULL);
> >
> > - rte_prefetch0(mbuf);
> > if (agg_bufs) {
> > bnxt_rx_pages(rxq, mbuf, raw_cp_cons, agg_bufs,
> tpa_info);
> > }
> > @@ -733,8 +732,6 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt,
> > if (mbuf == NULL)
> > return -EBUSY;
> >
> > - rte_prefetch0(mbuf);
> > -
> > mbuf->data_off = RTE_PKTMBUF_HEADROOM;
> > mbuf->nb_segs = 1;
> > mbuf->next = NULL;
> > @@ -867,7 +864,6 @@ uint16_t bnxt_recv_pkts(void *rx_queue, struct
> rte_mbuf **rx_pkts,
> > /* Handle RX burst request */
> > while (1) {
> > cons = RING_CMP(cpr->cp_ring_struct, raw_cons);
> > - rte_prefetch0(&cpr->cp_desc_ring[cons]);
> > rxcmp = (struct rx_pkt_cmpl *)&cpr->cp_desc_ring[cons];
> >
> > if (!CMP_VALID(rxcmp, raw_cons, cpr->cp_ring_struct))
> > --
> > 2.27.0
> >
> Acked-by: Lance Richardson <lance.richardson@broadcom.com>
>
Updated commit log with fixes tag and applied to dpdk-next-net-brcm.
prev parent reply other threads:[~2020-11-05 22:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 17:03 Stephen Hemminger
2020-11-05 15:18 ` Lance Richardson
2020-11-05 22:24 ` Ajit Khaparde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACZ4nhs063MW52Kp2E-P_EZgXTPmj844tCt1+vb-2HAM5hwy+A@mail.gmail.com \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=lance.richardson@broadcom.com \
--cc=somnath.kotur@broadcom.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).