From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED484A0597; Fri, 17 Apr 2020 18:15:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0A5ED1E9C6; Fri, 17 Apr 2020 18:15:14 +0200 (CEST) Received: from mail-oi1-f194.google.com (mail-oi1-f194.google.com [209.85.167.194]) by dpdk.org (Postfix) with ESMTP id 9BAF21D925 for ; Fri, 17 Apr 2020 18:15:12 +0200 (CEST) Received: by mail-oi1-f194.google.com with SMTP id m14so2549205oic.0 for ; Fri, 17 Apr 2020 09:15:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VbTkElk0rcSxuHdHgi3wtFsKSSXJYfDT7+XGQEvYGcA=; b=PBCsPo4YzbleJ8HcJcszJIwt2unPzhIgJjH2cF/1+kqnJT2bhDI3uLAOlR2qxgLutM Sj1ZR0V9Qwx14fK6mqDE7k5MwrrSclI5dbk3zzgk+4xvS7uuRNwDpX0lY258ueq8Spt7 wJCUz0/OgrIKcmYKLaC8V/6M4NCeZYERO9Gq0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VbTkElk0rcSxuHdHgi3wtFsKSSXJYfDT7+XGQEvYGcA=; b=ITHaKhQWOo4Nal4EyziCZPCqbn/wf9TLksGXjLQItVVErJavuO6UzF8TdLLyHWXa0q Lnxr+ENPsU4oFr9TN+yNBQECUmixBaxin2aTBvpmuC5/pG/ISZco94znUogmS+XIGAHG bgFoUGqz/9gt2cYszZozeFT+nl5WVncuopn1EurokaUh8CRjP7gSYmF810uYN7RwFM3G JEFvCKOsO4fjPj0Hu4sIR1oT+3aPz7D8DanVlVE440o8AUXVNmBUWX4+u7uTmLnLvJst M9dPW9mfjiLsr9orDMfaBr1CeNNjqkpdy6casKR3FKYxtHN3rkDvIgxrXyclKKF6rbNo LU9A== X-Gm-Message-State: AGi0PuZAh1hPssM/oaDYSzdePvFQxS+VLz7Tl8XXvV7vmyCtLtTs8hwr 6ZQfHabV+7PAXfPejCc3cqJOCqH98RL4bTLHp6Fhdw== X-Google-Smtp-Source: APiQypLNb3g5hGdtjWvgLNZ9V0L0SaU4dYyldn5VXT2AGnB4VkKyZuknmdV6M21jYMS+I7F2TPGN6O/aoIzRog+qv4g= X-Received: by 2002:aca:bbc6:: with SMTP id l189mr2766065oif.168.1587140111535; Fri, 17 Apr 2020 09:15:11 -0700 (PDT) MIME-Version: 1.0 References: <1586852011-37536-1-git-send-email-venkatkumar.duvvuru@broadcom.com> <1586938751-32808-1-git-send-email-venkatkumar.duvvuru@broadcom.com> <8320ae09-1b90-63c6-e61e-5891d54daef0@intel.com> <8fc7449b-ccf3-b99a-47c0-18640764df4f@intel.com> <2e54fe5e-8e52-dcc5-81a7-40a6c5ec650a@intel.com> In-Reply-To: <2e54fe5e-8e52-dcc5-81a7-40a6c5ec650a@intel.com> From: Ajit Khaparde Date: Fri, 17 Apr 2020 09:14:55 -0700 Message-ID: To: Ferruh Yigit Cc: Venkat Duvvuru , dpdk-dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v4 00/34] add support for host based flow table management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Apr 17, 2020 at 4:03 AM Ferruh Yigit wrote= : > On 4/17/2020 9:37 AM, Ferruh Yigit wrote: > > On 4/16/2020 6:51 PM, Ajit Khaparde wrote: > >> > >> > >> On Thu, Apr 16, 2020 at 10:40 AM Ferruh Yigit >> > wrote: > >> > >> On 4/15/2020 9:18 AM, Venkat Duvvuru wrote: > >> > This patchset introduces a new mechanism to allow host-memory > based > >> > flow table management. This should allow higher flow scalability > >> > than what is currently supported. This new approach also defines= a > >> > new rte_flow parser, and mapper which currently supports basic > packet > >> > classification in receive path. The patchset uses a newly > implemented > >> > control-plane firmware interface which optimizes flow insertions > and > >> > deletions. > >> > > >> > This is a baseline patchset with limited scale. Follow on patche= s > will > >> > add support for more protocol headers, rte_flow attributes, > actions > >> > and such. > >> > > >> > This is a tech preview feature, hence disabled by default and ca= n > be enabled > >> > using bnxt devargs. For ex: "-w > 0000:0d:00.0,host-based-truflow=3D1=E2=80=9D. > >> > > >> > v3=3D=3D>v4 > >> > =3D=3D=3D=3D=3D=3D=3D > >> > 1. Fixed some more compilation issues reported by CI > >> > > >> > Ajit Kumar Khaparde (1): > >> > net/bnxt: add updated dpdk hsi structure > >> > > >> > Farah Smith (2): > >> > net/bnxt: add tf core identifier support > >> > net/bnxt: add tf core table scope support > >> > > >> > Kishore Padmanabha (8): > >> > net/bnxt: match rte flow items with flow template patterns > >> > net/bnxt: match rte flow actions with flow template actions > >> > net/bnxt: add support for rte flow item parsing > >> > net/bnxt: add support for rte flow action parsing > >> > net/bnxt: add support for rte flow create driver hook > >> > net/bnxt: add support for rte flow validate driver hook > >> > net/bnxt: add support for rte flow destroy driver hook > >> > net/bnxt: add support for rte flow flush driver hook > >> > > >> > Michael Wildt (4): > >> > net/bnxt: add initial tf core session open > >> > net/bnxt: add initial tf core session close support > >> > net/bnxt: add tf core session sram functions > >> > net/bnxt: add resource manager functionality > >> > > >> > Mike Baucom (5): > >> > net/bnxt: add helper functions for blob/regfile ops > >> > net/bnxt: add support to process action tables > >> > net/bnxt: add support to process key tables > >> > net/bnxt: add support to free key and action tables > >> > net/bnxt: add support to alloc and program key and act tbls > >> > > >> > Pete Spreadborough (2): > >> > net/bnxt: add truflow message handlers > >> > net/bnxt: add EM/EEM functionality > >> > > >> > Randy Schacher (1): > >> > net/bnxt: update hwrm prep to use ptr > >> > > >> > Shahaji Bhosle (2): > >> > net/bnxt: add initial tf core resource mgmt support > >> > net/bnxt: add tf core TCAM support > >> > > >> > Venkat Duvvuru (9): > >> > net/bnxt: fetch SVIF information from the firmware > >> > net/bnxt: fetch vnic info from DPDK port > >> > net/bnxt: add devargs parameter for host memory based TRUFLOW > feature > >> > net/bnxt: add support for ULP session manager init > >> > net/bnxt: add support for ULP session manager cleanup > >> > net/bnxt: register tf rte flow ops > >> > net/bnxt: disable vector mode when host based TRUFLOW is enabl= ed > >> > net/bnxt: add support for injecting mark into packet=E2=80=99s= mbuf > >> > net/bnxt: enable meson build on truflow code > >> > > >> > >> Hi Ajit, > >> > >> If there will be a new version, I suggest following commit titles, > if they make > >> sense can you update accordingly? > >> > >> net/bnxt: update HSI structure > >> net/bnxt: update HWRM prep to use pointer > >> net/bnxt: add TruFlow message handlers > >> net/bnxt: add initial TruFlow core session open > >> net/bnxt: add initial TruFlow core session close > >> net/bnxt: add TruFlow core session SRAM > >> net/bnxt: add initial TruFlow core resource management > >> net/bnxt: add resource manager > >> net/bnxt: add TruFlow core identifier > >> net/bnxt: support TruFlow core TCAM > >> net/bnxt: support TruFlow core table scope > >> net/bnxt: support EM/EEM > >> net/bnxt: fetch SVIF information from firmware > >> net/bnxt: fetch VNIC info > >> net/bnxt: support host memory based TruFlow > >> net/bnxt: support ULP session manager init > >> net/bnxt: support ULP session manager cleanup > >> net/bnxt: add helper functions for blob/regfile ops > >> net/bnxt: support process action tables > >> net/bnxt: support process key tables > >> net/bnxt: support freeing key and action tables > >> net/bnxt: support alloc and program key and act tables > >> net/bnxt: match flow API items with flow template patterns > >> net/bnxt: match flow API actions with flow template actions > >> net/bnxt: support flow API item parsing > >> net/bnxt: support flow API action parsing > >> net/bnxt: support flow API create > >> net/bnxt: support flow API validate > >> net/bnxt: support flow API destroy > >> net/bnxt: support flow API flush > >> net/bnxt: register TruFlow flow API ops > >> net/bnxt: disable vector mode on host based TruFlow > >> net/bnxt: support marking packet > >> net/bnxt: enable meson build on TruFlow > >> > >> Ferruh, > >> These look ok to me. > >> Do you want me to respin the set or can you handle it this time? > >> I am fine with both. > > > > Hi Ajit, > > > > Let me check if I can fix the build errors quickly, if so it is easier > for me to > > handle myself. If I can't fix them I will ping you. > > > > Fixed and pulled. > Thanks Ferruh.