From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2D01CA0547; Sun, 17 Oct 2021 16:47:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C3D640041; Sun, 17 Oct 2021 16:47:03 +0200 (CEST) Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) by mails.dpdk.org (Postfix) with ESMTP id B8EF54003C for ; Sun, 17 Oct 2021 16:47:01 +0200 (CEST) Received: by mail-io1-f50.google.com with SMTP id i189so13370225ioa.1 for ; Sun, 17 Oct 2021 07:47:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Pq2+sIBm9gJAJDTidlcuGVGv5Jd+nftshRty1q7Y3V8=; b=Or8wlrPHtZVPheC5mRWd/rKjrl/2XP5AHwdWiQFgcfSKLbw5WWmQaywrF7zEvas+YH 0RcZF3dnjJC8K5JH8mfaDcmn2YeCbvfplkg79iy4HRWSMwLqgMpBZ4B5l4R0rGs/Er2Z rBnf9P859txawD1fA19WY48LStmmmstHy1C6A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Pq2+sIBm9gJAJDTidlcuGVGv5Jd+nftshRty1q7Y3V8=; b=48kIiIWavbeozDK5bBq0Qjhc7Hm2UuMiJlWv4AiE2UiG3uXSEpHBYpJvow/eYHeHyG k6dFfbEFTZz377RHViYo6eehTwlIY5lGg5T73EThxnWdukL6MVcZhvcVfR0fKE5g+n1Y prBpqPZvoeLPMVP8WCGKUnvOcYIvnObn7xhdp+NbL5jLcbIHwjGRxEmM76LUtNMwEW/Y gCsOLrbovO6ntNYt0fROpI8FePVAoGvdNuFyVHiYTqhoEMmnaYN8KwGS22Ubiv1dclI1 xVM8BlpW32A/M8gtX7jnNkEUuFYu1JubOTCxqYKgWn4yHglm4cu7BpYPBmR1uksoYNYt ScWA== X-Gm-Message-State: AOAM531eA1Wk5Fcfvc1YHeRrLI0W9kT4GwQzRwgbg6hiXDE9yacUY0J1 UKkuZUVpUNI4gcK6/n+r+Nn+tJbH/52akvClTSGaDDt5N+WJjg== X-Google-Smtp-Source: ABdhPJy7sS0qb6pcvtF9vm7n6Kyujabnn8wALkpUE6nfrABDnbxourz1TNsw7ZqQjjuoolT/T9hetnJwtfPBzEbQD38= X-Received: by 2002:a05:6638:140f:: with SMTP id k15mr9568252jad.33.1634482021104; Sun, 17 Oct 2021 07:47:01 -0700 (PDT) MIME-Version: 1.0 References: <20210929214817.18082-1-olivier.matz@6wind.com> <20211015192408.21798-1-olivier.matz@6wind.com> <20211015192408.21798-3-olivier.matz@6wind.com> In-Reply-To: From: Ajit Khaparde Date: Sun, 17 Oct 2021 07:46:45 -0700 Message-ID: To: Andrew Rybchenko Cc: Olivier Matz , dpdk-dev , David Marchand Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 2/4] mbuf: mark old VLAN offload flags as deprecated X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Oct 16, 2021 at 12:50 AM Andrew Rybchenko wrote: > > On 10/15/21 10:24 PM, Olivier Matz wrote: > > The flags PKT_TX_VLAN_PKT and PKT_TX_QINQ_PKT are > > marked as deprecated since commit 380a7aab1ae2 ("mbuf: rename deprecated > > VLAN flags") (2017). But they were not using the RTE_DEPRECATED > > macro, because it did not exist at this time. Add it, and replace > > usage of these flags. > > > > Signed-off-by: Olivier Matz > > Acked-by: Andrew Rybchenko Acked-by: Ajit Khaparde > > I'd remove these flags completely. 4 years is definitely > enough. Yes, I realize that because of missing > RTE_DEPRECATED markup users were not warning on build.