From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Kalesh A P <kalesh-anakkur.purayil@broadcom.com>
Cc: dpdk-dev <dev@dpdk.org>, Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix double allocation of ring groups
Date: Wed, 1 Sep 2021 17:40:44 -0700 [thread overview]
Message-ID: <CACZ4nhs8NsJXjOu0+Gj=8f9LcEpUxGqcFJBCnLrOKxzbxpcb_w@mail.gmail.com> (raw)
In-Reply-To: <20210901040001.18378-1-kalesh-anakkur.purayil@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 1672 bytes --]
On Tue, Aug 31, 2021 at 8:39 PM Kalesh A P
<kalesh-anakkur.purayil@broadcom.com> wrote:
>
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> After commit "d68249f88266", driver allocates ring groups in
> bnxt_alloc_hwrm_rx_ring(). But during port start, driver invokes
> bnxt_alloc_hwrm_rx_ring() followed by bnxt_alloc_all_hwrm_ring_grps().
> This will cause the FW command failure in bnxt_alloc_all_hwrm_ring_grps().
>
> To fix this, just don't create the ring group if it is already created.
>
> Fixes: d68249f88266 ("net/bnxt: update ring group after ring stop start")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Reviewed-by: Lance Richardson <lance.richardson@broadcom.com>
Patch applied to dpdk-next-net-brcm. Thanks
> ---
> drivers/net/bnxt/bnxt_hwrm.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
> index f29d574..f65dc72 100644
> --- a/drivers/net/bnxt/bnxt_hwrm.c
> +++ b/drivers/net/bnxt/bnxt_hwrm.c
> @@ -1864,6 +1864,10 @@ int bnxt_hwrm_ring_grp_alloc(struct bnxt *bp, unsigned int idx)
> struct hwrm_ring_grp_alloc_input req = {.req_type = 0 };
> struct hwrm_ring_grp_alloc_output *resp = bp->hwrm_cmd_resp_addr;
>
> + /* Don't attempt to re-create the ring group if it is already created */
> + if (bp->grp_info[idx].fw_grp_id != INVALID_HW_RING_ID)
> + return 0;
> +
> HWRM_PREP(&req, HWRM_RING_GRP_ALLOC, BNXT_USE_CHIMP_MB);
>
> req.cr = rte_cpu_to_le_16(bp->grp_info[idx].cp_fw_ring_id);
> --
> 2.10.1
>
prev parent reply other threads:[~2021-09-02 0:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 4:00 Kalesh A P
2021-09-02 0:40 ` Ajit Khaparde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACZ4nhs8NsJXjOu0+Gj=8f9LcEpUxGqcFJBCnLrOKxzbxpcb_w@mail.gmail.com' \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).