From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF422A034F; Tue, 30 Mar 2021 05:12:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 41C5A140F53; Tue, 30 Mar 2021 05:12:03 +0200 (CEST) Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) by mails.dpdk.org (Postfix) with ESMTP id 74910406B4 for ; Tue, 30 Mar 2021 05:12:01 +0200 (CEST) Received: by mail-qt1-f172.google.com with SMTP id y2so10922135qtw.13 for ; Mon, 29 Mar 2021 20:12:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qv5n3TjEf0PsM+8wYNLqUPqkPQKE6QkmsY0wig7OWjw=; b=KBXCoedXjnkzaqiZ1KeRWTC/S+R4f6z+o2fkcrwR0wZmwB+ROlPjJvwnl9UL8+12JW XzowUOQ7GuBi9AWNnJzdiET3w8DWF2e7Mdapvq5nqSpxzwvEunU+wfPCSCcRCgFfrCVt znNri70t9jiKHvtP8jeYvZ2Y+Q78gkVMuY/Wc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qv5n3TjEf0PsM+8wYNLqUPqkPQKE6QkmsY0wig7OWjw=; b=jmNkermHOjPUi2+aqXZk6S+B7pK9slB1q8cQ64Dgs+Gg1/5UPU2d8MB4XMUotxJ/gz QHtx8LYOFkKrUGBRETjnvutOeJ5k8t8WLSi7sEguN8QSs7CyWYvRZQueRWrs4a7AwSYL PMsWFuCnFcfII/nImurzgFvozBNvfdq83TdwAtyYErLsMKxm/qCQXY2hEcPEUkRoJpRg Hmfz1yMG3lWT49UNVFjzBBHfs3TfYI1f/Qj4zNzDlJdle7OK9BKtHXBh0yMzDUJlXZXg J9O7M9DpxdzJbQq/UdG0uvrUSUVDjHcc3HmLSAuWpuqhjke6+XRsNQoPBAEyoKSeEuuy +A0A== X-Gm-Message-State: AOAM531l5iK4jXJA5n3hTdVcTA47ikk27t5aEb/nn+V/hgyuAOHYoz9W FBigIgoYrQY/W2kMDYFMpB+MxWPCjPTTd6sJ7HOmzw== X-Google-Smtp-Source: ABdhPJy4WiVhSx5sN1jK1hjTJcjmV6fxdNJ7E89tC3Sn5bE/IVD4+puzbuXygKL4DpH/eSgNLBsJICvcAcHkhNm/Vxs= X-Received: by 2002:ac8:71d2:: with SMTP id i18mr25559508qtp.371.1617073920347; Mon, 29 Mar 2021 20:12:00 -0700 (PDT) MIME-Version: 1.0 References: <1614906276-34293-1-git-send-email-oulijun@huawei.com> <1617068905-5364-1-git-send-email-humin29@huawei.com> In-Reply-To: <1617068905-5364-1-git-send-email-humin29@huawei.com> From: Ajit Khaparde Date: Mon, 29 Mar 2021 20:11:44 -0700 Message-ID: To: "Min Hu (Connor)" Cc: dpdk-dev , Ferruh Yigit , Xiaoyun Li Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000009e964c05beb85c0d" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH v8] app/testpmd: support multi-process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --0000000000009e964c05beb85c0d Content-Type: text/plain; charset="UTF-8" On Mon, Mar 29, 2021 at 6:48 PM Min Hu (Connor) wrote: > > From: Lijun Ou > > This patch adds multi-process support for testpmd. > The test cmd example as follows: > the primary cmd: > ./dpdk-testpmd -a xxx --proc-type=auto -l 0-1 -- -i \ > --rxq=4 --txq=4 --num-procs=2 --proc-id=0 > > the secondary cmd: > ./dpdk-testpmd -a xxx --proc-type=auto -l 2-3 -- -i \ > --rxq=4 --txq=4 --num-procs=2 --proc-id=1 > > Signed-off-by: Min Hu (Connor) > Signed-off-by: Lijun Ou Some minor nits below. Otherwise looks fine to me. Acked-by: Ajit Khaparde > --- > v8: > * Added warning info about queue numbers and process numbers. > :::snip:::: > +* ``--rxq=N`` > + > + Set the number of Rx queues per port to N. N is the sum of queues used by primary > + and secondary process. Primary process and secondary process should have separate > + queues, and each should occupy at least one queue. Where N should be the multiple > + of number of processes. of the number of processes. > + > +* ``--txq=N`` > + > + Set the number of Tx queues per port to N. N is the sum of queues used by primary > + and secondary process. Primary process and secondary process should have separate > + queues, and each should occupy at least one queue. Where N should be the multiple > + of number of processes. of the number of processes. > + > +* ``--num-procs=N`` > + > + The number of processes which will be used. > + :::: snip :::: > +The number of rings should be a multiple of the number of processes. If not, > +redundant queues will exist after queues are allocated to processes. After RSS is > +enabled, packet loss occurs when traffic is sent to all processes at the same time. > +Some traffic enters redundant queues and cannot be forwarded. > + > +Most dev ops is supported in primary and secondary process. While secondary process Most dev ops are supported in the primary and secondary process. While.... > +is not permitted to allocate or release shared memory, so some ops are not supported > +as follows: > +``dev_configure`` > +``dev_start`` > +``dev_stop`` > +``rx_queue_setup`` > +``tx_queue_setup`` > +``rx_queue_release`` > +``tx_queue_release`` :::: snip::: --0000000000009e964c05beb85c0d--